Message-ID: <473D0737.1040504@cosmosbay.com>
Date: Fri, 16 Nov 2007 03:57:59 +0100
From: Eric Dumazet <dada1@cosmosbay.com>
User-Agent: Thunderbird 2.0.0.9 (Windows/20071031)
MIME-Version: 1.0
To: Ulrich Drepper <drepper@redhat.com>
CC: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, mingo@elte.hu,
       tglx@linutronix.de, torvalds@linux-foundation.org
Subject: Re: [PATCHv2 4/4] first use of sys_indirect system call
References: <200711151822.lAFIMVnJ028596@devserv.devel.redhat.com>
In-Reply-To: <200711151822.lAFIMVnJ028596@devserv.devel.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 863
Lines: 23

Ulrich Drepper a ?crit :
> This is a first user of sys_indirect.  Several of the socket-related system
> calls which produce a file handle now can be passed an additional parameter
> to set the FD_CLOEXEC flag.

> 
> -	retval = sock_map_fd(sock);
> +	retval = sock_map_fd_flags(sock, current->indirect_params.file_flags.flags);

Yes, we know now why you wanted sys_indirect so much :)

However, there should be a macro or something to ease reader mind...

#define INDPARAM(SUBSYSNAME,PARAMNAME) \
	(current->indirect_params.##SUBSYSNAME.##PARAMNAME)

 > +	retval = sock_map_fd_flags(sock, INDPARAM(file_flags,flags));

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/