Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp960771rdg; Wed, 11 Oct 2023 10:04:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHmbJl/B7sWB/UCsSjrkkGKBK/Y98pRdH6JFAx58AfmYWsmTHIO5aTTfowFu1GWgn4XOYYS X-Received: by 2002:a17:90b:e11:b0:27c:f1f8:261f with SMTP id ge17-20020a17090b0e1100b0027cf1f8261fmr4482654pjb.20.1697043896409; Wed, 11 Oct 2023 10:04:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697043896; cv=none; d=google.com; s=arc-20160816; b=NBvJtGcKPM8eGLJX6p5gJYtBgSEX3FWsx4cok4oTSbH6vd3MJUTQbGswkvPcMFbgtN CQo72+qZieQLb9MqiatUMRJbSxuEIhPVw13YDBeswrPuuMK0vX/UxwLepmlOMZuwbIe5 8uPyIw927KOHn8/QdEUN09D5gdAzgB9TUkLm50lz4rQxqai+JJzihRpRhVOmKnY0Zm3j 810pUJ771Hxi+qwclKk5s0G+LdUUm/b4/XKtVyi+glJc4IpcwoqgMcg2DUFx9x9wEbMb YA/JSmaloWuHL6tAErciWWC1UqHCpEGZBU0mYyO/HLwx3DFY+/jn/PVl3XS0/t+rZ4aE +4lA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent :content-transfer-encoding:references:in-reply-to:date:cc:to:from :subject:message-id; bh=bOrMSbCCm0KY1WIkae5DGizF9i9H3w4gxlUuDalDpNk=; fh=uh8Fwim4cYblm8gO44//UT90sr2fsYXVU+i5dSbbiDI=; b=0k3iItHnAEuibz3elYOtVsY6aqchRJm3cm8p3D/rZf71WOgJiKhtLejxUnSaAv+23I uDaGdfogl+GcMYFpS7M5B3Bm+m5hEZpXWKbgmKrBTKM9rxB8O8bQ3juXkcfuIMlFDeCA A1r8798ybmP3D5Wl4rjfGKgUGVldS8wNaIugpBhNuv/ZIg9lqfprlfyNfaZZN1R7jwwp rbpM0qBvohpplXVCF37AaA0/yUrxwdh0xEaKwjn6Ltvzuyg5PVLWD6zEZq8FT92yj+8o A967kqZfB0yf2NC+SQOvbbN6auPl3+T6jjhTbcCyYbaak6ToVr+1oYo7zwJ9sPcNPyJ4 ircw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id l14-20020a17090a49ce00b002773cc10d3csi231330pjm.78.2023.10.11.10.04.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Oct 2023 10:04:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 95CC580D2901; Wed, 11 Oct 2023 10:04:53 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347019AbjJKREn convert rfc822-to-8bit (ORCPT + 99 others); Wed, 11 Oct 2023 13:04:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235152AbjJKREj (ORCPT ); Wed, 11 Oct 2023 13:04:39 -0400 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0292AE0 for ; Wed, 11 Oct 2023 10:04:37 -0700 (PDT) Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[IPv6:::1]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qqcdM-0006JO-Tw; Wed, 11 Oct 2023 19:04:32 +0200 Message-ID: <3ce3b7b7e7c4344b8a36b2f73ff560e4e3cf8459.camel@pengutronix.de> Subject: Re: [PATCH] drm/etnaviv: Drop the 'len' parameter of etnaviv_iommu_map() function From: Lucas Stach To: Sui Jingfeng , Russell King , Christian Gmeiner Cc: etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Date: Wed, 11 Oct 2023 19:04:32 +0200 In-Reply-To: <20231007070312.1026296-1-suijingfeng@loongson.cn> References: <20231007070312.1026296-1-suijingfeng@loongson.cn> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:900:1d::77 X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=2.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Wed, 11 Oct 2023 10:04:53 -0700 (PDT) X-Spam-Level: ** Am Samstag, dem 07.10.2023 um 15:03 +0800 schrieb Sui Jingfeng: > The 'len' parameter is the 4th argument, because it is not get used, so > drop it. No functional change. > > Signed-off-by: Sui Jingfeng Thanks, applied to my etnaviv/next branch. Regards, Lucas > --- > drivers/gpu/drm/etnaviv/etnaviv_mmu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/etnaviv/etnaviv_mmu.c b/drivers/gpu/drm/etnaviv/etnaviv_mmu.c > index 4fa72567183a..1661d589bf3e 100644 > --- a/drivers/gpu/drm/etnaviv/etnaviv_mmu.c > +++ b/drivers/gpu/drm/etnaviv/etnaviv_mmu.c > @@ -70,7 +70,7 @@ static int etnaviv_context_map(struct etnaviv_iommu_context *context, > } > > static int etnaviv_iommu_map(struct etnaviv_iommu_context *context, u32 iova, > - struct sg_table *sgt, unsigned len, int prot) > + struct sg_table *sgt, int prot) > { struct scatterlist *sg; > unsigned int da = iova; > unsigned int i; > @@ -314,7 +314,7 @@ int etnaviv_iommu_map_gem(struct etnaviv_iommu_context *context, > goto unlock; > > mapping->iova = node->start; > - ret = etnaviv_iommu_map(context, node->start, sgt, etnaviv_obj->base.size, > + ret = etnaviv_iommu_map(context, node->start, sgt, > ETNAVIV_PROT_READ | ETNAVIV_PROT_WRITE); > > if (ret < 0) {