Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp968498rdg; Wed, 11 Oct 2023 10:16:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHch/6bSl/mB/5rtQkrihOm8qjJ9MqT68n1HvJmkClmFCV9PTL+wvoLs4+XjRcjQBfgWLOP X-Received: by 2002:a05:6358:430c:b0:133:b42:69ca with SMTP id r12-20020a056358430c00b001330b4269camr24944218rwc.18.1697044614718; Wed, 11 Oct 2023 10:16:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697044614; cv=none; d=google.com; s=arc-20160816; b=JXG9zAvgfuXPwFBPyYpv8hR4g4QZFIf64/I2H+IzhazCxjXhGPLtOf+MWoRxYIgHvm 0Pzl7ZU0G51FHs1pXsTj/rPg4LQCbkSfvOHsZ+hWjEQNLpV1/f7VvS/RjvbDx/kvJmD1 3PtpgXJLy7uoYt52ALE4ThYjcaPotrGpjI1AG1wdgliYUYuK4IMsE7r07cAWmfXROMXv waNypctKl+3UlxDXjSuW8TBPjSGIUKFtmoD4C9+QeK9Ghh97wHlEFQpNFd5mNCYzHU7k O04aRwx1eUN7uBwUJlpQ/5cRw0V/qqxQX/MZ0qSHFka+DErPJIYJtQGGPQaZWgoag8WD Nw9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=2op6AOMjCwvz5244AdvWGMzgmCyF6sLIAzm8gLHtTkI=; fh=E19bjrjZy2AmMaCEnZZfZ5E2Y1CcXFc9Pz+dooTioeY=; b=hsYvdZ8PAV7vV3LSfwwhjvq5HFgKHnSVry6ZlUDzJA07CWHKGL/QgccA/syWBPVmM/ YaDg0K0XiMyIFER5CKn5rCOPrdfPnKI2v3pWVQWP8XmiHd4DgXVbEcCbJAZOT5/9tpQL 7OmldJbG088x+gqPB4HmorrEESXRdmHWuOTJdxLOrepjY0XLVtGhfGrnYoHgI6yONfSx 3n4pzrM+dHHnaes3g5lhCRfHuwO3aDsTftiDAP8BmdQMrpMbDWfj8f/w8tTYjmlreuWn N0N0n6Yh6JYa7s7siAaaof0W9Ktkl+foEa9YBuw00SsSNtaZNZBRraYPyRDDJcJcMUvY E0cw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=1J9d6+7z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id e9-20020a056a00162900b00690fb3c5cecsi11984145pfc.16.2023.10.11.10.16.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Oct 2023 10:16:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=1J9d6+7z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 7A4FC807DE23; Wed, 11 Oct 2023 10:16:52 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231221AbjJKRQo (ORCPT + 99 others); Wed, 11 Oct 2023 13:16:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230234AbjJKRQm (ORCPT ); Wed, 11 Oct 2023 13:16:42 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 974409D for ; Wed, 11 Oct 2023 10:16:41 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 65BA2C433C7; Wed, 11 Oct 2023 17:16:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1697044601; bh=TEhjbZnKeCuYcpy8YH4MZnjE3TXkJzgENB/x7EN+cuU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=1J9d6+7zMUgTcVgfTY5jOcVYBvPnpzXdjNrzds9YjcySqZ7KT97+bH1Z6EcIdbmls DgwNkBrZFJMkupYWIiQr5j8JkMR4hP/gCvVZaPjYj79TWFeSas2SDZ0pChVFp8sWkW POoR0ykaPJ4dZmeUAfuvbnpC/+HPLG4piV8DatsA= Date: Wed, 11 Oct 2023 10:16:17 -0700 From: Andrew Morton To: Mel Gorman Cc: Huang Ying , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Arjan Van De Ven , Vlastimil Babka , David Hildenbrand , Johannes Weiner , Dave Hansen , Michal Hocko , Pavel Tatashin , Matthew Wilcox , Christoph Lameter Subject: Re: [PATCH 01/10] mm, pcp: avoid to drain PCP when process exit Message-Id: <20231011101617.2f814633defaa13e77308d9b@linux-foundation.org> In-Reply-To: <20231011124610.4punxroovolyvmgr@techsingularity.net> References: <20230920061856.257597-1-ying.huang@intel.com> <20230920061856.257597-2-ying.huang@intel.com> <20231011124610.4punxroovolyvmgr@techsingularity.net> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 11 Oct 2023 10:16:52 -0700 (PDT) On Wed, 11 Oct 2023 13:46:10 +0100 Mel Gorman wrote: > > --- a/include/linux/mmzone.h > > +++ b/include/linux/mmzone.h > > @@ -676,12 +676,15 @@ enum zone_watermarks { > > #define high_wmark_pages(z) (z->_watermark[WMARK_HIGH] + z->watermark_boost) > > #define wmark_pages(z, i) (z->_watermark[i] + z->watermark_boost) > > > > +#define PCPF_PREV_FREE_HIGH_ORDER 0x01 > > + > > The meaning of the flag and its intent should have been documented. I need to rebase mm-stable for other reasons. So let's please decide (soon) whether Mel's review comments can be addressed via add-on patches or whether I should drop this version of this series altogether, during that rebase.