Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Subject: Re: [PATCH v2 2/7] serial: amba-pl011: get rid of useless wrapper
 pl011_get_rs485_mode()
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     Lino Sanfilippo <l.sanfilippo@kunbus.com>, jirislaby@kernel.org,
        ilpo.jarvinen@linux.intel.com, shawnguo@kernel.org,
        s.hauer@pengutronix.de, mcoquelin.stm32@gmail.com,
        alexandre.torgue@foss.st.com, cniedermaier@dh-electronics.com,
        linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
        lukas@wunner.de, p.rosenberger@kunbus.com
References: <20231011173829.10508-1-l.sanfilippo@kunbus.com>
 <20231011173829.10508-3-l.sanfilippo@kunbus.com>
 <2023101134-theater-oversleep-a58b@gregkh>
 <20d22e11-b9be-b547-ec4e-9964a57924a4@gmx.de>
 <2023101101-knoll-dust-6308@gregkh>
From:   Lino Sanfilippo <LinoSanfilippo@gmx.de>
Message-ID: <447eecb3-1ebc-e8ea-db6c-9964ef9fd0db@gmx.de>
Date:   Wed, 11 Oct 2023 19:49:13 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <2023101101-knoll-dust-6308@gregkh>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:IteMFpbMUBQ=;wjRF8QhpTpFpjyp7JvmrW+OQ55k
 bQJkm4Fe86TzUm0nnTrYhzHqb5xqylyYBI/oBLHa4pNXjrtk6uCit6zn6Rxh6LJEWgkRRC/qg
 e5uyFqKYMGLIExRiUs39+fI5RlXMtctsgsc6LNM8wa4SX4WiFdd9udePmFBuTfHGi/H3Mvy30
 oGEIARVkvAwW9wC4T5MOcZ6g4Z2uOAWWjdI9CyDCexwpCA5Qq0L52YVj4bS5yjClvEW2E4jCv
 EPZikOjaTFIWXNWwKwKCJlHXraknTL2sBTzm/OU4+5Tdmpbzap/ni9Pml3pvsJIWqyQDr0wGL
 Lna5OeyAcOJAAKWN3EOf0sZNyeRfGd1/rw3TrPA4JZJit9mIkM7DuyLh21dMUKG6ZAbou72nF
 jDCMqQ52Fkyd+v8RlOG4DWyq1pf8o3rc2SJ90Q1mWwUDRUuiVCI5xQPfPSBUicpipQEggQLPQ
 zuLxT4eiSQ4Oy522Xv8bx4YowcWF5rjkIzK25qULAIP9wOOrjd8Js08jJdUX7yGAKiZBevedE
 jBEGYN/osUHg9kkcG9eaTXCzqTvW2fvaqfd5tQjnnUrkbpLViuDDvJm21j6RJsELG/sz95n0s
 qACNaxBwvT9J8wFA1mns0hJfOZRVBDOh7g33bEb/XDvd9ibIFZGuGrirT6p9IVuAeokO1yy6F
 LeobZ3GW3Wsu9Q4TOQjsFdJpG41QKMz64ougaeVSfck4gffLjk5KIuVTV24jZcvEpO2OpPqEJ
 U/qpfV4zSCzZhpA7HzoQkyKZ39xdM/r1R7ONJRTr/xXZKP4/Z2p4HGldsyzIv1K0LvUJVIlTT
 N6KpMqukaJqq/1HgAm/11CZRulbgiXFg58kr1stbZLdKDWfm4LS+XcZtGTholpp4C+Awy30WC
 lvxLmOE2wQZdRDA4WsHKSCjWLioa6mIUuPpUPmhRsdc1VO4wMgO32qZ4ra7oPMC3XarwBvaUx
 StvmQg==
Precedence: bulk

On 11.10.23 at 19:47, Greg KH wrote:
> On Wed, Oct 11, 2023 at 07:44:51PM +0200, Lino Sanfilippo wrote:
>>
>> Hi,
>>
>> On 11.10.23 at 19:42, Greg KH wrote:
>>> On Wed, Oct 11, 2023 at 07:38:24PM +0200, Lino Sanfilippo wrote:
>>>> Due to earlier code changes function pl011_get_rs485_mode() is now me=
rely
>>>> a wrapper for uart_get_rs485_mode() which does not add any further
>>>> functionality. So remove it and instead call uart_get_rs485_mode()
>>>> directly.
>>>>
>>>> Reviewed-by: Lukas Wunner <lukas@wunner.de>
>>>> Signed-off-by: Lino Sanfilippo <l.sanfilippo@kunbus.com>
>>>> ---
>>>>  drivers/tty/serial/amba-pl011.c | 14 +-------------
>>>>  1 file changed, 1 insertion(+), 13 deletions(-)
>>>
>>> Why is patch 2/7 not cc: stable, when patches 3-7 are?  Either this
>>> patch isn't needed in this series, and can go later (or to a different
>>> branch), or it also needs to be marked for stable as the later patches
>>> depend on it?
>>>
>>
>> 2/7 is really only a cleanup patch that does not provide a bugfix.
>> Should I remove it from this series?
>
> Please do, and send it later, or as part of a separate patch series
> independant of this one.
>

Ok will do so.

BR,
Lino