Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <da777a72-55d1-4ee3-91c8-30afe7659f54@gmail.com>
Date:   Wed, 11 Oct 2023 20:13:24 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] [RFC] wireless: move obsolete drivers to staging
Content-Language: en-US
To:     Arnd Bergmann <arnd@kernel.org>, Kalle Valo <kvalo@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Arnd Bergmann <arnd@arndb.de>,
        Nicolas Ferre <nicolas.ferre@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Beznea <claudiu.beznea@tuxon.dev>,
        Jakub Kicinski <kuba@kernel.org>, Pavel Machek <pavel@ucw.cz>,
        "David S. Miller" <davem@davemloft.net>,
        Larry Finger <Larry.Finger@lwfinger.net>,
        linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev
References: <20231010155444.858483-1-arnd@kernel.org>
From:   Philipp Hortmann <philipp.g.hortmann@gmail.com>
In-Reply-To: <20231010155444.858483-1-arnd@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/10/23 17:27, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de> While looking at the old drivers 
> using the obsolete .ndo_do_ioctl() callback, I found a number of network 
> drivers that are especially obsolete, in particular for 802.11b 
> (11Mbit/s) or even older wireless networks, using non-busmaster 
> ISA/PCMCIA style bus interfaces, and using the legacy wireless extension 
> ioctls rather than the netlink interfaces that were meant to replace 
> them in 2007. All of these drivers are obsolete or orphaned. We had 
> previously discussed this topic, but nobody ever moved the files, so I 
> now went through the list to my best knowledge. These are the drivers 
> that I would classify as "probably unused" by now:

I found a USB WLAN Stick with a rtl8192u. I got it last Saturday and 
found out that the firmware is missing in my ubuntu 20.04. I found it on 
the web and fixed it. When I started the driver my computer crashed. The 
missing part was: priv->priv_wq = alloc_workqueue("priv_wq", 0, 0); 
Fixing this the next error was a network = kzalloc(sizeof(*network), 
GFP_KERNEL); in wrong context with leads to a crash of my computer. 
Fixing this leads to another issue which lets my computer crash.

For me the firmware of rtl8192u was intentionally missing because of the 
issues with the driver.

What this has to do with your question?
Can we check for missing firmware in main distributions to know which 
drivers are considered to be old and unused?

Bye Philipp