Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <211f9333-393f-4fb3-bdab-23840791af45@infradead.org>
Date:   Wed, 11 Oct 2023 12:21:04 -0700
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [char-misc-next 2/3] mei: docs: add missing entries to kdoc in
 struct mei_cfg_idx
Content-Language: en-US
To:     Tomas Winkler <tomas.winkler@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Alexander Usyskin <alexander.usyskin@intel.com>,
        Vitaly Lubart <vitaly.lubart@intel.com>,
        linux-kernel@vger.kernel.org
References: <20231011074301.223879-1-tomas.winkler@intel.com>
 <20231011074301.223879-3-tomas.winkler@intel.com>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20231011074301.223879-3-tomas.winkler@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 10/11/23 00:43, Tomas Winkler wrote:
> Document all entries in struct mei_cfg_idx.
> 
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>

Reviewed-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.


> ---
>  drivers/misc/mei/hw-me.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/misc/mei/hw-me.h b/drivers/misc/mei/hw-me.h
> index 95cf830b7c7b63e1cf555048..204b92af6c4785beb23f0212 100644
> --- a/drivers/misc/mei/hw-me.h
> +++ b/drivers/misc/mei/hw-me.h
> @@ -102,10 +102,14 @@ static inline bool mei_me_hw_use_polling(const struct mei_me_hw *hw)
>   * @MEI_ME_PCH12_SPS_CFG:  Platform Controller Hub Gen12 5.0 and newer
>   *                         servers platforms with quirk for
>   *                         SPS firmware exclusion.
> + * @MEI_ME_PCH12_SPS_ITOUCH_CFG: Platform Controller Hub Gen12
> + *                         client platforms (iTouch)
>   * @MEI_ME_PCH15_CFG:      Platform Controller Hub Gen15 and newer
>   * @MEI_ME_PCH15_SPS_CFG:  Platform Controller Hub Gen15 and newer
>   *                         servers platforms with quirk for
>   *                         SPS firmware exclusion.
> + * @MEI_ME_GSC_CFG:        Graphics System Controller
> + * @MEI_ME_GSCFI_CFG:      Graphics System Controller Firmware Interface
>   * @MEI_ME_NUM_CFG:        Upper Sentinel.
>   */
>  enum mei_cfg_idx {

-- 
~Randy