Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Message-ID: <42a5c36d-8b65-418f-9826-2808ab49d67a@linux.microsoft.com>
Date:   Wed, 11 Oct 2023 12:56:40 -0700
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] acpi: Use access_width over register_width for system
 memory accesses
Content-Language: en-US
To:     "Rafael J. Wysocki" <rafael@kernel.org>
Cc:     Len Brown <lenb@kernel.org>,
        "open list:ACPI" <linux-acpi@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
References: <20230925180552.76071-1-jarredwhite@linux.microsoft.com>
 <CAJZ5v0iHJcZzF=hGLRH+tT6uqCrfHbLw_KJD5dSRRTrsbeVMUQ@mail.gmail.com>
From:   Jarred White <jarredwhite@linux.microsoft.com>
In-Reply-To: <CAJZ5v0iHJcZzF=hGLRH+tT6uqCrfHbLw_KJD5dSRRTrsbeVMUQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 10/3/2023 11:50 AM, Rafael J. Wysocki wrote:
 > On Mon, Sep 25, 2023 at 8:06 PM Jarred White
 > <jarredwhite@linux.microsoft.com> wrote:
 >> To align with ACPI 6.3+, since bit_width can be any 8-bit value, we 
cannot
 >> depend on it being always on a clean 8b boundary. Instead, use 
access_width
 >> to determine the size and use the offset and width to shift and mask the
 >> bit swe want to read/write out. Make sure to add a check for system 
memory
 >> since pcc redefines the access_width to subspace id.
 > This is fine, but what if there are systems in the field where
 > bit_width is invalid, but they just happen to work because of the way
 > it is currently handled?
For the kernel coding style issues, I will clean up for the v2 patch.

On the invalid bit_width for systems out there in the field, do you have 
any suggestions on how to handle this particular scenario? Would it be 
appropriate to add a kernel parameter flag that can revert back to the 
previous implementation?

P.S. Sorry for the HTML email.


Thanks,
Jarred