Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp1105572rdg; Wed, 11 Oct 2023 14:54:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEB6A4hDMqohv1VoCSOtv0oWqGO7exjRjaEMUZlAh4Mt3vhhaMPi90s+U0Us4dqj7E5C7m8 X-Received: by 2002:a17:902:ea8d:b0:1c0:c640:3f3e with SMTP id x13-20020a170902ea8d00b001c0c6403f3emr20464512plb.42.1697061271754; Wed, 11 Oct 2023 14:54:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697061271; cv=none; d=google.com; s=arc-20160816; b=w9w9x75pgkKSlyqzXSki59q4hM2in31oRrLXkbilRWQ4oj4nPpWmlQVuX2J8c8062Y MqbLddIlkYLFf2Gb++WycCR14vVypdBhIWe1ubRkH24QtjGdfdyqltveWhrlrDfqEBwv D0QD5/rzWww7BU/Js4zsV3AABC6137+A+KjuMIuqA/5LQ4vlJpBwzKoBGJ+WOYTTfVW5 NSMt0IrRVnFdogBAwRcQ3hBVjozhuDlFumb3m078/aYSNhzm1ZNJ79GDoq84lNNS0Sma 16TQAf8KllLKZfkadximcl34AxMJjwWi8Ua3EMXuvtbiM7Kru6aKK76ChYfosZC8/T+D t3pA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=ohH/miBpn5ItkKls4R/7tm9vrnVTWoPlqg4hiAS+YR8=; fh=gdl8WeqnBTzCQkSj3LOqyT0hb/ur0CsVvOiU/+eqYqQ=; b=XkaXSaYErtBssMem7qAD2Um8RA7XZ6gNGblWPVkE3M9VNVU8pM2vqooR7bQW1ArNn+ WenhgxT0OR6I1D8yn5LC5Td3J4jEqHXEq9Dhdl1bfAyHvtnhi3VvPynaYZNHNHHBb0rO Q+MWxF3U6KNZms3vb32x8Y2/kNpGRd9rcBZ7KcoOLX9eWWn2V+QR4oOg6CPz1lcRKutJ 1FK78txQziP53Z5EcJoixktcv1zO/BAgEtAX7yBVEh/H5Agb1h13xwxhMXsnuTNWroxl Xh+NUq8yPrYmmRBKsc24BVugTCFCCtjeiJqAZfNfFrZbgMg/lI66dWTJP0SvQAVIrWL5 mDJA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=OQECjdpq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id j7-20020a170903024700b001c9b1c1006asi669748plh.212.2023.10.11.14.54.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Oct 2023 14:54:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=OQECjdpq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id DCEAF81376BD; Wed, 11 Oct 2023 14:54:30 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235183AbjJKVy1 (ORCPT + 99 others); Wed, 11 Oct 2023 17:54:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233714AbjJKVyV (ORCPT ); Wed, 11 Oct 2023 17:54:21 -0400 Received: from mail-io1-xd35.google.com (mail-io1-xd35.google.com [IPv6:2607:f8b0:4864:20::d35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFD6AB7 for ; Wed, 11 Oct 2023 14:54:19 -0700 (PDT) Received: by mail-io1-xd35.google.com with SMTP id ca18e2360f4ac-7748ca56133so5238739f.0 for ; Wed, 11 Oct 2023 14:54:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1697061259; x=1697666059; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ohH/miBpn5ItkKls4R/7tm9vrnVTWoPlqg4hiAS+YR8=; b=OQECjdpqT+SFnGPjgr+Cs/tPZJYm3xPF4CkaVWrGKCzdR9HktfmS7jDPFAnPa1dlib z+JBc3AzSCA43YtoRrFd3/Y7IGC0z6UM7o4EgRZKvSaY7cIiwtxa5CpM9Zis+LPYTQjs 85NZ+Idnlx2VJPGSRYl8GZ8KLVqVtsPf9zT15I/8HXQ8v+z0i0B/HnNN0uGZNbJ9LcF3 w6HuR56Xkb+bXNvKaQ96JNPWpqLy/0q6LD9ClynJXrMtBVeuHBC+zAVOtIzQC+5rsqoK V75r0x3/ajG6RUVZIv03OTbMfDdeH80ZR4i/L3+FXbvgIiBcobf8e5sfMBloLzVgS/N2 qI9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697061259; x=1697666059; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ohH/miBpn5ItkKls4R/7tm9vrnVTWoPlqg4hiAS+YR8=; b=W8UikqHk0vcogTAMKKuhWoxzgOfoLCOeuLZXYOB0iUOEjMOOKKeCvBBcEMEhV6WSQA 5kpJaFwdzh7qnW3eAdgkTK1f3THKnHblgeEwhNqAwnKt3jRZLm/77VMEScs5gI2f2CmN ekCEkXb/vy1Y6CYaYSU5kyCpOEUc0WUghU24NFJx1v8JIr2Ezx3Htm8mbmWtlfVj52Vi pe2LRRbTScgxIDQBS31iJqbojA51e5Equveh+q9hRrZ768ODMd6SNmS12h9JfDkFsawF 2mXatwJpsxGf95TkMCEt+oOu11uZXVxQBHZbZpPNFl0FJ7ZGIe+ae9//IpA3Rm+a1lr8 M8ww== X-Gm-Message-State: AOJu0Yw+vq/OU0544XT/gMzZhfooG3r5HqEhePNifZWWh1KEhhmD6iiD c4FAdHxgGAG8VG6d0plcfvK1mA== X-Received: by 2002:a05:6602:3a05:b0:792:6be4:3dcb with SMTP id by5-20020a0566023a0500b007926be43dcbmr23320945iob.2.1697061259360; Wed, 11 Oct 2023 14:54:19 -0700 (PDT) Received: from [127.0.0.1] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id bx9-20020a056602418900b007870289f4fdsm1168180iob.51.2023.10.11.14.54.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Oct 2023 14:54:18 -0700 (PDT) From: Jens Axboe To: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Sarthak Kukreti Cc: Bart Van Assche , "Darrick J. Wong" , stable@vger.kernel.org, "Darrick J . Wong" , Christoph Hellwig , Mike Snitzer In-Reply-To: <20231011201230.750105-1-sarthakkukreti@chromium.org> References: <20231011201230.750105-1-sarthakkukreti@chromium.org> Subject: Re: [PATCH] block: Don't invalidate pagecache for invalid falloc modes Message-Id: <169706125840.1583104.3695441099284489023.b4-ty@kernel.dk> Date: Wed, 11 Oct 2023 15:54:18 -0600 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.13-dev-034f2 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 11 Oct 2023 14:54:31 -0700 (PDT) On Wed, 11 Oct 2023 13:12:30 -0700, Sarthak Kukreti wrote: > Only call truncate_bdev_range() if the fallocate mode is > supported. This fixes a bug where data in the pagecache > could be invalidated if the fallocate() was called on the > block device with an invalid mode. > > Applied, thanks! [1/1] block: Don't invalidate pagecache for invalid falloc modes commit: 1364a3c391aedfeb32aa025303ead3d7c91cdf9d Best regards, -- Jens Axboe