Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp1119627rdg; Wed, 11 Oct 2023 15:25:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHT9pqCy2NVS+gdxtK5Gs2WbN54HSSe5+/2Wahc2pcQEyAstfrhaiLDJMLEyWwxSV7lSI0q X-Received: by 2002:a05:6870:7026:b0:1d4:fe03:73e with SMTP id u38-20020a056870702600b001d4fe03073emr27292562oae.52.1697063159416; Wed, 11 Oct 2023 15:25:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697063159; cv=none; d=google.com; s=arc-20160816; b=NZgzd/aD1yUaT7SZuESyK1RLbzQNfOg7OkVpLCLr16hsNXb61TshM5tr7FzlQfhaYN mft+Gy/NJUlzaDHQqlc6d39iOGtDfv+04UAYr6Q0vqNde98f7ZknN6cQlhFF1aWv3zUU SVzUNnoboHQU/62UrevUzpps5xwzPvQk0Y2dYVAIqMs/5nBvydPmx1+AjsBFzIESaltQ BpCD6UVKPCETpyme/gQEQXx9tb1U3I/ffdxHtpUUSfOWm26VSKtypixp9NoTVd5ozSsA Xm/cSGr+h6TKcwtgq0SPD9aq3OYCnnmufA7xRhIjMGtvG7gOemoLxISi0WhYRZagTV2g W03g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=0zNZbeMMG66zQaffulwZBSRVTQq7xegGVzsE2aBNQYM=; fh=XVYvreW8MzMWOZJgV7HFuOQW0/mSRnphJxE0Uxp8f+A=; b=HojedyvRXK70tK5sNTQX32Z8hFx6TkTRsHr95G+J8CHTruJmT1hAJjzlDdYxVPAn1S AIpa49Yb46RWGfyl/9dLNDux6Lfa5KqWUxsC0bzPgrg562XcwEEfOxeMcmmQpHF7kGbi 13O7P8rckl8DGn9n51QYJXV6nYpPOwrYPTCNQqLs8ySU5zBXIx99tX5uOkOrbnZZEreO nr38vaUoo+2y66xEc66gI3IpNkFZYkqx0pDMFxeLdjXu4nHjrqD2v2RUjMRgX0t0VmKI M3h+uI7W6+Wb2c12L4RUmdFpaPrWSLmSByo5o0/YnaSFSEBOkd8GgdZgc5/oEpje3pos 6h0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b="Vk/CYjVR"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id u2-20020a631402000000b0059c02d055c4si724112pgl.668.2023.10.11.15.25.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Oct 2023 15:25:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b="Vk/CYjVR"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 590E181143DF; Wed, 11 Oct 2023 15:25:56 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235161AbjJKWZq (ORCPT + 99 others); Wed, 11 Oct 2023 18:25:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231927AbjJKWZo (ORCPT ); Wed, 11 Oct 2023 18:25:44 -0400 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B462AF for ; Wed, 11 Oct 2023 15:25:42 -0700 (PDT) Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-53da72739c3so602178a12.3 for ; Wed, 11 Oct 2023 15:25:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1697063141; x=1697667941; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=0zNZbeMMG66zQaffulwZBSRVTQq7xegGVzsE2aBNQYM=; b=Vk/CYjVRmA34OY+cWbPCRDyipcQMzmvE274FhS1JKNS7qXEDNQCfkR6gNwl/dE5tDp 8MEkMZUYsKWt5LARKCwqd7jGWhaSVohomXmAWgjXc2TjBsvZHLy45m3IW1jAbPQNmXe9 KrxqDKnv+5hedt45/0i1elPvPUD82nDWJwOn9mheHyXBowaOfT0McQqHUcBmRXoBqlD1 Ih0evblLZSAJNkvwxxRqkm7CE89EeVc6euI21eVVQ/yuFO9+/NltplYmM1wsejtlMA2a gm1kuU0JDdUVxSSxPsU9L+M65R93YQTlqSeGeKf8dO5ByvmTyW4g2VcuTbx3j72Hs+5X QI3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697063141; x=1697667941; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0zNZbeMMG66zQaffulwZBSRVTQq7xegGVzsE2aBNQYM=; b=bP1nxEhChd6gZsrWLUs8SFUiv+7QLwOqoOdlcTDUshoJPgpbPnYCNZEwf67jE6PiQo iOC2XBrUFo+bVt8ekbO2NNf6RnSkzbQnoEWCv1Wt04NnuHTS1B2zIPJi91tBv78vF+H5 oM5YcYPX+EeYVpFxicqkgkz6GTRHxnipH1nj+WLaR1yuDqWS1L+eKrY8HlfNKMTgyNxa xzBvizicN1+zNBlld3ktRrRlU++7BVZfEc5sAg7jIjMhV2pEQYY8MKaLco7D/hhR8ENT ZMMyRxfTIvGo2t+J2YWtGdx0tSt+DGa6DxtoMdNx0yDQDV9/yxxREaunJ6oCEeIE8Xhi AsiQ== X-Gm-Message-State: AOJu0YxCVs6tbeocMg/Jg1cn4oAm/1ZQHrgV499WC6QF/VLtMrApQ09k gJ42NloNXhC/UmYGCdkJsnQ7lCT7fG1wYezJZMi7Zw== X-Received: by 2002:aa7:d297:0:b0:533:1acb:7134 with SMTP id w23-20020aa7d297000000b005331acb7134mr21589053edq.23.1697063141000; Wed, 11 Oct 2023 15:25:41 -0700 (PDT) MIME-Version: 1.0 References: <20231011-strncpy-drivers-net-ethernet-pensando-ionic-ionic_main-c-v1-1-23c62a16ff58@google.com> In-Reply-To: From: Justin Stitt Date: Wed, 11 Oct 2023 15:25:29 -0700 Message-ID: Subject: Re: [PATCH] ionic: replace deprecated strncpy with strscpy To: "Nelson, Shannon" Cc: Brett Creeley , drivers@pensando.io, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.8 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 11 Oct 2023 15:25:56 -0700 (PDT) On Wed, Oct 11, 2023 at 3:17=E2=80=AFPM Nelson, Shannon wrote: > > On 10/11/2023 2:53 PM, 'Justin Stitt' via Pensando Drivers wrote: > > > > strncpy() is deprecated for use on NUL-terminated destination strings > > [1] and as such we should prefer more robust and less ambiguous string > > interfaces. > > > > NUL-padding is not needed due to `ident` being memset'd to 0 just befor= e > > the copy. > > > > Considering the above, a suitable replacement is `strscpy` [2] due to > > the fact that it guarantees NUL-termination on the destination buffer > > without unnecessarily NUL-padding. > > > > Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#st= rncpy-on-nul-terminated-strings [1] > > Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en= .html [2] > > Link: https://github.com/KSPP/linux/issues/90 > > Cc: linux-hardening@vger.kernel.org > > Signed-off-by: Justin Stitt > > Thanks, I suspected this was coming soon :-) > > Reviewed-by: Shannon Nelson Thanks Shannon! > > > > --- > > Note: build-tested only. > > > > Found with: $ rg "strncpy\(" > > --- > > drivers/net/ethernet/pensando/ionic/ionic_main.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/ethernet/pensando/ionic/ionic_main.c b/drivers= /net/ethernet/pensando/ionic/ionic_main.c > > index 1dc79cecc5cc..835577392178 100644 > > --- a/drivers/net/ethernet/pensando/ionic/ionic_main.c > > +++ b/drivers/net/ethernet/pensando/ionic/ionic_main.c > > @@ -554,8 +554,8 @@ int ionic_identify(struct ionic *ionic) > > memset(ident, 0, sizeof(*ident)); > > > > ident->drv.os_type =3D cpu_to_le32(IONIC_OS_TYPE_LINUX); > > - strncpy(ident->drv.driver_ver_str, UTS_RELEASE, > > - sizeof(ident->drv.driver_ver_str) - 1); > > + strscpy(ident->drv.driver_ver_str, UTS_RELEASE, > > + sizeof(ident->drv.driver_ver_str)); > > > > mutex_lock(&ionic->dev_cmd_lock); > > > > > > --- > > base-commit: cbf3a2cb156a2c911d8f38d8247814b4c07f49a2 > > change-id: 20231011-strncpy-drivers-net-ethernet-pensando-ionic-ionic_m= ain-c-709f8f1ea312 > > > > Best regards, > > -- > > Justin Stitt > >