Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Sender: Ingo Molnar <mingo.kernel.org@gmail.com>
Date:   Thu, 12 Oct 2023 00:42:42 +0200
From:   Ingo Molnar <mingo@kernel.org>
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     Josh Poimboeuf <jpoimboe@kernel.org>,
        Borislav Petkov <bp@alien8.de>,
        David Kaplan <david.kaplan@amd.com>, x86@kernel.org,
        luto@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] Revert "x86/retpoline: Remove
 .text..__x86.return_thunk section"
Message-ID: <ZSck4mcr6sKS/ob7@gmail.com>
References: <20231010171020.462211-1-david.kaplan@amd.com>
 <20231010171020.462211-2-david.kaplan@amd.com>
 <20231010174833.GG14330@noisy.programming.kicks-ass.net>
 <20231010195721.p5pb273kevg7ydxz@treble>
 <20231010200429.GIZSWuTWSUM9aId7a6@fat_crate.local>
 <20231010201912.7pjksbparssqu34k@treble>
 <20231010212254.ypk2wdogno55shit@treble>
 <20231011074142.GK14330@noisy.programming.kicks-ass.net>
 <20231011162843.grv6kixw4ides6uw@treble>
 <20231011223513.GH6307@noisy.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231011223513.GH6307@noisy.programming.kicks-ass.net>
Precedence: bulk


* Peter Zijlstra <peterz@infradead.org> wrote:

> I don't care too deeply, I can't make up my mind either way. But perhaps 
> keeping the section is easier on all the backports, it's easy to forget a 
> tiny objtool patch like this.

If the objtool fix has a Fixes tag that points to one of the major 
mitigation commits, then it won't be forgotten.

Arguably the new objtool is more robust against what could happen, so that 
patch is not going away - and with that patch mainline doesn't have to keep 
the (now ...) pointless section.

Maybe change the commit order around: first add the objtool fix, then 
remove the section, pointing back to the objtool SHA1 in the very next 
commit, explaining that the objtool fix enables this change. That makes it 
all backporting-proof as well.

Thanks,

	Ingo