Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <75fe5f3f-41d7-76f8-47f9-9178fa030804@nvidia.com>
Date:   Wed, 11 Oct 2023 15:59:19 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.15.1
Subject: Re: [PATCH v2 0/4] hte: Improve GPIO handling and other cleanups
Content-Language: en-US
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        timestamp@lists.linux.dev, linux-tegra@vger.kernel.org
Cc:     Bartosz Golaszewski <brgl@bgdev.pl>,
        Andy Shevchenko <andy@kernel.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>
References: <20231011202638.372382-1-andriy.shevchenko@linux.intel.com>
From:   Dipen Patel <dipenp@nvidia.com>
In-Reply-To: <20231011202638.372382-1-andriy.shevchenko@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bHh3S2Z6WEFWQ3RVdSs3TktKYnhYK29TWStIVWtIcFhZWGd4aThJMGxVVnRZ?=
 =?utf-8?B?cGZmbzFJNmxvNWZ6Q3M0WHFCTkFBK1FhK2xVRHRCSmZ5TzIyNWUzcGVNbEVX?=
 =?utf-8?B?RTVDRGpPSS9oL0tZOUNJU0oySEQ0VGxSVmRzSFYyb3hFSlNDaXBCZjZMbC9y?=
 =?utf-8?B?THRXeU1hRnhhUEhuNW9KeDVWRll5bUUxL0M1ZTMzK1dPV3JqK3pRcjg5M0Rz?=
 =?utf-8?B?TDUwRjQyeEsvZGo5QXZxRlBQSDVyN24rQ2tibmtlUW5PSkhOSHprNVh0bWlj?=
 =?utf-8?B?dTluNHpqQ1RZM1FTOHpaWEdPTE1IMnk0ZktFdUtEcjVkZnpIUmkyR245M1JK?=
 =?utf-8?B?bStaUEdYVGVzMVdpMEdFNVU0cHo1Y1ViWkgxQ2FqRFFOdHJrUXVjM3dpVFl4?=
 =?utf-8?B?bFQrMXEzWmdJTTd3b0FzME9nNUczM2Y0OFlEalVHVGx5dkZuKyt6NjVkOUlo?=
 =?utf-8?B?QTdwYmgzcXEzWmcvaWMzbEVNamNlZmc1a09oSnFEZUpSYlNqRHkvSG55NnU1?=
 =?utf-8?B?ZkVhUFc2ZDB2Sm5oUzNFdGpIOElqZzlsaHpnSTlMRzB6TkxPK25iWGU5K0ln?=
 =?utf-8?B?RCtuMWNFb29XMy8vYnNVb1RqT2w0V01ySHdaMzVHM2lTaENVeS9FNEtRZTF2?=
 =?utf-8?B?TVk0TGVVNE84cDE2QW5FcEw2YVkxeTgyS3orbjlNVFhoTk9VNmROZllNZXEx?=
 =?utf-8?B?dnNIZFlkUTU0RDQ0STNXVGJ0dmdEZWROVWhGQUJBY0FqTUJYSzRqcTRxbjhP?=
 =?utf-8?B?U3NieWhHUWNicUtTV1k2U0VpTUViL0VtbTBadUNWamNmbkZOM1NhRXYvbDRT?=
 =?utf-8?B?Rzkra3FoOGJyalJOZWdzQm1YTkZieXFGYzM0akxneTkyTkRPWE5id3Uxc0xH?=
 =?utf-8?B?Q3Fad25xTk1POU8vTy9EOVE3VTFNZXA3YmZGWXRmRkhVZEZFWThydWhBL3hw?=
 =?utf-8?B?a1ZiQXZWSmRiNVd2bDdLbGdyTUtoQ0d1bWxpZVlxTzByeGZuUkRUL2pHK1Vt?=
 =?utf-8?B?MEVJRDl3ZDVjeUl2czZrUzV3ak5pUC9xd1RXT0RyK1FLL29CaUk0QkRYZWF5?=
 =?utf-8?B?OG1ucW5FejZ2T01aNUs4dmd3L3AzLzdLc3BSUnh2NUpwVGozZkVrdDRyVUVp?=
 =?utf-8?B?SithL3libGlmelNBMXhDKzZYdjdGd2svY0hrQmhJdEpRQ0ZVTnh1L0tnZEQ1?=
 =?utf-8?B?clJLMXY4SGM1b3ZySjlxR2xlNkYrcU5jNGZ6MmFWeTk5WnZyTk9XSUkvK3RJ?=
 =?utf-8?B?Ry9mcENLWDk3K2ZkUm5XSzE5MWtrZzFtVUJiSzVGTmNtMERMeno0aE5KNU9P?=
 =?utf-8?B?QXE3UEVJb0dHQXlPbWlXVDJ6bHpHUGhRM1k1eldMQnAyZzB6ZHpnVnZOeGx3?=
 =?utf-8?B?YjJkNEd1dVJMZFZieU9TRU04aFU1ZEY3cXdxWGFvZGdsenllQWxiWHo1MmFK?=
 =?utf-8?B?bU9YSWVkVXdrYmQ4R0pieEtCaUdHK3FwTU1DdHQwSkx6UW0xaXJNYUc3eGxQ?=
 =?utf-8?B?WnVGbnV3NkpWKzZXeTdTaUpMRVY5Vmgvd09UNHRWVm5KZGprcmRrNjhpNmpB?=
 =?utf-8?B?RzFlZTB4TXRFWXpTTThwZnZ5RzAzSkJrem1QWlVVTTNYVS9pYlBXOHZ5eXo3?=
 =?utf-8?B?Z1pzUy8xbFRRTk9ydEVhS2p1dlI2OVZzUFo3cHlwWHIwTjVJNWtjRG4xQ29h?=
 =?utf-8?B?NEJKVzgxTHloVTdTWjh4Z0lJck1IaEZaMXhoeWdCQ0g0UnExU0M1VkZuam9l?=
 =?utf-8?B?aVFiSzdQOHZvTjVCWXMwMzY3TWNjUmNBazk1OG8rcVFuNUkwSUhKZkJPU2xG?=
 =?utf-8?B?NHV4MzJxOHVSRGhzWEV1TGZDVjl3ZVozaHJtVFlPVmw3M1h2UnErZ25BL0Zt?=
 =?utf-8?B?Mk93U3RXNW5QN1dKdlRobVo4MGd4R21nQUQrYmJxa0RQV2JJZXdVMTVIMlIy?=
 =?utf-8?B?aTRDSytWWGxzeDdpUVI5OWdxVG9kMzNDOFJadEFZMkFXd3N4WnNadFhmTzNH?=
 =?utf-8?B?OGo4VUZMQk41NCtFUjZMMldJQUdHbW9uR1c3K1Q2S1lUZmNLUVRMWTlHYTl4?=
 =?utf-8?B?VUREZm5pSW91dm43bkZPTGNra0NQWjhLRHoxcVRHRmJnNllSQ0lXckQyYk9R?=
 =?utf-8?Q?C29ZFEOYa1pDoKOc6/pU/oh6J?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 40798249-44bc-4c5d-3525-08dbcaadb68c
X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6604.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2023 22:59:24.5725
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: H9/9h3BB1tkBauyZcBGK0xUWqEPs/G9JBjJ+9Sd6ZszALNS8XjA8CpkOVVXZ+NY9Rne9U5MlicTnDs58qTYtrg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5251
X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,
	URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 11 Oct 2023 15:59:38 -0700 (PDT)

On 10/11/23 1:26 PM, Andy Shevchenko wrote:
> This is a series that provides a new API to GPIO library (so far only
> available in the GPIO tree), and respective update to the Tegra
> HTE driver. On top a couple of other cleaups (patches 3 & 4, they
> can be applied separately).
> 
> Patch 2 inherited tags from its respective discussion thread [1].
> 
> Due to dependencies this either should be applied to the GPIO tree,
> or to the HTE when GPIO updates land the upstream (optionally with
> the first patch be applied even now to the GPIO tree independently).
> 
> Another option is to have an immutable branch or tag, but I assume
> that was discussed and rejected (?) in [1].
> 
> In v2:
> - collected tags (Linus, Dipen) 
> - fixed couple of typos (Dipen)
> 
> Link: https://lore.kernel.org/linux-gpio/20230905185309.131295-15-brgl@bgdev.pl/ [1]
> Cc: Dipen Patel <dipenp@nvidia.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> 
> Andy Shevchenko (3):
>   gpiolib: provide gpio_device_find_by_fwnode()
>   hte: tegra194: Remove redundant dev_err()
>   hte: tegra194: Switch to LATE_SIMPLE_DEV_PM_OPS()
> 
> Bartosz Golaszewski (1):
>   hte: tegra194: don't access struct gpio_chip
> 
>  drivers/gpio/gpiolib.c      | 20 ++++++++++++++++
>  drivers/hte/hte-tegra194.c  | 46 +++++++++++++++++++------------------
>  include/linux/gpio/driver.h |  1 +
>  3 files changed, 45 insertions(+), 22 deletions(-)
> 
Looks great...I am going to assume you are going to push patches 1 and 2 through
gpio subsystem and rest through HTE, right?

Reviewed-by: Dipen Patel <dipenp@nvidia.com>
Tested-by: Dipen Patel <dipenp@nvidia.com>