Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Date:   Wed, 11 Oct 2023 20:34:52 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Robin Murphy <robin.murphy@arm.com>
Cc:     joro@8bytes.org, will@kernel.org, iommu@lists.linux.dev,
        baolu.lu@linux.intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/7] iommu: Factor out some helpers
Message-ID: <20231011233452.GD3952@nvidia.com>
References: <cover.1697047261.git.robin.murphy@arm.com>
 <72c599ef84ac29c9759c7f0ecc7bd69fa9aaf5c1.1697047261.git.robin.murphy@arm.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <72c599ef84ac29c9759c7f0ecc7bd69fa9aaf5c1.1697047261.git.robin.murphy@arm.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?p+6G9YiQR2+to4ZA/nMdH03CQFBgSbZCKI0wMu3OYfyyTaZK2t3c+OoZAncR?=
 =?us-ascii?Q?OkdV8pJ2gdbCuu4/y9zLFbbxn3xsMedHQDm4WS+8bs/MFf0q5kECR9kp9+KK?=
 =?us-ascii?Q?Wq9UQBPZsa9UgCx09MErA1/wzX7YwUW3fXWCZ3PP6Fkg76BCHRF3f9L0/tEH?=
 =?us-ascii?Q?krbkTrHrgXz6IJn6/FHHgoed5+1V0m7LxELli6YDrNQuMTkjhjh8DVw1RrwE?=
 =?us-ascii?Q?9QB05y9zUomqJJ/dt8lVmPcRnnYy+drTFN7/WVEcNWVnQV3tep+/+XmabG1R?=
 =?us-ascii?Q?PIfSHruBtCXSpqkZCt2PrwY6UTVGxPBanL+DN3BdauYqUXDu32I4IkHY4znJ?=
 =?us-ascii?Q?IOhzCELdpyWcZMJkSV+3n+yA5jI1EsBnxsgUCt/upcTLpQ+fI1QqM7vfaXRp?=
 =?us-ascii?Q?b+E27lj2o3zOzzl8q/rE4XP9JUdX+F492FfMxRNb9/AlHe/zz0GZ3YabTfyp?=
 =?us-ascii?Q?pH6ZYEw7D9bOgbLdEBBwtYqHlDHfLYqv3iILU76MnEkIX2PjKDYGbwDWRIhJ?=
 =?us-ascii?Q?RgnDesQ0Ffoe7rMWlauz/VfrBgmc7Bgb3ymd1YrEVp6BJA7QQxVMlFr3dvbu?=
 =?us-ascii?Q?CXwJO3M/XE0Q8KEcbm17aoHd8d7Ybg6PyYnv/k+RsbDGLdrQwnFMDQTzExjr?=
 =?us-ascii?Q?p7rTFcnSb1/4uJYnSrZ4RiN+uzMBNUKqfbg+hF02qolGYMSqQ/4w2DKqHaFD?=
 =?us-ascii?Q?TO8IlP2rliukFciXAleYzMly83lxPslz4XIc+ZpJDSq6j/PMkYXntpoZFobk?=
 =?us-ascii?Q?uAJhxFS1L5BA1a4LmxjWG4BcvBhiRzywsFu462suPN+FLcrlUqWXMqLwXj7P?=
 =?us-ascii?Q?60UOoGY/0YaydQc5uaq83Q5xEuzV3JstiXx4VJkdtU3FalU6fXF4H2lZ+VyU?=
 =?us-ascii?Q?3+ivB43s8y69RVNpd3YFzb2eQPyamIMBpfeIJO4597BVYV+bLpHF5JN8ANhk?=
 =?us-ascii?Q?Dy5Ng776TZMXZr5mD4LQllqd7Jccg2XHaa93r19HqMok3WVCa0H9JXHVtVqo?=
 =?us-ascii?Q?H24G9ADbLZMAMSW+K6/7+gEzDXUaZCSDr9ZTxJdCXawtL9edTRrljXarVtWD?=
 =?us-ascii?Q?G2XT08+VrWbuFrMGFTrgOQQlw/uR9yP04ESZjvOpPrfNcW3SccvnXdlsU16T?=
 =?us-ascii?Q?CfFOqcGljXTnfsE98LJJ3eeHbVHAMMaKYxeBLqBKCq0YhNlymr+h72ZHIacp?=
 =?us-ascii?Q?TQWJl3N7ifGh/6ED7QluaNgikQPTuNxtDmbYbrDMv3A3TND3C/F156nD2wMZ?=
 =?us-ascii?Q?90TUXbOufYuWuIUdp0XyEoTNTpQt4Y/XYbCrUCH801oy7daB9eHTHhy7Zb4j?=
 =?us-ascii?Q?p7iYJWcqrCFt/UmY6BYQWvmqvjluf8kJL4uMsGzlBZE1h4tUmSFQeIpCXdmu?=
 =?us-ascii?Q?c/QyF4DyxeoYtZBpHXEhgTX3r+jOSVQHiyDq+KLpcSwWizyTSPR+DxCD8GNE?=
 =?us-ascii?Q?Wa91AIniVrHY12ZM4rTaHOHEPjHsHBDOQ0/98Wwi7XkaqJHUTFxUHqljxXG/?=
 =?us-ascii?Q?aveyg8sPt1eFOQxAbhKTyC7aGUTxJwN2/JcqmgKge89xA1IEQdy86Zs8K2nX?=
 =?us-ascii?Q?+HDPfl24y9bOGAKkP/VCMA1Ego+1Kz50B3z+pXTU?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cea029b1-1def-460f-2721-08dbcab2aba8
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2023 23:34:53.6965
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oWjokfUv6HKz7rzytAXAGXBnjrUjSIcNcVnXvtK0vQhppcBhTrjEqaNRXMhchEXY
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB9346
X-Spam-Status: No, score=2.7 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,
	URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 11 Oct 2023 16:35:13 -0700 (PDT)
X-Spam-Level: **

On Wed, Oct 11, 2023 at 07:14:48PM +0100, Robin Murphy wrote:
> The pattern for picking the first device out of the group list is
> repeated a few times now, so it's clearly worth factoring out, which
> also helps hide the iommu_group_dev detail from places that don't need
> to know. Similarly, the safety check for dev_iommu_ops() at certain
> public interfaces starts looking a bit repetitive, and might not be
> completely obvious at first glance, so let's factor that out for clarity
> as well, in preparation for more uses of both.
> 
> Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> 
> ---
> 
> v3: Rename dev_iommu_ops_valid() to reflect what it's actually checking,
>     rather than an implied consequence.
> v4: Rebase, also catch the sneaky one in iommu_get_group_resv_regions()
>     which wasn't the full pattern (but really should be since it guards
>     the dev_iommu_ops() invocation in iommu_get_resv_regions()).
> ---
>  drivers/iommu/iommu.c | 56 ++++++++++++++++++++-----------------------
>  1 file changed, 26 insertions(+), 30 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason