Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Date:   Wed, 11 Oct 2023 20:38:40 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Robin Murphy <robin.murphy@arm.com>
Cc:     joro@8bytes.org, will@kernel.org, iommu@lists.linux.dev,
        baolu.lu@linux.intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 4/7] iommu: Decouple iommu_domain_alloc() from bus ops
Message-ID: <20231011233840.GE3952@nvidia.com>
References: <cover.1697047261.git.robin.murphy@arm.com>
 <81a0a66d76b3826f1a0b55d7fbaf0986034c7abc.1697047261.git.robin.murphy@arm.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <81a0a66d76b3826f1a0b55d7fbaf0986034c7abc.1697047261.git.robin.murphy@arm.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?MB/VT17GQG61rpWVA2kZ4LynNUECWwuLHx5YLVBNwIfoP6vb8eUlx7R9LA5b?=
 =?us-ascii?Q?lriOxa5I+mGkfAXxypYZSAjnf0/R8UO8W3xY2RRNWHSv4kDW94pdxOICDuLL?=
 =?us-ascii?Q?6tXOup0lS9dGf4Slw3r2kB21+taRLc3L/jeP8RFoM5K4EfFkGpmufBKvJ40/?=
 =?us-ascii?Q?1vEYcfVHSRH23GK1NHqLL57PsikDH7ML7Eza0+FjP6uI0qioiRinfA/6plFV?=
 =?us-ascii?Q?NsqANDUJMxGvC0TwJVpe17rhV05k31yyemfg7pQBq6AGHBnJOrXrAlIqZbeG?=
 =?us-ascii?Q?ZpGmiDp5i93O932ZFIek6QvNbYnbzOuOhlcjUzhRcaKdy/g7UHEFJOUoex/+?=
 =?us-ascii?Q?ME1xmDEaV9srIvln9xCADDLETx9EjIio4ZUfEB/7aMF7rxRpS/mfixmmuneL?=
 =?us-ascii?Q?XtqVtSvp/fHOukA84LReRafriI7Wc9Xne4hH/bqYjvLTEw2S/CAqQgll09fA?=
 =?us-ascii?Q?9Ft0ZjKAnYnC+R9sk9NsOiGELS2HXZhT5gAw177DvtEq2qK/PHMV+H9pyK9n?=
 =?us-ascii?Q?MiVZJIVgQezPn5W6EJGEREsEDtV+CwI4O7hdAOwQ0KlFcmR4l1iVHfKD8P9A?=
 =?us-ascii?Q?UmZtFP6GXFYfa3qsFjS5Botj45X5K0533gksJwKLFXCwc6Gn2rPpAdyl083J?=
 =?us-ascii?Q?fVJnW5AZW31k5phyrooVt+FgjqsEPVrty/oraUMYEa+FToo+bZICReWc7Y7J?=
 =?us-ascii?Q?vYQzbPchNZXTQBOAR5g1nXfFM47BURA+WWS+dioat/OSWXXLGEiJE1kmGDz/?=
 =?us-ascii?Q?ws4h+kCzbeOcWruRR/oTVcxiFsQNLWUoz4VkvoBM7/EnMgiKSgTGdDmqkDow?=
 =?us-ascii?Q?8Ii4uoTOv6PlzGU9rw61ZvtTC2RRpLuAkJV+s/Mpp0WyVrxwyFe+ygtDz/u2?=
 =?us-ascii?Q?kOdaJQbCVbfOcwh6TcajTMc0Pc0BkXE5VbhTTAvE07lT3CSpLxj5tGhXEEIc?=
 =?us-ascii?Q?rGZ8XxSDmDgh0KWNM5Rt6p7FC8H6YdzR8gaX42h8J0QABfgeOOAOeyiW9PSv?=
 =?us-ascii?Q?QFUXncxl88O9xs3BwTTz7nb4lhqqmKQbw8c7DnlxHDUpQJTU83PwKv6CPpCh?=
 =?us-ascii?Q?wfEf+CDvfakEsF4UmoKOlijujHgtpMYYp4drD5dzyNFD/gp+LjGYkZKhmjSr?=
 =?us-ascii?Q?1Pw356S5ywQyNU3eR3OFT/1nr+/47D8/+zjGA4GFeHzkS2+BiQ47Hn9KHACE?=
 =?us-ascii?Q?4brwB00UtyE5a+yCv3iNlHuU0wZ6wO5l5vBPU4oqD2I937jLropoLahcKZKO?=
 =?us-ascii?Q?hhQwTFt+4ZS3dk4D8ByaKEOi/sqj4ybBr/5ULJ/XI78kn6ntsAPibC5QVKtg?=
 =?us-ascii?Q?vTh2fSDPPPyWA5r/HhR73+3No65LvIxewU5NlB4U+AQ2oK4wBYoxEd8jgWwc?=
 =?us-ascii?Q?FJ+bNT5e6mL08zQXAqjEZgV70XSiJryJ6P8ITGzZwW+JTzthIbbe1jJDZFuc?=
 =?us-ascii?Q?jjD5l3Ds3kNkEjHn6EZRmuTBR+3Qo5qu9guK6gueBmM/wwA4t7yFsu77/2rX?=
 =?us-ascii?Q?GxOfGGx9lojE6qGf0FowzKct/5xg8iEv1hdVG5nZORBleETC0EkcKHpbUWEh?=
 =?us-ascii?Q?/hk2hFLOfl+AYzhM0J9k+MPa6lwTLT5b9phPMP3s?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2edce219-e350-480e-4fb2-08dbcab3334e
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2023 23:38:41.4534
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: c5+IfhLAobqCx64MbdwZ1IlBXC/ZrlpERpBuhffvtJqphd5A6EFnlXlP6EMINoMp
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4037
X-Spam-Status: No, score=2.7 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,
	URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 11 Oct 2023 16:38:56 -0700 (PDT)
X-Spam-Level: **

On Wed, Oct 11, 2023 at 07:14:51PM +0100, Robin Murphy wrote:
> As the final remaining piece of bus-dependent API, iommu_domain_alloc()
> can now take responsibility for the "one iommu_ops per bus" rule for
> itself. It turns out we can't safely make the internal allocation call
> any more group-based or device-based yet - that will have to wait until
> the external callers can pass the right thing - but we can at least get
> as far as deriving "bus ops" based on which driver is actually managing
> devices on the given bus, rather than whichever driver won the race to
> register first.
> 
> This will then leave us able to convert the last of the core internals
> over to the IOMMU-instance model, allow multiple drivers to register and
> actually coexist (modulo the above limitation for unmanaged domain users
> in the short term), and start trying to solve the long-standing
> iommu_probe_device() mess.
> 
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> 
> ---
> 
> v5: Rewrite, de-scoping to just retrieve ops under the same assumptions
>     as the existing code.
> ---
>  drivers/iommu/iommu.c | 25 ++++++++++++++++++++++---
>  1 file changed, 22 insertions(+), 3 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

FWIW, I was thinking afterwords that domain_alloc_paging() probably
should have been:

(domain_alloc_paging *)(struct iommu_device *iommu, struct iommu_group *group)

Most drivers can use the iommu and ignore the group, a few special
ones can do the needed reduce operation across the group.

We can get to that later when we get deeper into the PASID troubles,
it also requires the deferal of the domain creation like the bus code
probe does but the fwnode path doesn't :\

Jason