Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp1171569rdg; Wed, 11 Oct 2023 17:31:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGQalOmZZ0LbNH+f/gS/azPg3kQZldRBoHUAPXNBjwsLZlQ3ky+/rZgUDLcgA2jj5vu4jG/ X-Received: by 2002:a05:6a20:1a9d:b0:158:17e6:7a6 with SMTP id ci29-20020a056a201a9d00b0015817e607a6mr19029531pzb.42.1697070684132; Wed, 11 Oct 2023 17:31:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697070684; cv=none; d=google.com; s=arc-20160816; b=rk96vYFVcp7DLuZVQ6VsExP4zBgw/T0eADthITrA2uX2BCmGl3AD9fMrV6kpNuvfjP 3NEx0DUyS4Fi+5pL2ickLMWfYpYxRj1Q0/FWpgJouQ9+1h/5JibYqazgpsV0PJqKeCSv KCS3f1438LZCZFzRNrO/8jMsEZaiO6yoh2K5oo6yl5bsZkduHaYo0xOlSt0/f2P9A7Pm gVS1/9FstUtHh5SaDbBdh4hOXKrS+raMruX1R3ROD0TObd5D75dDcdyvfCLz4YkMPTmV dYSGz0Cjzth0Ys7Hmx/3Kat7AHU/76MPCf76bt0SnIwzNJDjNEOIEZo/IgFUezrd9Yj4 b4Sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=w9S6957i+NnCHp4B/S7/hp4GxzOqIiYI1Y70COizKW4=; fh=C/9P1FSd6hq/33tj56kDLoz0/7LslJbnWmPeAPPuw50=; b=ZJBBpP0UPjiTP6+4GyJZl77iEPewq/rx0GDfKeFzYqkBXL96XRlWzoVpCr66QH/iiR usq4xVCSXd6OyBURxv/tRbMD4MrLvwh+Ca0k1khsIIPjtkuOCA8SZGZRXsrZrNRs9Tcw S6839VlFq0hnrUzFF6+SwVPMtS/8OJFBLGNAuGbTqx2ZK3CcaAYVNufKznyB7uAcZth/ rgagOvQCij4EmUZbdroKzpuVjGnn9PdjrCVzkK/a7NhRmWZnoL1V4My3ogyxNTPj6Ccd GwgCPH1IXJsIDok6TJw6aSYSBufUdBJ/6PUxpYC4AhFLYW2MkbhDNLXgx2BqTN+MIeR0 Zf3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=V7eJ3qhN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id j70-20020a638b49000000b0057751b4abe2si909876pge.111.2023.10.11.17.31.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Oct 2023 17:31:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=V7eJ3qhN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 287DF8069D9B; Wed, 11 Oct 2023 17:30:49 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376583AbjJLAaf (ORCPT + 99 others); Wed, 11 Oct 2023 20:30:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376600AbjJLAa2 (ORCPT ); Wed, 11 Oct 2023 20:30:28 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 418579D for ; Wed, 11 Oct 2023 17:30:26 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPS id BF8EDC433B8; Thu, 12 Oct 2023 00:30:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697070625; bh=JygYXv/iY2L4YfL3LQXXh3cOvpCmrEV6BuAM2IZkvXU=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=V7eJ3qhNjVkM7W5nCe7ih12nbjrJysAUnTPoR5w4YneFbMZzrhySAvPkyZX3AVMys e122Nx+q6x62Pp4oUtkUZdUifT2npjT5Y9Fpa0E1PGCzhcBMxJk6DV0ZDNIpq2taJP paMVYkyF2itpgpRVXmeqqUnwtSoGUioS0Uy3gFOR1G+SK1CH2up+CPKYJYEU75TK8J MC8hfNd64OgOsUfK5lNnhVGJuVAj0gLuiC2aRPXG2JfQoiGgUtFn/nFIRHYjKVe4NJ LaQ9RbZAQ9ngZx/RRL/QFKsuQ+rqHuX3onTREU9ji13+513/nOtDCbPlaC/eVvNbha DohCAI57xzIMw== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id A8421E000BB; Thu, 12 Oct 2023 00:30:25 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] octeontx2-af: replace deprecated strncpy with strscpy From: patchwork-bot+netdevbpf@kernel.org Message-Id: <169707062568.15864.7454843502958715402.git-patchwork-notify@kernel.org> Date: Thu, 12 Oct 2023 00:30:25 +0000 References: <20231010-strncpy-drivers-net-ethernet-marvell-octeontx2-af-cgx-c-v1-1-a443e18f9de8@google.com> In-Reply-To: <20231010-strncpy-drivers-net-ethernet-marvell-octeontx2-af-cgx-c-v1-1-a443e18f9de8@google.com> To: Justin Stitt Cc: sgoutham@marvell.com, lcherian@marvell.com, gakula@marvell.com, jerinj@marvell.com, hkelam@marvell.com, sbhatta@marvell.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 11 Oct 2023 17:30:49 -0700 (PDT) Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Tue, 10 Oct 2023 21:38:11 +0000 you wrote: > `strncpy` is deprecated for use on NUL-terminated destination strings > [1] and as such we should prefer more robust and less ambiguous string > interfaces. > > We can see that linfo->lmac_type is expected to be NUL-terminated based > on the `... - 1`'s present in the current code. Presumably making room > for a NUL-byte at the end of the buffer. > > [...] Here is the summary with links: - octeontx2-af: replace deprecated strncpy with strscpy https://git.kernel.org/netdev/net-next/c/473f8f2d1bfe You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html