Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp49492rdg; Wed, 11 Oct 2023 20:41:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGUCIn8mHGnShPLKnNTDiUp+6DngDZMmHayFgYaJO9F/swcDSMsTJ5fnExrHoih4pxoXUw+ X-Received: by 2002:a05:6808:ab7:b0:3ae:13fd:fa93 with SMTP id r23-20020a0568080ab700b003ae13fdfa93mr23939963oij.15.1697082110252; Wed, 11 Oct 2023 20:41:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697082110; cv=none; d=google.com; s=arc-20160816; b=cuITNs638Rh5fxYfn/HnfUFRjjjrIyLxM0kg54wsa+GTnC9tvEsss9uU53nXv9c7Ko MtYZy9ZFRP+pe/b0sPcdALczIcab5SEEEybsXjw7k6NzaFEShwl2bvNnnvps+DNZdmLQ aaQ0SqdgoX5sYAI6UZEGRV9SVCswjCA/OKvrcA+VPe9OaS1EDIPCazZPjdo0YFtmzhWN PN7rJa0BU1oy7uVbDC9DALWrV6EeYW9Mf2Fd4VOCz8f5UmpFT22+P39jXrhgChpCIA9+ ze3mYFRT66GfovtysRV55jSvxY3W6ZmSo7AR7qOPKzipnAVgpUepJVZz4ZXHAfNllxDS jDLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=UqD/7t0pHiD/A1D+TVC0jVRhUdy6D5qb2bjFC/PdJc4=; fh=7ULreF4shSACETqL5EKqq1dqTe4c5fqVuruIvxQq9Pc=; b=UOnNgO9nRSxLijnZhEB3+xBqw+4c+ymUYAHLgCAJ9IIIYxRMoIglF8GJtJZeqyAYl2 rpBmxYkWx2AUvJIqKBFLtPwyyY/5bsBATY8IP1hvyw8lu2KgHWK/kZlNnoNGwO+i3hWf /A2u7Z2l5LKXjZwNmn7x3f9PCN/b1VYmV3zT87Z331QQ0sV51DFMYnlaQp9SgDRavjY3 4pho94nwCpKOx7t9/raaMSCEmF6fgPa+GjG5Cdre70AkAizv4fEI5hqbwYsCCs8vCbcK 7apQSG7oaiMim+a3RuihErfDPi4MlIl4JO0rZiaBpteNl+O4d/OAH3jncvMlnxRvgmVz Bfmw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=LwybIaBf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id a21-20020a63e855000000b0054405623a4asi1206536pgk.615.2023.10.11.20.41.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Oct 2023 20:41:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=LwybIaBf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 489448023753; Wed, 11 Oct 2023 20:41:47 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343496AbjJLDlh (ORCPT + 99 others); Wed, 11 Oct 2023 23:41:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233652AbjJLDlf (ORCPT ); Wed, 11 Oct 2023 23:41:35 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0936B7 for ; Wed, 11 Oct 2023 20:41:32 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-50433d8385cso791251e87.0 for ; Wed, 11 Oct 2023 20:41:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1697082091; x=1697686891; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=UqD/7t0pHiD/A1D+TVC0jVRhUdy6D5qb2bjFC/PdJc4=; b=LwybIaBfOMlqH2cXmb+Kx6ayznjb8Tf8zWvMsOeWUXSAKiDjsHxlRdjj7h8QH4H59U B6YaMwoP9cY2RF+BJoj4GW37lvjMmayX5dozcSHrNe2VpTMgmqrGW+gaCTjw+N80OH79 Sq68cof+tgqI2k+7mI1E3UPK7eceJFq9rwWwM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697082091; x=1697686891; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UqD/7t0pHiD/A1D+TVC0jVRhUdy6D5qb2bjFC/PdJc4=; b=gxbo2HvcmjGveFV0RgLIUq/PDODWbHpVF1SQ2nq6dQ7SM2f4BmAqDNH8/zq4wBmH59 9F64uB+IXT1+sBTBCPmqmJDLoiD+wKJ3xpx/d0V5BRq2LX77J9oqB+c2uGFjOjYjGvxQ piyKali84Q99Pwjo+rdfjVP41C5aqY+LBhLJgXRmtjN7zdUX52oSQt7CGJQLg0FHHFyh 2NwajgIjA3QfkI9eBV3MKIrChN/x309Fac8eIpdcOvGFbcNfRAnS45P1uIiy+pf2bzNl KscU4YUm2q05NZ+KT6murCNrbIhn3tLCgqBodFqPYLjX17oFywD3Nn7NKpFCtSyXI99C cOmA== X-Gm-Message-State: AOJu0YwHZldlwVHjqfyrHSSFIoUayToRsYBlBXDNTAdF2UKw8fECg6NW uMBiUMPim9dwCkxEbLpOjIN/uNxeeDGJh7ArhdeD4g== X-Received: by 2002:a19:a414:0:b0:502:a55b:c2d7 with SMTP id q20-20020a19a414000000b00502a55bc2d7mr19256311lfc.60.1697082090831; Wed, 11 Oct 2023 20:41:30 -0700 (PDT) MIME-Version: 1.0 References: <20231009201005.1964794-1-sjg@chromium.org> <20231009201005.1964794-2-sjg@chromium.org> <169688631230.3255827.3268332902446136449.robh@kernel.org> <20231010170600.GA1046256-robh@kernel.org> In-Reply-To: <20231010170600.GA1046256-robh@kernel.org> From: Simon Glass Date: Wed, 11 Oct 2023 20:40:58 -0700 Message-ID: Subject: Re: [PATCH v3 2/3] dt-bindings: mtd: binman-partition: Add binman compatibles To: Rob Herring Cc: Miquel Raynal , devicetree@vger.kernel.org, Michael Walle , Richard Weinberger , U-Boot Mailing List , Vignesh Raghavendra , linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, Krzysztof Kozlowski , Conor Dooley , Tom Rini Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 11 Oct 2023 20:41:47 -0700 (PDT) Hi Rob, On Tue, 10 Oct 2023 at 11:06, Rob Herring wrote: > > On Mon, Oct 09, 2023 at 04:02:40PM -0600, Simon Glass wrote: > > Hi Rob, > > > > On Mon, 9 Oct 2023 at 15:18, Rob Herring wrote: > > > > > > > > > On Mon, 09 Oct 2023 14:10:00 -0600, Simon Glass wrote: > > > > Add two compatible for binman entries, as a starting point for the > > > > schema. > > > > > > > > Note that, after discussion on v2, we decided to keep the existing > > > > meaning of label so as not to require changes to existing userspace > > > > software when moving to use binman nodes to specify the firmware > > > > layout. > > > > > > > > Signed-off-by: Simon Glass > > > > --- > > > > > > > > Changes in v3: > > > > - Drop fixed-partitions from the example > > > > - Use compatible instead of label > > > > > > > > Changes in v2: > > > > - Use plain partition@xxx for the node name > > > > > > > > .../mtd/partitions/binman-partition.yaml | 48 +++++++++++++++++++ > > > > 1 file changed, 48 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/mtd/partitions/binman-partition.yaml > > > > > > > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > > > yamllint warnings/errors: > > > > > > dtschema/dtc warnings/errors: > > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mtd/partitions/binman-partition.yaml: properties:compatible:items: {'enum': ['u-boot', 'atf-bl31']} is not of type 'array' > > > from schema $id: http://devicetree.org/meta-schemas/string-array.yaml# > > > > > > doc reference errors (make refcheckdocs): > > > > > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231009201005.1964794-2-sjg@chromium.org > > > > > > The base for the series is generally the latest rc1. A different dependency > > > should be noted in *this* patch. > > > > > > If you already ran 'make dt_binding_check' and didn't see the above > > > error(s), then make sure 'yamllint' is installed and dt-schema is up to > > > date: > > > > > > pip3 install dtschema --upgrade > > > > > > Please check and re-submit after running the above command yourself. Note > > > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > > > your schema. However, it must be unset to test all examples with your schema. > > > > > > > Oh dear, I didn't notice that output but I see it now. Could the check > > return a non-zero exit code if something goes wrong? > > No, because things go wrong too often and then it breaks for everyone. > It's better now, but only because of the above reports and 3 > maintainers. > > Also, it is not fatal. The schemas are checked against the DT > meta-schema, but are used for validation if they pass just draft2019-09 > meta-schema. That allows new DT meta-schema checks to not start > excluding previously used schema. OK I see. Another suggestion would be to remove non-warning output. Perhaps I can do that with make -s though. Regards, Simon