Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Date:   Thu, 12 Oct 2023 13:04:34 +0800
From:   Xu Yilun <yilun.xu@linux.intel.com>
To:     Rob Herring <robh@kernel.org>
Cc:     Moritz Fischer <mdf@kernel.org>, Wu Hao <hao.wu@intel.com>,
        Xu Yilun <yilun.xu@intel.com>, Tom Rix <trix@redhat.com>,
        linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fpga: altera-ps-spi: Use spi_get_device_match_data()
Message-ID: <ZSd+YgDbS5L7jNPJ@yilunxu-OptiPlex-7050>
References: <20231006224624.444857-1-robh@kernel.org>
 <ZSEMLQS+9gFEAX89@yilunxu-OptiPlex-7050>
 <ZSEO5NrJl/kxd7LG@yilunxu-OptiPlex-7050>
 <CAL_JsqKB4gqT06NnWj0Qkd0TuryYA15tjMSom1f+dMJfevy2Zw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAL_JsqKB4gqT06NnWj0Qkd0TuryYA15tjMSom1f+dMJfevy2Zw@mail.gmail.com>
Precedence: bulk

On Mon, Oct 09, 2023 at 07:48:07AM -0500, Rob Herring wrote:
> On Sat, Oct 7, 2023 at 2:56 AM Xu Yilun <yilun.xu@linux.intel.com> wrote:
> >
> > On Sat, Oct 07, 2023 at 03:43:41PM +0800, Xu Yilun wrote:
> > > On Fri, Oct 06, 2023 at 05:46:24PM -0500, Rob Herring wrote:
> > > > Use preferred spi_get_device_match_data() instead of of_match_device() and
> > > > spi_get_device_id() to get the driver match data. With this, adjust the
> > > > includes to explicitly include the correct headers.
> > > >
> > > > Signed-off-by: Rob Herring <robh@kernel.org>
> > >
> > > Acked-by: Xu Yilun <yilun.xu@intel.com>
> > >
> > > Applied.
> > >
> > > >
> > > >  static const struct spi_device_id altera_ps_spi_ids[] = {
> > > > -   { "cyclone-ps-spi", CYCLONE5 },
> > > > -   { "fpga-passive-serial", CYCLONE5 },
> > > > -   { "fpga-arria10-passive-serial", ARRIA10 },
> > > > +   { "cyclone-ps-spi", (uintptr_t)&c5_data },
> > > > +   { "fpga-passive-serial", (uintptr_t)&c5_data },
> > > > +   { "fpga-arria10-passive-serial", (uintptr_t)&a10_data },
> >
> > Sorry, one more. Should cast to kernel_ulong_t?
> 
> Either will work. uintptr_t is somewhat new in the kernel and
> preferred now I think.

LGTM, Applied.

> 
> Rob