Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <7533e359-2024-b69a-2bcf-1906c1a8dbca@amd.com>
Date:   Thu, 12 Oct 2023 10:45:03 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH] hardening: x86: drop reference to removed config
 AMD_IOMMU_V2
Content-Language: en-US
To:     Lukas Bulwahn <lukas.bulwahn@gmail.com>, iommu@lists.linux.dev,
        Joerg Roedel <jroedel@suse.de>,
        Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Cc:     Kees Cook <keescook@chromium.org>,
        "Gustavo A . R . Silva" <gustavoars@kernel.org>,
        linux-hardening@vger.kernel.org, kernel-janitors@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20231012045040.22088-1-lukas.bulwahn@gmail.com>
From:   Vasant Hegde <vasant.hegde@amd.com>
In-Reply-To: <20231012045040.22088-1-lukas.bulwahn@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V3pnUnpaS29XY3ZkdHYxSjNaRExsNkhhMlhnSlJYeGdWYTI5Yzl5RzlGZC9j?=
 =?utf-8?B?UC9BdDM3RXpFZzVrbWE3amtCS0QwcVY3ZGdkSG8zU2xOS1hnNXdCbU1wOE9L?=
 =?utf-8?B?cUVHbGJQUlJWcldVMHhxVStWNGd1TExveVl5d1ZpMkRTVUdSWWw1N0FRc1FC?=
 =?utf-8?B?K0NvZ2NFSm5kb210U0hza0tRTTBSdm16aXZQOWNQaU9td0gzVzJyVHN2STZH?=
 =?utf-8?B?N3k3RU5OYTRTZkpBZTVMMnVXZGxpUTcva3FxY1RpQ0d1REp5VmpraE5QeHBT?=
 =?utf-8?B?Mzd3ZGUzVU9wOVdoemdLd210SzFIcUhvczljLzVKaDZ6dFhaTVdKTk9xVzNZ?=
 =?utf-8?B?bmVhMS8rN1dnNGpONlpjcGg4Um5KTjlNM2xRdDErVTYyNE1BbDNBZW13c0FF?=
 =?utf-8?B?RUtWZy9aaGVTd2ROWFFQUm0yTFpwOWJheFBXcGFNK3VZc3BkbUZOclVrM09T?=
 =?utf-8?B?dHVKcFV5Vjd6WEdZTVVMQWVjVE5XN1l4SXNGR042RDU1TlhsV3RzUjR2Q1hn?=
 =?utf-8?B?dFZseUtUcW1vNGphdzBIYjdaNlNxaDl6WWJlWkhEM2IwNHRTTllrZlNyQno1?=
 =?utf-8?B?M28yT280ZnM2MDJod0RCZnAzajk0L3plUkJmbjFJSXBZOXBzT2VVZXhNYzNK?=
 =?utf-8?B?Y1NKMjVXVktGU3VwendET0NacTJjbEdhL3JtS0NzTFdrN3J5ZVFhd0JqM2th?=
 =?utf-8?B?VzRDR3NzL0gzcjFyTVpWaVdzbGZsTVVkeVlpa09ndHlXQjNvUHhuVXAvZGRo?=
 =?utf-8?B?QU4zczFBaldCaVMrTkc1K1llN2dLRlhnb2tncUE1ZlZ5WXMyNVRueXN4dEJI?=
 =?utf-8?B?Q1NxRHFTcGV5bk01ZlZnUm15Wm16ZmQyS0R2a0Q5ZENoS3plRVZWaUlIK2o4?=
 =?utf-8?B?VTVQUzlKdVVhYlBRdzNPUXpuSHgwZnBKWmdjaFBGTUQ0emdvQUoxQUFkbkpO?=
 =?utf-8?B?NCt3ci8ycytpQVJRSmFLZWlaSXhtMWwvdWtjeVZTM0NuN0s5bmxOV2FqMExX?=
 =?utf-8?B?WnY1MEVRQ3Vyanc0UGcvOTJ0OTllNEpnOC9ZWnJZaXBtdlpYYWVwN3JyWlE5?=
 =?utf-8?B?My9oMXVjYzF0ajNWQ3I2cWFsTWgvOE9jUFFoZ2tCTFlxZEJjWjhtMzI2Tms3?=
 =?utf-8?B?OTA3VFQ0WEhyUnFLd0hmdHkwT3E4UUtYcnQwTFVva1RnVjhzNWVKSlBrY2Fr?=
 =?utf-8?B?VEZldk4wY2ZZaUQrdEpCL2lyL0VLTmNDMjNzZmQ1ZEIwWmcyNjNGd2RXZ1c4?=
 =?utf-8?B?d2U2cFI4YlRCdXJyalFkaWMzZEdnVWVGeGtJUGRPY05QTFVLQnVRWTVyeEVT?=
 =?utf-8?B?Y1BPNEJUckhiWWZhTU5rZmZKSWl4bVIzKzVieTJ2R213QWFxRzhBZ0N6amNv?=
 =?utf-8?B?U3JZUTVGYU8vRnU0d2pmamNLSFpXdUwwZm13cXRxeXFubTRvTlppV1B2YnEx?=
 =?utf-8?B?T0laNnpTMzBuL0c2bHg1dlVIL1ljdG5aRzlRYW5kaDIzWnByODlLMWV2aTVG?=
 =?utf-8?B?alkwZW5uQ1hYUEUrd3Z1QU9lNFU3TExhQzd6Vjhkbk5zR2J5WUpjQ2JHQ1pu?=
 =?utf-8?B?MHd0WitLNXhNenI5QmQ3ODZhV1lzK0drMnNWdG9KSDJ1OEVQdFYrUWhtcHhu?=
 =?utf-8?B?TGJQLzJKaE1mYjVYb3FESUVmcWNNK1BrYXRnUEFIMzBUcXU3N0FSV1pQNnFU?=
 =?utf-8?B?ai9vcEFIdWdNOHlJc1lueG9ualBVQnRFdTZGT1NGdjQwS0RvTGlJZXViYmxG?=
 =?utf-8?B?S0dJbG5jK3FMbXRHKytJQ0l6cjZzdC93TWFoUnNYT1lCUGZYazBKcE9rblkv?=
 =?utf-8?B?QjBDMFBzSkJ0V3htVlRDUzdObHZudi8rVGVuN0dDRjdFcFJkSDU3MU50WU1m?=
 =?utf-8?B?aUNVekVRUWM3WStYLysvVktSNjUxM3JLdTRSaFNZMFZFYTFrV0FtQlllNDgz?=
 =?utf-8?B?dFZOZ3lOeWR6NWE5Wk5STVZSbWNHbEQrQ2hrVW8rQm90T2QyNmlWRURqQm1y?=
 =?utf-8?B?bTNEZVhEcHNsYk0wQlpyMk1MaDNTaWdIeHV6SWQ1Q1BWaSt1ZnViUUJSK1BH?=
 =?utf-8?B?d2JaSzNOZ0RMUkI2MFMzSHdmOFZPRHgwYlF4Z1RKRnMyRDhHbnkzRG02bUcx?=
 =?utf-8?Q?h9ZLHekgVI1qlsn3uGyv369oy?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2dc2b740-2e80-4276-c34c-08dbcae2384b
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6048.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2023 05:15:16.2816
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4uGwdPTmIqSfOVbCQkC+m/Wx6DtVO0eSgT+wjAJlMAxgM/QRTMZqsBmPCxWg6zhkDBXSmd4lV6awNGe4hxLxmA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6024
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 11 Oct 2023 22:15:39 -0700 (PDT)


On 10/12/2023 10:20 AM, Lukas Bulwahn wrote:
> Commit 5a0b11a180a9 ("iommu/amd: Remove iommu_v2 module") removes the
> config AMD_IOMMU_V2.
> 
> Remove the reference to this config in the x86 architecture-specific
> hardening config fragment as well.
> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> Joerg, please pick this patch on top of the commit above. Thanks.
> 
>  arch/x86/configs/hardening.config | 1 -

Thanks for the fix Lukas. But I don't see this file in upstream linux tree. Am I
missing something?

-Vasant


>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/x86/configs/hardening.config b/arch/x86/configs/hardening.config
> index 19bb0c7a7669..7b497f3b7bc3 100644
> --- a/arch/x86/configs/hardening.config
> +++ b/arch/x86/configs/hardening.config
> @@ -9,7 +9,6 @@ CONFIG_INTEL_IOMMU=y
>  CONFIG_INTEL_IOMMU_DEFAULT_ON=y
>  CONFIG_INTEL_IOMMU_SVM=y
>  CONFIG_AMD_IOMMU=y
> -CONFIG_AMD_IOMMU_V2=y
>  
>  # Enable CET Shadow Stack for userspace.
>  CONFIG_X86_USER_SHADOW_STACK=y