Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <7b5f195f-c5c8-6847-9458-3d5563cf0112@ti.com>
Date:   Thu, 12 Oct 2023 10:51:12 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH] net: ti: icssg-prueth: Fix tx_total_bytes count
Content-Language: en-US
To:     Andrew Lunn <andrew@lunn.ch>
CC:     Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
        <srk@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
        <r-gunasekaran@ti.com>, Roger Quadros <rogerq@kernel.org>
References: <20231011063700.1824093-1-danishanwar@ti.com>
 <4d7c2ab9-e980-42a5-9452-79bc0d33e094@lunn.ch>
From:   MD Danish Anwar <danishanwar@ti.com>
In-Reply-To: <4d7c2ab9-e980-42a5-9452-79bc0d33e094@lunn.ch>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Andrew,

On 11/10/23 18:11, Andrew Lunn wrote:
>> @@ -29,7 +30,12 @@ void emac_update_hardware_stats(struct prueth_emac *emac)
>>  			     base + icssg_all_stats[i].offset,
>>  			     val);
>>  
>> +		if (!strncmp(icssg_ethtool_stats[i].name, "tx_good_frames", ETH_GSTRING_LEN))
>> +			tx_pkt_cnt = val;
> 
> Doing a strncmp seems very expensive. Could you make use of
> icssg_stats.offset?
> 

Sure. I can define the offset of these two stats and then use them in if
condition as below.

#define ICSSG_TX_PACKET_OFFSET 0xA0
#define ICSSG_TX_BYTE_OFFSET   0xEC

if (icssg_ethtool_stats[i].offset == ICSSG_TX_PACKET_OFFSET)
	tx_pkt_cnt = val;

if (icssg_ethtool_stats[i].offset == ICSSG_TX_BYTE_OFFSET)
	emac->stats[i] -= tx_pkt_cnt * 8;


Pls let me know if this looks OK.

> 	Andrew

-- 
Thanks and Regards,
Danish