Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
MIME-Version: 1.0
References: <20231003091315.3919528-1-make_ruc2021@163.com>
In-Reply-To: <20231003091315.3919528-1-make_ruc2021@163.com>
From:   Tomasz Figa <tfiga@chromium.org>
Date:   Thu, 12 Oct 2023 15:17:31 +0900
Message-ID: <CAAFQd5A4w5N4GwdJ0x+Rw=EM_J1Nf=6M2XmUi-ZcoyW5L8J-zg@mail.gmail.com>
Subject: Re: [PATCH v2] media: videobuf2: Fix IS_ERR checking in vb2_vmalloc_put_userptr()
To:     Ma Ke <make_ruc2021@163.com>
Cc:     m.szyprowski@samsung.com, mchehab@kernel.org,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Oct 3, 2023 at 6:13=E2=80=AFPM Ma Ke <make_ruc2021@163.com> wrote:
>
> In order to avoid error pointers from frame_vector_pages(), we could
> use IS_ERR() to check the return value to fix this. This checking
> operation could make sure that vector contains pages.
>
> Signed-off-by: Ma Ke <make_ruc2021@163.com>
> ---
>  drivers/media/common/videobuf2/videobuf2-vmalloc.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/common/videobuf2/videobuf2-vmalloc.c b/drivers=
/media/common/videobuf2/videobuf2-vmalloc.c
> index 7c635e292106..5aa66305546d 100644
> --- a/drivers/media/common/videobuf2/videobuf2-vmalloc.c
> +++ b/drivers/media/common/videobuf2/videobuf2-vmalloc.c
> @@ -133,13 +133,15 @@ static void vb2_vmalloc_put_userptr(void *buf_priv)
>
>         if (!buf->vec->is_pfns) {
>                 n_pages =3D frame_vector_count(buf->vec);
> -               pages =3D frame_vector_pages(buf->vec);
>                 if (vaddr)
>                         vm_unmap_ram((void *)vaddr, n_pages);
>                 if (buf->dma_dir =3D=3D DMA_FROM_DEVICE ||
> -                   buf->dma_dir =3D=3D DMA_BIDIRECTIONAL)
> -                       for (i =3D 0; i < n_pages; i++)
> -                               set_page_dirty_lock(pages[i]);
> +                   buf->dma_dir =3D=3D DMA_BIDIRECTIONAL){

Missing space between ) and { .

> +                       pages =3D frame_vector_pages(buf->vec);
> +                       if (!WARN_ON_ONCE(IS_ERR(pages)))

I still think this cannot happen, but the frame vector code is a mess,
so being a bit more defensive here is probably fine, until someone can
clean up that code (probably by removing the PFN-only code path
completely).

> +                               for (i =3D 0; i < n_pages; i++)
> +                                       set_page_dirty_lock(pages[i]);
> +               }
>         } else {
>                 iounmap((__force void __iomem *)buf->vaddr);
>         }
> --
> 2.37.2
>

With that one formatting issue fixed: (Mauro, Hans, maybe it could be
fixed up when applying?)

Acked-by: Tomasz Figa <tfiga@chromium.org>

Best regards,
Tomasz