Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Message-ID: <845e2747-535e-80e0-342b-e5343bd620aa@quicinc.com>
Date:   Wed, 11 Oct 2023 23:36:24 -0700
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] soc: qcom: llcc: Fix LLCC_TRP_ATTR2_CFGn offset
To:     Abel Vesa <abel.vesa@linaro.org>, Andy Gross <agross@kernel.org>,
        "Bjorn Andersson" <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>
CC:     <linux-arm-msm@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Avinash Philip <quic_avinashp@quicinc.com>,
        Umnathi Chalicheemala <quic_uchalich@quicinc.com>
References: <20231012061127.95637-1-abel.vesa@linaro.org>
Content-Language: en-US
From:   Satya Durga Srinivasu Prabhala <quic_satyap@quicinc.com>
In-Reply-To: <20231012061127.95637-1-abel.vesa@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 10/11/2023 11:11 PM, Abel Vesa wrote:
> According to documentation, it has increments of 4, not 8.
>
> Fixes: c72ca343f911 ("soc: qcom: llcc: Add v4.1 HW version support")
> Reported-by: Umnathi Chalicheemala <quic_uchalich@quicinc.com>
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>

Thanks Abel.

Reviewed-by: Satya Durga Srinivasu Prabhala <quic_satyap@quicinc.com>

> ---
>   drivers/soc/qcom/llcc-qcom.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c
> index 674abd0d6700..fb4085b7cb19 100644
> --- a/drivers/soc/qcom/llcc-qcom.c
> +++ b/drivers/soc/qcom/llcc-qcom.c
> @@ -47,7 +47,7 @@
>   #define LLCC_TRP_STATUSn(n)           (4 + n * SZ_4K)
>   #define LLCC_TRP_ATTR0_CFGn(n)        (0x21000 + SZ_8 * n)
>   #define LLCC_TRP_ATTR1_CFGn(n)        (0x21004 + SZ_8 * n)
> -#define LLCC_TRP_ATTR2_CFGn(n)        (0x21100 + SZ_8 * n)
> +#define LLCC_TRP_ATTR2_CFGn(n)        (0x21100 + SZ_4 * n)
>   
>   #define LLCC_TRP_SCID_DIS_CAP_ALLOC   0x21f00
>   #define LLCC_TRP_PCB_ACT              0x21f04