Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Message-ID: <c90f5226-8a55-9a04-765d-104e54484d6b@amd.com>
Date:   Thu, 12 Oct 2023 12:27:57 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH] hardening: x86: drop reference to removed config
 AMD_IOMMU_V2
Content-Language: en-US
To:     Dan Carpenter <dan.carpenter@linaro.org>
Cc:     Lukas Bulwahn <lukas.bulwahn@gmail.com>, iommu@lists.linux.dev,
        Joerg Roedel <jroedel@suse.de>,
        Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
        Kees Cook <keescook@chromium.org>,
        "Gustavo A . R . Silva" <gustavoars@kernel.org>,
        linux-hardening@vger.kernel.org, kernel-janitors@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20231012045040.22088-1-lukas.bulwahn@gmail.com>
 <7533e359-2024-b69a-2bcf-1906c1a8dbca@amd.com>
 <b9f08b19-80e9-4908-89f1-8712bb3b59e8@kadam.mountain>
From:   Vasant Hegde <vasant.hegde@amd.com>
In-Reply-To: <b9f08b19-80e9-4908-89f1-8712bb3b59e8@kadam.mountain>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z1ErTUh6YmwzZ0lPSUl6cmpvVmU2Uk9DR1NodXd1bllFaGdISStNR2Riczc3?=
 =?utf-8?B?dkt6d3k1OXlLdDF0akVaTTM3eFpZMnVieFdZUk80K0Y5ZmFrVElxMkd0M2Jo?=
 =?utf-8?B?RkQvOHd6b3UwUUJHZ0xwVzRicUllOGo2M2RGSUZVbFRtem9BQ1FmMGo1N1VR?=
 =?utf-8?B?Y0xjWWhVWThtd0lpclo3RWJmbnlnazNLejFDbGpQR2tWaVZDMjJOY0xxQ01M?=
 =?utf-8?B?dFpzbFFkSklDQlU0YS9nMFY5aUxKWk40VkJsSW9aMWtKMEp3S1prZjZGVkhF?=
 =?utf-8?B?VzhwR21PeVpVUXBZdXkvZFF6RkkyU0RwM2p6ZWJCYWNDMXZZMTJzejlRbnVK?=
 =?utf-8?B?aFNaMTRadlZoL3RmQ2F3VVdWZXJPZGY3RVZMcUk1VWlsZXU2STBpOVdDTUZT?=
 =?utf-8?B?aHVCRC95Z01lWUVrbEkxUkNtZTJqRXpqUXFaSXhjMmFjcVFQQkNpWUlWTHdJ?=
 =?utf-8?B?N0dIOW9NT01CUTk0RDdwSlVwZkZmLy9KbU9DTE1EOWxQS3lYd25UQUQ5SFh1?=
 =?utf-8?B?NmhEVXBIb1lIa1JvTGFkblNPYWhydzJqblFUeWI3QS9pcFJVYmpIMm53dnk1?=
 =?utf-8?B?RlFzbXlxM2UzTlprRlVQbkpRRVk2NG9Nay9XbG9COU5OdEEzVWJaMmk0Z3I1?=
 =?utf-8?B?TFJuOEN2RU41TTFXVmcxaG1oWm4waUtLbWRMd1J0YUU3SDBHZEkvZzc0dnor?=
 =?utf-8?B?a0tJcm9YdENWSHFRUWhXdTQ1MXFMT1k1UExpdUJrLzA4ODVBRWhmMnVvNFlW?=
 =?utf-8?B?UG5mNXpPMzM1b1lrL0hJbDZnbTJWNnJET1lxbUpwQWhlZ0pzMkpranlyTzZP?=
 =?utf-8?B?NWFIeUw3MTRCYkxubENITG8wMStKZ0VHdjJwenNFcVQ1S0cwU0xiVWNaUHA1?=
 =?utf-8?B?b01RSkxiU2t5QVpuNWhIWlEvekdZSllralRlTzdLUHY4TmxKdkZReFpuRTZC?=
 =?utf-8?B?dkJxK05yUGJFNVJEUEV1MEtHTDMyekF2YVM4Y0RqejZ1dXV0Njk3OXQ0eTlL?=
 =?utf-8?B?NUpxTFhTUjI0QmZhTmJaL2R1TUEySEhldDJUVTc0VnAzMStDajN4WHpvdC9K?=
 =?utf-8?B?d0VoMFdFRVVqQVFIZDdTM1oxZzBkNlNyTVhkYUVWWHBuRGtobnNkNDlaRjJK?=
 =?utf-8?B?eEFVbm0ySkpHSENDVTJidS9VY1pWZGlicHVGaE8rUjRtSUp6aU1YZGduam96?=
 =?utf-8?B?S2J2clN1WjA4dm81a0FvRUVueE1SbFU4YUFwL0lsR09QOVpvc0NUNUR0aVpM?=
 =?utf-8?B?Y3NrbkFKdW5CQ0xwV1RBK1Jad09sVitIR0syNVN2ZThHbTcrY3VSVWNjbVph?=
 =?utf-8?B?RmsrVUxJNndta0s4R2prS1RCRFNBdkdjZWtSRUdZT1IvUEVJNko2M2V5eFV5?=
 =?utf-8?B?NEhMWFhXYlpsTm5keDROcEw5WEl5OEJRLzJ2Nm5wbW55TkJwZyszZ2ZEblUw?=
 =?utf-8?B?OGo2bUNlcnBFTy9zMm96TmJyM21oazdyN3M2U0R6M0dpRXUzcnV2c2o5MmI4?=
 =?utf-8?B?ZnBGM2tCTGRXSEJsY0lFcEY4NW1GdWh5YlI4MHZuYUdMVUNhRERUQVlaazBa?=
 =?utf-8?B?YnNGR29wK1hKRER5QUdYOXNreE1tcWEwNWpxc2cyWGxrUURQMmYwUjVXOGF1?=
 =?utf-8?B?S2JpOXhBMGtDQnc1L05YZlQ0U2pKUjJqUjBvWjNJSVBYaW92NEFXRGlTbitk?=
 =?utf-8?B?QVdnZFdiZC8zSmt3b0hwdUxiU1JRcWx0eDVGTXY0Z0s5S3dZaG1aZkx5KzVE?=
 =?utf-8?B?ck9ZMmtaTjRoQjlSSUNCdFlOQnFyeURzUFBuemt6dVBRTm8veVozSmhjS3V4?=
 =?utf-8?B?OEdsemtBOVBWV1UvWXl1MHhSaEFGNVU0UEhld3lvdnk2cldPNnA5UE40Wllz?=
 =?utf-8?B?TkJOR2xJWU9xNkZ3THpLWnNYcGovV05QalNvYWR0SFIreGpwVDlEZ0l5N3dT?=
 =?utf-8?B?Nm9rZGUwSDFjdkJLcVRjRFZ5WlBlcUN2aDRGeG9zQ2YyaVBpLzYwRUFBZUht?=
 =?utf-8?B?UW00Z0F6U1ZJeXByZjY0RHc0U1FoQW1GU3ZUaUh3VjFHcW1HSUQxMkczVFVJ?=
 =?utf-8?B?dnk5bWZXK1FCMWRkbGVXTFllazBNRlJUMEttb0F5S05SeU1OZUViQTdRMDdZ?=
 =?utf-8?Q?+Ai9zZo1fSQ3ADrPy2o9TI7q6?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 904b0d19-7f55-4f50-9768-08dbcaf09829
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6048.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2023 06:58:10.0543
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AtQGjTzoNLKOR9TwWUMlyYB5CdBNRgSoN7bFiRQGk6eu17p8TDJfGYj8Oyio8ehc9wGbpbeGTEBGP+HD/KtxXg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5273
X-Spam-Status: No, score=-4.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Wed, 11 Oct 2023 23:58:29 -0700 (PDT)


On 10/12/2023 12:05 PM, Dan Carpenter wrote:
> On Thu, Oct 12, 2023 at 10:45:03AM +0530, Vasant Hegde wrote:
>>
>>
>> On 10/12/2023 10:20 AM, Lukas Bulwahn wrote:
>>> Commit 5a0b11a180a9 ("iommu/amd: Remove iommu_v2 module") removes the
>>> config AMD_IOMMU_V2.
>>>
>>> Remove the reference to this config in the x86 architecture-specific
>>> hardening config fragment as well.
>>>
>>> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
>>> ---
>>> Joerg, please pick this patch on top of the commit above. Thanks.
>>>
>>>  arch/x86/configs/hardening.config | 1 -
>>
>> Thanks for the fix Lukas. But I don't see this file in upstream linux tree. Am I
>> missing something?
>>
> 
> It was added on Aug 24 in linux-next.

Thanks Dan. I can see the patch in linux-next.

Reviewed-by: Vasant Hegde <vasant.hegde@amd.com>

-Vasant