Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Date:   Thu, 12 Oct 2023 09:06:33 +0200
From:   Willy Tarreau <w@1wt.eu>
To:     Thomas =?iso-8859-1?Q?Wei=DFschuh?= <linux@weissschuh.net>
Cc:     Zhangjin Wu <falcon@tinylab.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests/nolibc: add tests for multi-object linkage
Message-ID: <ZSea+etQwlxbi+Ok@1wt.eu>
References: <20231012-nolibc-linkage-test-v1-1-315e682768b4@weissschuh.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20231012-nolibc-linkage-test-v1-1-315e682768b4@weissschuh.net>
Precedence: bulk

Hi Thomas,

On Thu, Oct 12, 2023 at 01:13:37AM +0200, Thomas Wei?schuh wrote:
> While uncommon, nolibc executables can be linked together from multiple
> compilation units.
> Add some tests to make sure everything works in that case.
(...)

Glad you did these two. Your approach is good and it remains easy to
use and should catch next breakage in this area.

> Signed-off-by: Thomas Wei?schuh <linux@weissschuh.net>
> ---
> Note:
> 
> This depends on path "tools/nolibc: mark start_c as weak".
> https://lore.kernel.org/lkml/20231012-nolibc-start_c-multiple-v1-1-fbfc73e0283f@weissschuh.net/

For these two patches: Acked-by: Willy Tarreau <w@1wt.eu>

Thanks
Willy