Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Date:   Thu, 12 Oct 2023 09:23:29 +0200
From:   Thomas =?utf-8?Q?Wei=C3=9Fschuh?= <linux@weissschuh.net>
To:     Willy Tarreau <w@1wt.eu>, "Paul E. McKenney" <paulmck@kernel.org>
Cc:     Zhangjin Wu <falcon@tinylab.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests/nolibc: add tests for multi-object linkage
Message-ID: <bfc17e76-fcbc-4ce6-97a8-c1ed72ed2a67@t-8ch.de>
References: <20231012-nolibc-linkage-test-v1-1-315e682768b4@weissschuh.net>
 <ZSea+etQwlxbi+Ok@1wt.eu>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ZSea+etQwlxbi+Ok@1wt.eu>
Precedence: bulk

Hi Willy, Paul,

On 2023-10-12 09:06:33+0200, Willy Tarreau wrote:
> On Thu, Oct 12, 2023 at 01:13:37AM +0200, Thomas Weißschuh wrote:
> > While uncommon, nolibc executables can be linked together from multiple
> > compilation units.
> > Add some tests to make sure everything works in that case.
> (...)

[..]

> > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> > ---
> > Note:
> > 
> > This depends on path "tools/nolibc: mark start_c as weak".
> > https://lore.kernel.org/lkml/20231012-nolibc-start_c-multiple-v1-1-fbfc73e0283f@weissschuh.net/
> 
> For these two patches: Acked-by: Willy Tarreau <w@1wt.eu>

Thanks, applied locally.

I guess the linked patch "tools/nolibc: mark start_c as weak" should
also go into nolibc/fixes.

@Paul, would it introduce too much churn for you if I submit another
nolibc pull with an updated nolibc/fixes?
(And the rebased nolibc/next with this commit while we are at it)

Thomas