Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Date:   Thu, 12 Oct 2023 09:45:39 +0200
From:   Borislav Petkov <bp@alien8.de>
To:     "Nikunj A. Dadhania" <nikunj@amd.com>
Cc:     linux-kernel@vger.kernel.org, x86@kernel.org,
        thomas.lendacky@amd.com, dionnaglaze@google.com, pgonda@google.com,
        seanjc@google.com, pbonzini@redhat.com
Subject: Re: [PATCH v4 01/14] virt: sev-guest: Use AES GCM crypto library
Message-ID: <20231012074539.GCZSekIxe9KM1lG9eC@fat_crate.local>
References: <20230814055222.1056404-1-nikunj@amd.com>
 <20230814055222.1056404-2-nikunj@amd.com>
 <20231011185607.GVZSbvx8rJ8DXPqYfg@fat_crate.local>
 <3b484a1a-e6dc-3b73-ba1d-72fd6ba38ebe@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <3b484a1a-e6dc-3b73-ba1d-72fd6ba38ebe@amd.com>
Precedence: bulk

On Thu, Oct 12, 2023 at 10:10:43AM +0530, Nikunj A. Dadhania wrote:
> Ard had added the library specifically for this use case, this was the first 
> discussion thread: https://lore.kernel.org/all/c6fb9b25-a4b6-2e4a-2dd1-63adda055a49@amd.com/
> 
> Should I add the above link instead ?

Please read up on what a Link: tag is used for.

> static inline unsigned int get_ctx_authsize(struct snp_guest_dev *snp_dev)
> {
> 	return snp_dev->ctx->authsize;
> }

Or simply not use a one-liner function at all.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette