Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp142504rdg; Thu, 12 Oct 2023 00:59:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFQQv29FQyJTUrHTU8iFeFN7ABOQsvW1hiCUUPxMVmWrlW4gSZ6fzzV5hmEfEarrOUlh8eR X-Received: by 2002:a05:620a:244b:b0:774:2113:743a with SMTP id h11-20020a05620a244b00b007742113743amr29089289qkn.19.1697097576044; Thu, 12 Oct 2023 00:59:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697097576; cv=none; d=google.com; s=arc-20160816; b=WHkvAF1gozFCBVQGd5Ktjg3eychcbTeOPWl9md6hTf0B0rSY0nTSn8wkf2obj/q0mO kMPgKpyXi4DfGXx1IeWxzpbg+ZLkQAyH5U98h/yn6UeDwqshstgrzGiZwbyDv7QEUABb zAaD4xek9jY/ZExX4uNF03mEnrOAHXeYR4mdEKH8LouXU6iLqZNh3VDBSQLyKdYFErEi I4qQtviNuOcTcagU1spbMbXWW4oMPtTX23F6ZXIRa1sZ+QynQ8oxZHhdv9GfAPgEvqqB 5SUzb6Oy6RBv1+tsuLAhYARhMAcC1lpSSLhlDF2BcxrTEbMO5KG+rVaPSA3T26Z2oHKZ xKkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=d/bXmGjxxP02E69P1WfoCNO/tGsJhORnCctdVGx6W6A=; fh=pXKqORNJ+dg5Lz7xCcqJMzke/CtmHwLH72jSpZY9BDY=; b=ckM2oBpKZNo00ak69SMDBsKhfCaJNX+o0xoN/MNCdqbEzJNaAklwP/G36DKdlhwQSp 6JbKJS/l4x+2UNtv3YhBFChslkd2IKneJ9jgKpMqGaqgxRKr9I8+77LPsjNhqkJEr00X s1IJ0QcDOcfQb5fjuGFX+U559zhVYxMUi3TenmTYemHuFhmjFwsUkugOrvAtTA8R5pE7 TVACICx6YepBcGlXHi4uAZFWW+0nzNsEm+7iNoumtHLnSfOTZb9l22sUbx4riSj17yIs ptgD1CXvdT4hdNaip1UgQPSd1wKJeEbq3ch7x58yYUnLhYhv1L9xsLxwswtK+TW4+VD2 iYBQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=V1zYE4tI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id bx14-20020a056a02050e00b005859c3a51c0si1819860pgb.421.2023.10.12.00.59.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Oct 2023 00:59:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=V1zYE4tI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 7C789803549C; Thu, 12 Oct 2023 00:59:33 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377602AbjJLH7S (ORCPT + 99 others); Thu, 12 Oct 2023 03:59:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235233AbjJLH7Q (ORCPT ); Thu, 12 Oct 2023 03:59:16 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B3BAA9; Thu, 12 Oct 2023 00:59:15 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6B96C433C7; Thu, 12 Oct 2023 07:59:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697097555; bh=lhJ0mABYqusmJwDzlvcyUF3yYu3BzZ0v1uLfQprQBNs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=V1zYE4tIiqS5kPTew9ChTnNex2WSFFzks2Gb9aYTSNuV0stTrkyL5bUqMyUTFlxBp yqpSdE01jvChrNqEA19iQhfLhx9Y0XC+c9mODlbT0fPKuXV6ySqrIk3duNx2B1KL44 hXATxkv/7tOrvTtbgAN6mBv2kjHgFnJHXRY3K8YhCz8iZSe3LTI3CDAuVG4Wi8KylE mnpc5e58nJqjxlB5ELcOi3X2Z9e1FWuBgUxcYwxONXlgESSs+rgCv1eNgkTg4AyB1/ cG44q3DIYFb+/yueXP6QyiHM5sklWLkVJphbdnmbwpmcnjzGu9Jlxvb1SFCgZEcONh 5zChIRomWiRGg== Date: Thu, 12 Oct 2023 08:59:26 +0100 From: Jonathan Cameron To: David Lechner Cc: linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, Michael Hennerich , Nuno =?UTF-8?B?U8Oh?= , Axel Haslam , Philip Molloy , linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 2/4] staging: iio: resolver: ad2s1210: clear faults after soft reset Message-ID: <20231012085926.2104251a@jic23-huawei> In-Reply-To: <20231010-ad2s1210-mainline-v5-2-35a0f6ffa04a@baylibre.com> References: <20231010-ad2s1210-mainline-v5-0-35a0f6ffa04a@baylibre.com> <20231010-ad2s1210-mainline-v5-2-35a0f6ffa04a@baylibre.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 12 Oct 2023 00:59:33 -0700 (PDT) On Tue, 10 Oct 2023 16:12:34 -0500 David Lechner wrote: > When a software reset is performed on the AD2S1210 to make the selected > excitation frequency take effect, it always triggers faults on the > input signals because the output signal is interrupted momentarily. > So we need to clear the faults after the software reset to avoid > triggering fault events the next time a sample is read. > > The datasheet specifies a time t[track] in Table 27 that specifies the > settle time in milliseconds after a reset depending on the selected > resolution. This is used in the driver to add an appropriate delay. > > Signed-off-by: David Lechner Applied