Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
From:   "Gan, Yi Fang" <yi.fang.gan@intel.com>
To:     Andrew Lunn <andrew@lunn.ch>
CC:     Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        "Jakub Kicinski" <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-stm32@st-md-mailman.stormreply.com" 
        <linux-stm32@st-md-mailman.stormreply.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Looi, Hong Aun" <hong.aun.looi@intel.com>,
        "Sit, Michael Wei Hong" <michael.wei.hong.sit@intel.com>
Subject: RE: [PATCH net-next 1/1] net: stmmac: Remove redundant checking for
 rx_coalesce_usecs
Thread-Topic: [PATCH net-next 1/1] net: stmmac: Remove redundant checking for
 rx_coalesce_usecs
Thread-Index: AQHZjT6lWJeK0HW3gkKJmtB494k4Xq9nzv+AgN7dkyA=
Date:   Thu, 12 Oct 2023 08:11:03 +0000
Message-ID: <DM6PR11MB3306E3CF8E53A53FB14D5378B9D3A@DM6PR11MB3306.namprd11.prod.outlook.com>
References: <20230523061952.204537-1-yi.fang.gan@intel.com>
 <436aced8-f7c4-4ecb-96f9-25ab707e95af@lunn.ch>
In-Reply-To: <436aced8-f7c4-4ecb-96f9-25ab707e95af@lunn.ch>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wgp5TsRzXx/+mJkAVyoHcNN8xe9y3TDZehfkS35SdXfN9ZSQNJhPwCkZVDvk?=
 =?us-ascii?Q?wZagASuRFMMJdsIw/EYBAILusEhpnNAi4ljk9GyBFAoYnGAiUhCaojMVJU6J?=
 =?us-ascii?Q?HqJCO6ijdnbhSQYbu1TzHsjE9y3geuQUBJLxfybbzYZTdWrVwVWuQEgcnUft?=
 =?us-ascii?Q?T7quXAG3ouIC47213rSv9rAp1igUS91Y0LaWQ8ITHjpNuhE6XJd53HPEm80u?=
 =?us-ascii?Q?xuyZ8TEp0Jr2LkIHhCckn2v/pQ9p32/twQgKl3eYHd8jCrizvN4VUvs86amu?=
 =?us-ascii?Q?qHXbjKYkFvVxoP6hQWSQz+/J3pJ78J9KQeQXZB2p7zLncu/B0BJ1hVmVNf+H?=
 =?us-ascii?Q?e3kxjGlWBYd25EEzGuQ/dM44H0A7bWNJcwnahFW8nDggdjLkJ2jlFLCGvaRY?=
 =?us-ascii?Q?oQKrsDbTzyhAPzGBHXq4+M5b4tLYGagmyRrcs0oScX5kcwRo6IeWupHvZa+R?=
 =?us-ascii?Q?DPYKDhNVaMoouNkFC5geO9SaAm41wGZX56hPJ/NqjWNsunuXz3V0t/Q5baCu?=
 =?us-ascii?Q?L3ICK/3wA0FS3dLOt2G/hIo6CRXcoOI4a739Rv8u9UBhLvOClA+uigJfDh1A?=
 =?us-ascii?Q?eDvhe6V/kzigO39nbVIloX43KupKNElsZ0lAmRi0v1XB3YGp6f1GeBT64D/q?=
 =?us-ascii?Q?hs1NyX9pjOk3e07JNtfX/vaT0N4AeR3PE064ivi+kL4SG1AnUJBDqGi6b6zA?=
 =?us-ascii?Q?OMlEvO7VUJjnc7Jn0XCys/5HrHKOWbxRjmifPBN0noMC+4UIsAUkZ3c2hs2N?=
 =?us-ascii?Q?T6rVjIIuaUSnJo49MAtgZxszrZr204lmnHivDR5ZVxBjUj64y4mLwHMZhGCZ?=
 =?us-ascii?Q?fpvW86IpZbZC8Ll6bZ/cwsly8mf3m39qrn2PcqFiUrkRJz81HgOSPyDmFvW7?=
 =?us-ascii?Q?TCtCvYPddZcyt8NnFAaC6qIN/zTZktdOKGOxLuJFl3bkESUL9LiEWGmcoESk?=
 =?us-ascii?Q?xXdyXXo6W99DGVpzakjxIhAS7UUIxCSBN8zMqhCk5gGN/Z86tyMSbmYAMOIj?=
 =?us-ascii?Q?kGXCIEOpwRozIoMfWE81dvqCgTMhc7O/uQb0vUD0hB3wT2OL5DBfpbBWst3c?=
 =?us-ascii?Q?fEUIUK1Eyr4J3GFccfO1noWvUzib9N40BlI2l2PjfwIXFC+VL2CMZ5GJZz3x?=
 =?us-ascii?Q?5jLQIhaPP7CN827LxUnw8kHLk/jKI77VnGFmYE4+d6UZo0km8ByyC5nfoJJK?=
 =?us-ascii?Q?ZN1izw825w5oM9JTgAJy4t1Zq802PwqzTobxkcuv3vvf6NKWmkHr/dlRPEhq?=
 =?us-ascii?Q?us6YN6GmESYjPNyEFKOb9+v67YZANdboZ00PbeWzjFP7vlBAlVIn9rtsdg1/?=
 =?us-ascii?Q?39Kyo4NGNTTbfMmKwkVhWvxK4Lz6PgxLRD7x5VU2NkNfLvJAyO7rq27w+XGB?=
 =?us-ascii?Q?bQbpcaWshemFVlz6ANpzE8YijHiquBFVlKXjKhjBmdsCLsOddbFPR61Nax4v?=
 =?us-ascii?Q?mze4Yl1TeeBkoTLtyVMIOEhe6zX+8bTY4yTN6nxLkuE3t6x0QatkRDv9d00N?=
 =?us-ascii?Q?IHKgwvCkneJQzzv230x+qiaz5GWNBuWVCTj6hpRMQFkvFm87LRqbQDZ7g6al?=
 =?us-ascii?Q?tW13lm0vXaSrBKOdRL8Ll1I81UKwrZHhX883BFi1?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3306.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: afb696ac-3c23-418f-1d35-08dbcafac6f5
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2023 08:11:03.1311
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 1/Mj1nK8MTv5po3pl9mNbMC5xja/sHflhviGBRo6znoo0pxgJgCZoeiYnJm15wR3Qc0Sa7jfLh2Eez1p38CI2w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7925
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 12 Oct 2023 01:11:35 -0700 (PDT)

Hi Andrew,

Thank you for your feedback. I will submit V2 to update the commit message.

The value of rx-usecs will not be affected when the tx-usecs is set. When t=
he command "ethtool -C eth24 tx-usecs 42" is applied, the value of rx-usecs=
 is remaining the same as previously.

Best Regards,
Gan Yi Fang

> -----Original Message-----
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: Tuesday, May 23, 2023 8:48 PM
> To: Gan, Yi Fang <yi.fang.gan@intel.com>
> Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>; Alexandre Torgue
> <alexandre.torgue@st.com>; Jose Abreu <joabreu@synopsys.com>; David S .
> Miller <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub
> Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; Maxime
> Coquelin <mcoquelin.stm32@gmail.com>; netdev@vger.kernel.org; linux-
> stm32@st-md-mailman.stormreply.com; linux-arm-kernel@lists.infradead.org;
> linux-kernel@vger.kernel.org; Looi, Hong Aun <hong.aun.looi@intel.com>; S=
it,
> Michael Wei Hong <michael.wei.hong.sit@intel.com>
> Subject: Re: [PATCH net-next 1/1] net: stmmac: Remove redundant checking =
for
> rx_coalesce_usecs
>=20
> On Tue, May 23, 2023 at 02:19:52AM -0400, Gan Yi Fang wrote:
> > The datatype of rx_coalesce_usecs is u32, always larger or equal to zer=
o.
> > Previous checking does not include value 0, this patch removes the
> > checking to handle the value 0.
> >
> > Signed-off-by: Gan Yi Fang <yi.fang.gan@intel.com>
> > ---
> >  drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
> > b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
> > index 35c8dd92d369..6ed0e683b5e0 100644
> > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
> > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
> > @@ -917,7 +917,7 @@ static int __stmmac_set_coalesce(struct net_device
> *dev,
> >  	else if (queue >=3D max_cnt)
> >  		return -EINVAL;
> >
> > -	if (priv->use_riwt && (ec->rx_coalesce_usecs > 0)) {
> > +	if (priv->use_riwt) {
> >  		rx_riwt =3D stmmac_usec2riwt(ec->rx_coalesce_usecs, priv);
> >
> >  		if ((rx_riwt > MAX_DMA_RIWT) || (rx_riwt <
> MIN_DMA_RIWT))
>=20
> This appears to be a user visible ABI change. For the current code, a val=
ue of
> zero here is ignored, and 0 is returned. With this change, 0 will result =
in rx_riwt
> being calculated as 0, which is less than MIN_DMA_RIWT, so you get -EINVA=
L
> returned.
>=20
> I don't know this uAPI too well. What values are passed to this function =
for:
>=20
> ethtool -C eth24 tx-usecs 42
>=20
> where you only want to change transmit coalesce? Is rx_usecs 0?
>=20
> At minimum you need to explain in the commit message: "This change in
> behaviour making the value of 0 cause an error is not a problem because..=
.."
>=20
>     Andrew
>=20
> ---
> pw-bot: cr