Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <81b4e3b6-a9eb-ff29-efe7-94ec2fb47c18@amd.com>
Date:   Thu, 12 Oct 2023 13:57:38 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Reply-To: nikunj@amd.com
Subject: Re: [PATCH v4 01/14] virt: sev-guest: Use AES GCM crypto library
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>
Cc:     linux-kernel@vger.kernel.org, x86@kernel.org,
        thomas.lendacky@amd.com, dionnaglaze@google.com, pgonda@google.com,
        seanjc@google.com, pbonzini@redhat.com
References: <20230814055222.1056404-1-nikunj@amd.com>
 <20230814055222.1056404-2-nikunj@amd.com>
 <20231011185607.GVZSbvx8rJ8DXPqYfg@fat_crate.local>
 <3b484a1a-e6dc-3b73-ba1d-72fd6ba38ebe@amd.com>
 <20231012074539.GCZSekIxe9KM1lG9eC@fat_crate.local>
From:   "Nikunj A. Dadhania" <nikunj@amd.com>
In-Reply-To: <20231012074539.GCZSekIxe9KM1lG9eC@fat_crate.local>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aHpUdTlOeEhnOXpwa2RWSkd0MkpOUFlST1VDL0hqZ2ZsWmZ4QlhQa0ZRMVpy?=
 =?utf-8?B?ZWV6QzB6dHZUTnFXMC9jcmlhWkVxQnRHOFgwVU0wNFpnL0hVK2NkaCtVbS9D?=
 =?utf-8?B?YkdNQWhkUmgzNlNrQVo4cHZxS1hUWHlWVmdxanNqUk5RT0VZd2VsSVNoUlh5?=
 =?utf-8?B?UTBiNkxOTWw4Y3FLbFc1OVZmdy9RMEc4L0xScmZTY1pPOXB3dkZlM2UvUXJK?=
 =?utf-8?B?d28vQm13ZTNoaVBFaDFFVUk1VzBJQlUvNVlxYWFuY1N4MnZ1TVBEOG5GQ3Zr?=
 =?utf-8?B?RW1DbjRUOHBHdC9GNmY1SFQ0UEpKbjBRc2QvWWRYTnE5Y3JsUzhneUs0c1VH?=
 =?utf-8?B?eS9IWG1PSlUvZkVhWnppYXZlaWhzSXkwNWJTMERtNVJHbmRXdTJCOFpyb2Q1?=
 =?utf-8?B?SDRybWs3MDU1Z21iQ1ZMbUNPQ0dEcHQ3cTl1S2pVKy9yamxaVVBMUXNtZkhP?=
 =?utf-8?B?eU5KNGEwd05UenJzcGlobkxycm5WWnhvUTlvWHhCZUF2emQvcVYwL2drM2xr?=
 =?utf-8?B?VjRmQUJkWnZOektrYldvNWVkZ29lZ2VaWDkyY21XVmV3dGVyZUN6TU5mcDdk?=
 =?utf-8?B?K3I1SVkrYW04SWFKcmNTT1VIUmxPOEhrY3dCLytkT0hrVEIzaWZ0VUNBbTJl?=
 =?utf-8?B?S0MyVU9uamZqbkEwNUlrbzJ2by95WFJuVTFiVVp2aFFQa3A1QzV0cGNwOUY5?=
 =?utf-8?B?cEgyUXUwd1JKOFhEcXBPUUZER0lQSnpvbHBUOWtpb0E2bkFoMEdYUWI1L3BV?=
 =?utf-8?B?V1ErY1EyRlhFRm82cjR5a2EyZUFtSEhCYjFqaUlGNi9wT2hkWTB2Y08vb0pi?=
 =?utf-8?B?c2x1eFQyTVBtd0pNTjhWRkFFRFYwanoxMW1KckhrNWp4RTU5c05LclhHV1lQ?=
 =?utf-8?B?aS9tRDdDS0F1MnRYL2VDbVlpUlpEOGQxbm04OXNkQTNkelpaYTVPT1pDZW1O?=
 =?utf-8?B?NzRUMm01aThwaFdqOExpb0dtdUZVSUJNYXVUc0ZIdk5SV0ZaNStEUUVoNGpT?=
 =?utf-8?B?UjJ6ZkJIRDdQUHFBYVZaY2FBOGgyamc5Z2hsNkgrZXM3UEppWWs0TkpqKytR?=
 =?utf-8?B?SjdXclRGaEtrbWExTGVyVGVZdDltUGM3VHJiUTJUOHdxZmNFaDJpSDhETjg3?=
 =?utf-8?B?a3RTVFNKOFFsRGhCUEllb1pwZDkxSG9VTUdCQlNHU2hOVVZwNUdjbVhTem9l?=
 =?utf-8?B?a2djbkYrd3J2dDJiakx4R3h2akRyajQzUWtYWFQ3ODhoaUVOenhzM1d0TEpy?=
 =?utf-8?B?cXl2VWNzK2tVVXh0WVAyZDk4NFVCWWt1TWZiRmZSbjZvdXZpNnFzQmRyL082?=
 =?utf-8?B?c3lDNms5UzZ0Q0pFd2EvZGpMK1dleWYrYW9FdG8yUGpBVTlJRkRUeFFBZ3Ba?=
 =?utf-8?B?c01kM0VCQWNIaVBGSUFBUjZRVDJVNExIZEw5SVlZVUVvcGtTdjUyNHJHWmVX?=
 =?utf-8?B?eVFCOEI1ZjRyWFY4NjVqMERkUldlUlg1aVV1d1hLS3pRN043VU1tU1hrRG9o?=
 =?utf-8?B?MEZSVTdlc1FkL2F6L2pMMUxHbVlqK1Z3NXVhenZQTmQ2RysvNDlGYTZkYWFu?=
 =?utf-8?B?R1Ryd2pMMVRPREVpTWdpUVZpcXZCTlRZT2tzNm1JbC9MUitPSkxBcU5IWXVO?=
 =?utf-8?B?ZGVtaHBld3RjN3dLdXJMWVAyMThqSG9hSDZPc2hEUG5KTDVicHpLTlFmQzdm?=
 =?utf-8?B?ejBwR2RCcy9STlVWekI4M1YzaEN5OUppV21OWW5vL1lvWDZvNUtucFdFV0xL?=
 =?utf-8?B?VlBDWHh4dEVSaWFZVW5aOEM2QWpDWXUvMFBINXZReWRHNllpSlVtOFJYZVUz?=
 =?utf-8?B?TGkyalgwdlI3REwyZWN2L0dWbC93TnMrakVKMmdvTGtudzJPeTRjZ055YnRZ?=
 =?utf-8?B?ZHBoR2tnWDcraVd6NVZZV2lHWG9za3cvRFh2cWROOUZpTEJnaTJ6eUZmb0dJ?=
 =?utf-8?B?QnMvTGY1Rks1OXpXaC9PN3QrQTJUcjZ6UDk5UFNpUEJyNEVENzhNMTlzUThJ?=
 =?utf-8?B?SGJNQ0E0SUZwdkh5blYzUTE4K2RBckpBYjlsaDI4RjUyU216OWFEVHMvRy8r?=
 =?utf-8?B?Z3ZLTkcxdnRpd2xvU21nU1ZYN1NxZlBHZytJTkppVUYvSnhDMXI5U2Y0SGhE?=
 =?utf-8?Q?KNw8/62VPOrHzcN5/dwg5Empi?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6a7fbdbf-c1f1-4d72-c88b-08dbcafd1ed4
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6309.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2023 08:27:49.9743
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ypnhg1pFpBFMj5nXvmPq7aV2P2rTd9BAZ51z97ycO7zQ2rI/J8mhmKIBt1LD1dgu8xZ/V81scKPiB/ZemTi0dw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4106
X-Spam-Status: No, score=-4.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 12 Oct 2023 01:28:08 -0700 (PDT)

On 10/12/2023 1:15 PM, Borislav Petkov wrote:
> On Thu, Oct 12, 2023 at 10:10:43AM +0530, Nikunj A. Dadhania wrote:> 
>> static inline unsigned int get_ctx_authsize(struct snp_guest_dev *snp_dev)
>> {
>> 	return snp_dev->ctx->authsize;
>> }
> 
> Or simply not use a one-liner function at all.

Sure, this is what I meant when I said "I can drop the helper" earlier.

Thanks
Nikunj