Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
MIME-Version: 1.0
References: <2023101238-greasily-reiterate-aafc@gregkh>
In-Reply-To: <2023101238-greasily-reiterate-aafc@gregkh>
From:   Alexander Potapenko <glider@google.com>
Date:   Thu, 12 Oct 2023 10:40:14 +0200
Message-ID: <CAG_fn=X-dnc06r0Yik24jBaL-f7ZzrUQiUJmMHeN9CaSa3ZveQ@mail.gmail.com>
Subject: Re: [PATCH] lib/test_meminit: fix off-by-one error in test_pages()
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org, Andrew Donnellan <ajd@linux.ibm.com>,
        Xiaoke Wang <xkernel.wang@foxmail.com>, stable@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Oct 12, 2023 at 10:17=E2=80=AFAM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> In commit efb78fa86e95 ("lib/test_meminit: allocate pages up to order
> MAX_ORDER"), the loop for testing pages is set to "<=3D MAX_ORDER" which
> causes crashes in systems when run.  Fix this to "< MAX_ORDER" to fix
> the test to work properly.

What are the crashes you are seeing? Are those OOMs?
IIUC it should be valid to allocate with MAX_ORDER.