Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Message-ID: <a3aae63d-b4bb-ace2-ff35-51961364cd1c@bytedance.com>
Date:   Thu, 12 Oct 2023 17:04:51 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.15.0
Subject: Re: [External] Re: [PATCH] sched/core: Fix wrong warning check in
 rq_clock_start_loop_update()
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     mingo@redhat.com, mingo@kernel.org, juri.lelli@redhat.com,
        vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
        rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
        bristot@redhat.com, vschneid@redhat.com,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Igor Raits <igor.raits@gmail.com>,
        Bagas Sanjaya <bagasdotme@gmail.com>
References: <20230913082424.73252-1-jiahao.os@bytedance.com>
 <20230928114159.GJ9829@noisy.programming.kicks-ass.net>
 <979f948c-7611-b137-a06a-ca09ff63f919@bytedance.com>
 <20231010135340.GK377@noisy.programming.kicks-ass.net>
From:   Hao Jia <jiahao.os@bytedance.com>
In-Reply-To: <20231010135340.GK377@noisy.programming.kicks-ass.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2023/10/10 Peter Zijlstra wrote:
> On Sat, Oct 07, 2023 at 04:44:46PM +0800, Hao Jia wrote:
> 
>>> That is, would not something like the below make more sense?
>>
>> If we understand correctly, this may not work.
>>
>> After applying this patch, the following situation will trigger the
>> rq->clock_update_flags < RQCF_ACT_SKIP warning.
>>
>> If rq_clock_skip_update() is called before __schedule(), so RQCF_REQ_SKIP of
>> rq->clock_update_flags is set.
>>
>>
>>
>>
>> __schedule() {
>> 	rq_lock(rq, &rf); [rq->clock_update_flags is RQCF_REQ_SKIP]
>> 	rq->clock_update_flags <<= 1;
>> 	update_rq_clock(rq); [rq->clock_update_flags is RQCF_ACT_SKIP]
>> + 	rq->clock_update_flags &= ~(RQCF_ACT_SKIP|RQCF_REQ_SKIP);
>> 	* At this time, rq->clock_update_flags = 0; *
> 
> Fixed easily enough, just change to:
> 
> 	rq->clock_updated_flags = RQCF_UPDATED;
> 


Thanks for your suggestions and help, I revised the commit message and 
sent patch v2.

https://lore.kernel.org/all/20231012090003.11450-1-jiahao.os@bytedance.com/

Please review again.

Thanks,
Hao

>>
>>           pick_next_task_fair
>>           set_next_entity
>>           update_load_avg
>>           	assert_clock_updated() <---
>> }
>