Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Message-ID: <43b3d605-fe3b-bcd6-a328-81d1448b7104@intel.com>
Date:   Thu, 12 Oct 2023 17:12:26 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.13.0
Subject: Re: [PATCH v4 01/17] iommu: Add hwpt_type with user_data for
 domain_alloc_user op
Content-Language: en-US
To:     "Tian, Kevin" <kevin.tian@intel.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "jgg@nvidia.com" <jgg@nvidia.com>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>
CC:     "cohuck@redhat.com" <cohuck@redhat.com>,
        "eric.auger@redhat.com" <eric.auger@redhat.com>,
        "nicolinc@nvidia.com" <nicolinc@nvidia.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
        "chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
        "yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
        "peterx@redhat.com" <peterx@redhat.com>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "shameerali.kolothum.thodi@huawei.com" 
        <shameerali.kolothum.thodi@huawei.com>,
        "lulu@redhat.com" <lulu@redhat.com>,
        "suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "Duan, Zhenzhong" <zhenzhong.duan@intel.com>,
        "Martins, Joao" <joao.m.martins@oracle.com>
References: <20230921075138.124099-1-yi.l.liu@intel.com>
 <20230921075138.124099-2-yi.l.liu@intel.com>
 <BN9PR11MB52767E1B944C0B2F0667D5DE8CC3A@BN9PR11MB5276.namprd11.prod.outlook.com>
From:   Yi Liu <yi.l.liu@intel.com>
In-Reply-To: <BN9PR11MB52767E1B944C0B2F0667D5DE8CC3A@BN9PR11MB5276.namprd11.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NWQwcEpyTFFYb0RVUkpCY2pMbmVRWkRCNVE1endLSGhTRWpCZjlxTHdnVVR6?=
 =?utf-8?B?dU9aT3huWXc1Z2cvWDM2M1VuWFF0OFY1dm0vVjB5Wk9oUUpNakpzNnYrb2dK?=
 =?utf-8?B?QTlxaXlXaUNyWkRXcWpld25UbGZmY1NKMWloUnRVTzJpKzNjYmxGbCtuOUZW?=
 =?utf-8?B?eTI1eGdhdm1DQUgzUm5yNkwrZ0VXSHA0MWo4QkEvYW9kL1RHMnhIUlNTU1VC?=
 =?utf-8?B?R20rOVlJTjI0dmIwZVpwOWxoa2hUMEhZR0xhTWd2N1QvWDFWenBSTlY0Z1FU?=
 =?utf-8?B?NzkzR0tVLzFZNDdUekw2SlFEL1lpeVhUSVNKSFZ5eWlqT0UveXdaNEh4WVEw?=
 =?utf-8?B?dy91YVMxYzJFTzgyVjNHMjQxTThEOStiR1A1WXBPSHBLVkxUNHJHR3ozdy9t?=
 =?utf-8?B?dGZtOGdPVEIyeC9sYW02cnlYYkxJQ3hXQUFCUWJoaytrajZ4MFJ6a25wbzU0?=
 =?utf-8?B?dDZWeXJ4dTNTSDcybFhGK0JXSytGKzlpaDRhR3M4b01Bdit6RENCWlA1VExQ?=
 =?utf-8?B?ZEU1TXNhUytlVE1adHAyZHFuUjcyekZsVjlDaHVTODBPMWRNLzY1NGZCWkZa?=
 =?utf-8?B?SlU0bnR2ajh3RUk3WEtSaTZ2R3ZFZVFiZEJvaFJMcFcxUnJHOTNMRXVORng3?=
 =?utf-8?B?SnI0Y1ZjT3FPUEJFVGszaWVOZlBVc3gxcVJQemVBbDZ3T0tncXdGVXFzOUEz?=
 =?utf-8?B?UTZSb2RxVmZXaWRybFRqWmFvai9hVC84ZlYxaWUzUEVyUmRMOU0zWDdtejNi?=
 =?utf-8?B?SktaTmx4alB5TDNFZGpIbzlSSkxudHhIMjlSd0VucVVBZXdMNEdVSnN4d2wx?=
 =?utf-8?B?Uk5jZGpXaktYbDJHY0oyb3hvREdFdmVyUVplUVptTDZ0ZkVhcmo4NVNCcmM4?=
 =?utf-8?B?QVA1TUdxdnpMaVd5NitER0NIckRxcWxQTUxzdWJvWmdpbjhuSVJMNVQ2V0l6?=
 =?utf-8?B?UjZpRTA5anQ4RGRZOEo2dTNoTUNLS09xQ3lsWm1ENTdGLzRsVTBlYU10dGNn?=
 =?utf-8?B?ZEJxUXY2bUZadVROYXRaMWVnUVVWODZUeDRnbGovWGoyMUpJWlZ6WllCOXFp?=
 =?utf-8?B?cDdlbVQxQ0h2L0gwbHk1cFh4QjRCWkNSb2NiM0Q0KzVnMFNxckV2NFd4ZW9h?=
 =?utf-8?B?YWFraTVKQjhWT05IUzFabVIxWVoya0Fsb3hqNnUyR05tS0hVNXZOdW4rZndm?=
 =?utf-8?B?ZWljUHBWcnhFN0h3K3AvZEVZazRQVHlJTkZ4WXNJUnNqRjF0c0gzUVpUZnRC?=
 =?utf-8?B?QUlNOFhXbG5ueEY1OU9CSkVDTDJyRFN5VmJJWTRlZmc1c054bENyRnRyZm80?=
 =?utf-8?B?UEQyNG9CWnN6SkcyMC9tTXhDZlB5QUR6dkxwMTRHVWkyelFDQk1TcGl6T2dy?=
 =?utf-8?B?ZUZ1L3cydnhiSXFDMVRzak4rUzhoOXZPMlU4eTA2c1VVMy9hU3RUMDNDdk1J?=
 =?utf-8?B?dlZRYmN1bWlrOVZ1WmlQN1JVTUs2R1NCUHBWUDJXUnZMZm9GWVdoUGVxZFE2?=
 =?utf-8?B?WGRNbnQvQmljekFYbHUzTXVTbWdXTUZiR1FkaE42dHd6UE80UWp5TDBML0xK?=
 =?utf-8?B?clJ5NFJVWllrYllOOTBBOFFncHI1dEhhMmZYUFpVeVRLWVVpaEhHMXNkQVJS?=
 =?utf-8?B?WEJGTmdTYVJVdzZDRXlVdzBqaU1rQWY3d0RIeDczcWZIOGZSYVdUalJDNjc2?=
 =?utf-8?B?SHgvcnlZWit0NkNkNkpObmZWUFVSYkVCZklWSG5URXZ3OGNMZVVpWDBmMG43?=
 =?utf-8?B?VU5DN0J2VzVKN053d3BmN1kzdEVyWGlmRC9FZktwamhVUTMxbzZ3cUwyK0Qx?=
 =?utf-8?B?Rld5MEZ5VVcvT2l1N1FmdGErTGNlMTgvRnhtYy9ndnRWUVIwUnB0eTkvcUpX?=
 =?utf-8?B?UStDK1hXSFA0clFkcXI0eG5JdHNZWnVtbTFzWDczODlvaStmU2ZoaXR3ZUlj?=
 =?utf-8?B?dGFyUHNJMTVTVVM0ZXlOVnY5L0RpbkN5V3VEVWZvUWdoSXlBcVRCVW1Td2Rn?=
 =?utf-8?B?bUkzVE9xVWROeTBhVFhLYytrUytNYjZNZ3RNS283UjgycW9aRUo0bGVTanlw?=
 =?utf-8?B?OVNlNStSMDduaUFoSlBKQVJuL3lEbzk0S2FIMFpyRFlrcXVIR3hBNlhYaVpN?=
 =?utf-8?Q?KkUJ+kEdPjJdZvi61WD4qyAyb?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 87fe001f-c30f-477f-9598-08dbcb0306a7
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7529.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2023 09:10:06.3556
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PGLce9vQAbjRVVruW0YlStPIw7g7DK/e00AtjrOWVPHTaxsdlZHhp/5gLMC/bTBy5djQxm32DWEk+s//Efutrg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB7992
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 12 Oct 2023 02:10:48 -0700 (PDT)

On 2023/9/26 14:56, Tian, Kevin wrote:
>> From: Yi Liu <yi.l.liu@intel.com>
>> Sent: Thursday, September 21, 2023 3:51 PM
>> +
>> +/**
>> + * iommu_copy_user_data - Copy iommu driver specific user space data
>> + * @dst_data: Pointer to an iommu driver specific user data that is defined
>> in
>> + *            include/uapi/linux/iommufd.h
>> + * @src_data: Pointer to a struct iommu_user_data for user space data info
>> + * @data_len: Length of current user data structure, i.e. sizeof(struct _dst)
>> + * @min_len: Initial length of user data structure for backward compatibility.
>> + *           This should be offsetofend using the last member in the user data
>> + *           struct that was initially added to include/uapi/linux/iommufd.h
>> + */
>> +static inline int iommu_copy_user_data(void *dst_data,
>> +				       const struct iommu_user_data *src_data,
>> +				       size_t data_len, size_t min_len)
> 
> iommu_copy_struct_from_user()?
> 
> btw given the confusion raised on how this would be used is it clearer
> to move it to the patch together with the 1st user?

sure. How about your opinion? @Nic.

-- 
Regards,
Yi Liu