Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
From:   Pratyush Yadav <pratyush@kernel.org>
To:     Michael Walle <michael@walle.cc>
Cc:     Md Sadre Alam <quic_mdalam@quicinc.com>, tudor.ambarus@linaro.org,
        pratyush@kernel.org, miquel.raynal@bootlin.com, richard@nod.at,
        vigneshr@ti.com, linux-mtd@lists.infradead.org,
        linux-kernel@vger.kernel.org, quic_srichara@quicinc.com,
        quic_varada@quicinc.com
Subject: Re: [PATCH] mtd: spi-nor: Ensure operation completion before shutdown
In-Reply-To: <bb12db1205a5d1bfbee341d23defe0be@walle.cc> (Michael Walle's
        message of "Thu, 12 Oct 2023 11:11:09 +0200")
References: <20231012055148.2445303-1-quic_mdalam@quicinc.com>
        <bb12db1205a5d1bfbee341d23defe0be@walle.cc>
Date:   Thu, 12 Oct 2023 12:06:19 +0200
Message-ID: <mafs034ygm9yc.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On Thu, Oct 12 2023, Michael Walle wrote:

> Hi,
>
> Am 2023-10-12 07:51, schrieb Md Sadre Alam:
>> Ensure that there are no pending spi operation inprogress
>> when system halts.
>
> What operation might be in progress here? Did you encounter some problems?
> Please explain it in more detail in the commit message.

+1

Ideally we should never reach this function with a pending operation. I
think we should do a proper wait in the place we did the operation that
needs waiting rather than here. That would make sure operations other
than shutdown, like reads, also work properly.

-- 
Regards,
Pratyush Yadav