Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Date:   Thu, 12 Oct 2023 13:14:56 +0300
From:   kirill.shutemov@linux.intel.com
To:     Nikolay Borisov <nik.borisov@suse.com>
Cc:     ardb@kernel.org, linux-efi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/efistub: Don't try to print after ExitBootService()
Message-ID: <20231012101456.goamenepqlte65jv@box.shutemov.name>
References: <20231011192528.262425-1-nik.borisov@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231011192528.262425-1-nik.borisov@suse.com>
Precedence: bulk

On Wed, Oct 11, 2023 at 10:25:28PM +0300, Nikolay Borisov wrote:
> setup_e820() is executed after UEFI's ExitBootService has been called.
> This causes the firmware to throw an exception because Console IO
> protocol handler is supposed to work only during boot service
> environment. As per UEFI 2.9, section 12.1:
> 
>  "This protocol isused to handle input and output of text-based
>  information intended for the system user during the operation of code
>  in the boot services environment."
> 
> Running a TDX guest with TDVF with unaccepted memory disabled results in
> the following output:

Oh. My bad.

But there's other codepath that does the same. If setup_e820() fails with
EFI_BUFFER_TOO_SMALL, efi_stub_entry() would try to print "exit_boot()
failed\n".

I wouldner if it is feasible to hook up earlyprintk console into
efi_printk() machinery for after ExitBootService() case? Silent boot
failure is not the best UX.

-- 
  Kiryl Shutsemau / Kirill A. Shutemov