Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Date:   Thu, 12 Oct 2023 12:26:49 +0200
From:   Lucy Mielke <lucymielke@icloud.com>
To:     Sean Christopherson <seanjc@google.com>
Cc:     Peter Zijlstra <peterz@infradead.org>, mingo@redhat.com,
        acme@kernel.org, mark.rutland@arm.com,
        alexander.shishkin@linux.intel.com, jolsa@kernel.org,
        namhyung@kernel.org, irogers@google.com, adrian.hunter@intel.com,
        tglx@linutronix.de, bp@alien8.de, dave.hansen@linux.intel.com,
        x86@kernel.org, hpa@zytor.com, linux-perf-users@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf/x86/p4: Fix "Wunused-but-set-variable" warning
Message-ID: <ZSfJ6c5fo5enjvv+@fedora.fritz.box>
References: <ZSGpl_hT23B6ix0M@mainframe>
 <20231007203411.GA8085@noisy.programming.kicks-ass.net>
 <ZSQqfr96SfZM_OEk@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ZSQqfr96SfZM_OEk@google.com>
Precedence: bulk

Am Mon, Oct 09, 2023 at 09:29:50AM -0700 schrieb Sean Christopherson:
> 
> rdmsr() writes to "high", but nothing ever reads from high.  FWIW, I would _love_
> for rdmsrl() to have return semantics, e.g. to be able to do:
> 
> 	low  = (u32)rdmsrl(MSR_IA32_MISC_ENABLE);
> 
> or even
> 
> 	if (!(rdmsrl(MSR_IA32_MISC_ENABLE) & BIT(7)))

I have taken a look and it seems to me like this macro is called quite a lot
for different things thoughout the kernel tree, including drivers. If
one were to change it to have return semantics instead of the way it
currently works, you'd have to change around 300 occurences, right?
(Let me know if I misunderstood something.)

Return semantics or not, since the only way "high" is used in p4_pmu_init()
is by being written to by rdmsr(), the variable can be completely removed by
just using rdmsrl(). Would this be a patch you'd be interested in?

Mit freundlichen Gr??en / Best regards,
	Lucy