Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Date:   Thu, 12 Oct 2023 12:26:58 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Alexander Potapenko <glider@google.com>
Cc:     linux-kernel@vger.kernel.org, Andrew Donnellan <ajd@linux.ibm.com>,
        Xiaoke Wang <xkernel.wang@foxmail.com>, stable@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] lib/test_meminit: fix off-by-one error in test_pages()
Message-ID: <2023101201-grasp-smartly-2085@gregkh>
References: <2023101238-greasily-reiterate-aafc@gregkh>
 <CAG_fn=X-dnc06r0Yik24jBaL-f7ZzrUQiUJmMHeN9CaSa3ZveQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAG_fn=X-dnc06r0Yik24jBaL-f7ZzrUQiUJmMHeN9CaSa3ZveQ@mail.gmail.com>
Precedence: bulk

On Thu, Oct 12, 2023 at 10:40:14AM +0200, Alexander Potapenko wrote:
> On Thu, Oct 12, 2023 at 10:17 AM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > In commit efb78fa86e95 ("lib/test_meminit: allocate pages up to order
> > MAX_ORDER"), the loop for testing pages is set to "<= MAX_ORDER" which
> > causes crashes in systems when run.  Fix this to "< MAX_ORDER" to fix
> > the test to work properly.
> 
> What are the crashes you are seeing? Are those OOMs?

They are WARN_ON() triggers.  They are burried in the Android build
system, let me see if I can uncover them.

> IIUC it should be valid to allocate with MAX_ORDER.

"should", but I no longer get runtime warnings with this patch applied,
so something is wrong :)

Let me go dig for the logs again...