Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Thu, 12 Oct 2023 13:39:44 +0300
From:   Pekka Paalanen <ppaalanen@gmail.com>
To:     Daniel Vetter <daniel@ffwll.ch>
Cc:     jim.cromie@gmail.com,
        =?UTF-8?B?xYF1a2Fzeg==?= Bartosik <lb@semihalf.com>,
        linux-kernel@vger.kernel.org, Steven Rostedt <rostedt@goodmis.org>,
        "wayland-devel@lists.freedesktop.org" 
        <wayland-devel@lists.freedesktop.org>,
        Sean Paul <seanpaul@chromium.org>,
        dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH v1] dynamic_debug: add support for logs destination
Message-ID: <20231012133944.69711822@eldfell>
In-Reply-To: <ZSfCMBXOOi9Luc6F@phenom.ffwll.local>
References: <20231003155810.6df9de16@gandalf.local.home>
        <CAJfuBxyJyFbFEhRxrtxJ_RazaTODV6Gg64b1aiNEzt6_iE4=Og@mail.gmail.com>
        <CAK8ByeLNc9UbTNG4x=40AxYqjjRCsvBNtNFai0PMveM2X4XCow@mail.gmail.com>
        <CAJfuBxyRF4q_T8LmHwR=-PKKDDpiFg2nO03uLnL8aGpRyBByKw@mail.gmail.com>
        <CAK8ByeLpkSV6o6gPw8eJVqq5+ynQrSDjemY7mXkO1ZmA0rYKfQ@mail.gmail.com>
        <CAJfuBxw+ANLwssAGWpkn5PeJb8ZKn4LXQkk2Gfv3aGsSN=S55Q@mail.gmail.com>
        <CAJfuBxy9qn-4i3SteTL1LBbBxPrFM52KkBd=1UhcKV3S_KdQvw@mail.gmail.com>
        <20231011114816.19d79f43@eldfell>
        <ZSZuACLwt5_XAL2n@phenom.ffwll.local>
        <20231012115548.292fa0bb@eldfell>
        <ZSfCMBXOOi9Luc6F@phenom.ffwll.local>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/V8y/wlfhGWh8m+OH4pSW+7u";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Precedence: bulk

--Sig_/V8y/wlfhGWh8m+OH4pSW+7u
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

On Thu, 12 Oct 2023 11:53:52 +0200
Daniel Vetter <daniel@ffwll.ch> wrote:

> On Thu, Oct 12, 2023 at 11:55:48AM +0300, Pekka Paalanen wrote:
> > On Wed, 11 Oct 2023 11:42:24 +0200
> > Daniel Vetter <daniel@ffwll.ch> wrote:
> >  =20
> > > On Wed, Oct 11, 2023 at 11:48:16AM +0300, Pekka Paalanen wrote: =20

...

> > > > - all selections tailored separately for each userspace subscriber
> > > > (- per open device file description selection of messages)   =20
> > >=20
> > > Again this feels like a userspace problem. Sessions could register wh=
at
> > > kind of info they need for their session, and something like journald=
 can
> > > figure out how to record it all. =20
> >=20
> > Only if the kernel actually attaches all the required information to
> > the debug messages *in machine readable form* so that userspace
> > actually can do the filtering. And that makes *that* information UABI.
> > Maybe that's fine? I wouldn't know. =20
>=20
> Well if you configure the filters to go into separate ringbuffers for each
> session (or whatever you want to split) it also becomes uapi.

It's a different UAPI: filter configuration vs. message structure. I
don't mind which it is, I just suspect one is easier to maintain and
extend than the other.

> Also I'd say that for the first cut just getting the logs out on demand
> should be good enough, multi-gpu (or multi-compositor) systems are a step
> further. We can figure those out when we get there.

This reminds me of what you recently said in IRC about a very different
topic:

	<sima> swick[m], tell this past me roughly 10 years ago, would
	have been easy to add into the design back when there was no
	driver code yet=20

I just want to mention today everything I can see as useful. It's up to
the people doing the actual work to decide what they include and how.


Thanks,
pq

--Sig_/V8y/wlfhGWh8m+OH4pSW+7u
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEJQjwWQChkWOYOIONI1/ltBGqqqcFAmUnzPAACgkQI1/ltBGq
qqcgOBAAkNg/qe5usX57owmljxA5OMxQ9zGY9LO58+UbrVSeYOQgr087FZpIf2LJ
0AKOGqgH9aa6jVPTncN8i3DdfB3wKdrYO0VUDLg2jkzXq57FsD2XUL1OdxirtI9r
WPAYEkzQLwaoI6Dc/VfTWgcHpQ9i5Z0pVqJZ5SMn0s6HDKoLxLOWNq75NPNV6eLG
6LBWICQPT0WoocsF1G747/RsdmDxHihv3zs9+YnrZU7AYrok+VxIcw+ze81guWpt
XtqHP7Lfngu8qDmQFuG2U6JG75R4oKc+Nzmvoyr8n0bE66EkUeA/Lw+dEJvr5KB5
wvPQP4kHdPblnATAak5EencXSPm4vsmWpJymr24zy6FYJmM20hR1H6x0TTgv8eux
CWC02+vgweXnIVktJuwQHHoWVe0i+CPdcPQx+etAodicoHMr8JVcrfLgijFkLyME
Qg865bepY2hxJuVIqPkW2OFfzdludfUlPE8QaVM56sakfzB3rXcmwmsIBaPiuJ5P
9Vdxtl03SuoHbPj09jYOXf/ldizPjVG2U8McQ/tQBRnJzUCBGnWETGsZa1SP5mXs
Nzj2XvD+LdjsBOVLVxZyYaSRjnRJ/+WF1J7BfqqPww6g8p5ZxZuGQ8gds0TE9Pyj
7ITB9OLv9f7SN1eN/Pg8qCNlOFwf9cC8h3g/O0Em39+JWZ8HDBw=
=fzw5
-----END PGP SIGNATURE-----

--Sig_/V8y/wlfhGWh8m+OH4pSW+7u--