Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Thu, 12 Oct 2023 13:00:38 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Sumit Gupta <sumitg@nvidia.com>, krzysztof.kozlowski@linaro.org
Cc:     treding@nvidia.com, jonathanh@nvidia.com,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
        bbasu@nvidia.com
Subject: Re: [Patch v2 2/2] memory: tegra: set BPMP msg flags to reset IPC
 channels
Message-ID: <ZSfR1l3lHMScTyL9@orome.fritz.box>
References: <20231009100557.18224-1-sumitg@nvidia.com>
 <20231009100557.18224-3-sumitg@nvidia.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="r7Jhz+PyVOcqXRlM"
Content-Disposition: inline
In-Reply-To: <20231009100557.18224-3-sumitg@nvidia.com>
User-Agent: Mutt/2.2.12 (2023-09-09)
Precedence: bulk


--r7Jhz+PyVOcqXRlM
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Oct 09, 2023 at 03:35:57PM +0530, Sumit Gupta wrote:
> From: Thierry Reding <treding@nvidia.com>
>=20
> Set the 'TEGRA_BPMP_MESSAGE_RESET' bit in newly added 'flags' field
> of 'struct tegra_bpmp_message' to request for the reset of BPMP IPC
> channels. This is used along with the 'suspended' check in BPMP driver
> for handling early bandwidth requests due to the hotplug of CPU's
> during system resume before the driver gets resumed.
>=20
> Fixes: f41e1442ac5b ("cpufreq: tegra194: add OPP support and set bandwidt=
h")
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> Co-developed-by: Sumit Gupta <sumitg@nvidia.com>
> Signed-off-by: Sumit Gupta <sumitg@nvidia.com>
> ---
>  drivers/memory/tegra/tegra234.c | 4 ++++
>  1 file changed, 4 insertions(+)

Krzysztof,

this one has a build-time dependency on patch 1/2, so it'd make sense
for me to pick this up into the Tegra tree along with patch 1/2. That
is slightly easier because I already have a BPMP patch in the tree.

There should be no conflict between this and the Tegra tree, though,
so if you feel strongly about it, you could also pick up both patches,
in which case:

Acked-by: Thierry Reding <treding@nvidia.com>

>=20
> diff --git a/drivers/memory/tegra/tegra234.c b/drivers/memory/tegra/tegra=
234.c
> index 9e5b5dbd9c8d..2845041f32d6 100644
> --- a/drivers/memory/tegra/tegra234.c
> +++ b/drivers/memory/tegra/tegra234.c
> @@ -986,6 +986,10 @@ static int tegra234_mc_icc_set(struct icc_node *src,=
 struct icc_node *dst)
>  	msg.rx.data =3D &bwmgr_resp;
>  	msg.rx.size =3D sizeof(bwmgr_resp);
> =20
> +	if (pclient->bpmp_id >=3D TEGRA_ICC_BPMP_CPU_CLUSTER0 &&
> +	    pclient->bpmp_id <=3D TEGRA_ICC_BPMP_CPU_CLUSTER2)
> +		msg.flags =3D TEGRA_BPMP_MESSAGE_RESET;
> +
>  	ret =3D tegra_bpmp_transfer(mc->bpmp, &msg);
>  	if (ret < 0) {
>  		dev_err(mc->dev, "BPMP transfer failed: %d\n", ret);
> --=20
> 2.17.1
>=20

--r7Jhz+PyVOcqXRlM
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmUn0dMACgkQ3SOs138+
s6HkqQ/+OpWQXncgqcn9vEN7Qu10eafaP//XzRWKSSbQOj0+b7uO3EMELiJYhmSR
3ZJfb+7rJ+MKEXmJf76dIbjT8U1FvcG1RmgjMMDQLIKgQ69pYLyVGHSfnMbJkkkA
FVrxe0lL6BUDQytS7UnNQhAw+VeM08RZr2yySo1/VXNF6JAeXsc3lSbFC7T5pw3G
8SU7Lt/XAzYFRyMflJga+IkPeZXAoEMGUE614Wt8hMd5VkYrwFBO7x5RE1EOPDtj
Yk1N6Kb8pp40ODfZn/cFFpEiXHv8klgxtwiZjCdhU6ZBbMqaa2nDdghRkcM/ShJv
DD4RkDdjp2PmruwmgBbQGfTxL09HAyEM6Qlbhaewq5LCdYHRtY9J3Au//NyeRKLW
aSP50/ZCgOrOKxyU+uWhMwESKM1xMbKHoaKBCAXvJLvby1lBIx4Exu7kPmMqc9Ol
2slA689tUJGukxOY7A8ApS0ynlxHhOchQR6gkumOnM5qWKr9CgEPCTXOdex7aaDZ
CtXrEoV2CY2/UabFCtHhWPQ1SCGWAhyetUeKasZM8pPW3eGIZhrjj7Vz3e7kirmu
97h39JjE0ZcdAKIJXfGOvnfGJ60Q1d1WXmMahZxhrau+JUb6mSevuiC7gPyCC6/e
JbMxn8gW5lhXhh4ICEoxWuvOomAMG6hxyTIxQYHeOhwoL1f1ML4=
=nVs5
-----END PGP SIGNATURE-----

--r7Jhz+PyVOcqXRlM--