Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <9346655c-df15-498b-a6e3-f6dd918c663a@suse.com>
Date:   Thu, 12 Oct 2023 14:28:31 +0300
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] x86/efistub: Don't try to print after ExitBootService()
Content-Language: en-US
To:     ardb@kernel.org
Cc:     linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
        "kirill.shutemov@linux.intel.com" <kirill.shutemov@linux.intel.com>
References: <20231011192528.262425-1-nik.borisov@suse.com>
 <20231012101456.goamenepqlte65jv@box.shutemov.name>
From:   Nikolay Borisov <nik.borisov@suse.com>
In-Reply-To: <20231012101456.goamenepqlte65jv@box.shutemov.name>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NHRRaVk0TEpxbFM0eGZpY2lSbGRZRUl2UkVqa3Z6d1FMOUpCNlZsckxybURW?=
 =?utf-8?B?VTk4S3k2clhQR09PTk1TVzlhc3V3UXZYZkd0UlFpU0N4SWgyVHVOWnBoNHBB?=
 =?utf-8?B?ZktVWlBETXBmSCtIYUVSZGg4dXpOQ1d2cDRUUjYxdXNOdmRVSkNod0p1ZFkx?=
 =?utf-8?B?UHpyMHJwVUczMGdYYSszQmJlYWVZVlFZbVJranFQd1pNN0g2cWN1VmRWdkFE?=
 =?utf-8?B?M2xrZlRUSElCK2FEaUk4amw5OWZLSlJ0SkMrMWZRT0hqUnR5Y242Q1NlQ2ZU?=
 =?utf-8?B?SkNFOUcyYm1VQTNPelJiN0pVMzJXQUhkL3VwcGhYemJaR2pLUVJLbldxVWN5?=
 =?utf-8?B?eGYrczhxaVloRTB3cWJVMzJ5bCtwT2JmTFMyRldLaHZ6bzMvKzl0bGZyNFo4?=
 =?utf-8?B?L1RjLzhUaW1pTTc3VFVZOTlhTk9Ta29lbkVQMlY0YW5DQnNZazZkSkpuMmRt?=
 =?utf-8?B?UXR6T3hWWEdsVlYyNjhpR2JCM09uSldpcnFsdUg4cDNSSk1mTGVYYkEwOTNN?=
 =?utf-8?B?Ri84NWVWZWlmV3VWVDNpQVZCekIzNnpSbHAwOVJqaFlGbTNDbTFVVjN5Vjdn?=
 =?utf-8?B?cFl2YzY3bHJlMDBQTFhtM0NUdC8rRGw3anpwbmdTNWZ0VmNCMVZKeFN5bEpx?=
 =?utf-8?B?YzAvM2w5UVBjZEw5MTIzT3R3R2syVUJhaXhVcGZuK1lJOGdRa21oQXBNV3dp?=
 =?utf-8?B?MGlZajU0SFZyV3V0eUVUeFB0T0pKZFZVeXJieTFaUi80S1d2QnE0ZXhLOWo2?=
 =?utf-8?B?ZVVpUUFsRHdhRVJrMzMxbFNnUGdMSytybjhHWWt2TUxVZDJ0WGFHZWExclpi?=
 =?utf-8?B?RG50a2J6dUNwcVdwZEFRTHl4Vks3eE14aFI3L0l2WW4vejdlS0xiY3JrMmxm?=
 =?utf-8?B?WHZBNjF4Mlc0ZmFzbzVVbnhEZ0diYnB0clJXbXJEUUlmaFdDOWF4SnRFZ3BF?=
 =?utf-8?B?S1U1TStrazA3SUdJektzaHA4QVBMV0pSaExWSXEvMEt0SVppdFhKRkczY2Nm?=
 =?utf-8?B?ZUpzaFpUZnN4TXJNbkFlTWxBYnZvK3JTTnZEVkhZK3RvNnZjZlUwMnMzc1Zs?=
 =?utf-8?B?a0RsK1JFM3BGTWMvSXl2ZWZMenVzcXREY3dra0cxaEthT0VLTzFtWE9XZE9o?=
 =?utf-8?B?WG9tNWs3a3J6eVl4TDU0TXNIck1PNHJVRHpBOFhpZmdTRDFmMStnWk5LdFly?=
 =?utf-8?B?RkZ6c2laelROdW84d043RXUzOVlmVjZaSWFqK3VBZzhZMDlJV1pMZ2VIOTh4?=
 =?utf-8?B?Zmc5M1ZkaWRVcVBQMDRUU1BPVmtyZ2Y1TXVCbFpWcHZncW9QQk1mMkdydHpo?=
 =?utf-8?B?VEtSWEs2d0R6MlFiWWNtZTFia0MyeUdUQko2aWcycE90WEF0WW1va3Z4SXQ5?=
 =?utf-8?B?MGhKa3Z3UGRPS096MENDQUM3VkFadmN0cnA1ODVoQTNNMFE3cVRIZkcvK1Zy?=
 =?utf-8?B?b3JkeDhqelZYNFQ0YUg4TjFZRTNYR2YwVTQ0dmpPV29KWVo4TmdVSTAyVU93?=
 =?utf-8?B?RkphTkJvdGJBL3FwckF2NUJxTjQwZWowaFM2UVJPbFFHbXY1K2RnODJFR0RN?=
 =?utf-8?B?bC9mMEhPU3JWM2tYaTJEdGw0QzBGdFpWbjJ4eW5lcTBtTU5NSEJDWFRpdHZS?=
 =?utf-8?B?czFxbkY1VldvZkFZNVdJdFU2TVhZNlF5UHNSWFliMm5BU0xJUENOb05teDcr?=
 =?utf-8?B?MjNiNWJRa2pURzVlZlJHeEx4K1pkZUltbFdGV0lsWmZaRTRIeU1DcTNVSWxD?=
 =?utf-8?B?L1o2amV0OGFUYVhyaFkvRlgyS3lnZkhzVmhoTTZja0NuT2hHYUNDeDEyRFUx?=
 =?utf-8?B?bzd1SjBDNG5Xa01TV0VmVXBQNkZkQ1BWZHhrSjcxYWJzRTRoRXM5a2QyY2RO?=
 =?utf-8?B?RlgwSGl4QkpIOXEvei8yUFdPNUl6alBiZGFnTkV0R3g0Vlk1T040S3FSWTFk?=
 =?utf-8?B?QVhWdS90L00vMVFwYWJRenZyZ1NxVVlJL3NQckJYbkZ0aTU4VEpIN0NRdjdL?=
 =?utf-8?B?M3FBUUxNT0xmSk1XdGVYTnd6dThGSWtqenJJdS9FU1NwKytkeXA5cVNtNHdv?=
 =?utf-8?B?TnhrZzZlWDRrNXQxOTBLRVl2azhhelJLazFaR2Fob2hDeGVoQnBXZ2hDMTNz?=
 =?utf-8?B?UGpML3EvSjJOb1F0TGdhekhPdjNRNmxkRHpvL0FwQmlWT2NrYjFma0NuU25D?=
 =?utf-8?Q?ANjhfnpQbR/YrU2YhhuA3AiBqoRJR7wLhvpj6RqTiFqT?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 284845a1-c1d0-4491-36e5-08dbcb165f7e
X-MS-Exchange-CrossTenant-AuthSource: PA4PR04MB7790.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2023 11:28:36.5305
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lDU2NC+g8A69WRv8COBniWPS0Y2jQjdpKlltl9aN8nEW1Uoz79v94O8wEniaTsSDxOZeAW1iN+2bFAgfd92+RA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7435
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 12 Oct 2023 04:28:49 -0700 (PDT)


On 12.10.23 г. 13:14 ч., kirill.shutemov@linux.intel.com wrote:
> On Wed, Oct 11, 2023 at 10:25:28PM +0300, Nikolay Borisov wrote:
>> setup_e820() is executed after UEFI's ExitBootService has been called.
>> This causes the firmware to throw an exception because Console IO
>> protocol handler is supposed to work only during boot service
>> environment. As per UEFI 2.9, section 12.1:
>>
>>   "This protocol isused to handle input and output of text-based
>>   information intended for the system user during the operation of code
>>   in the boot services environment."
>>
>> Running a TDX guest with TDVF with unaccepted memory disabled results in
>> the following output:
> 
> Oh. My bad.
> 
> But there's other codepath that does the same. If setup_e820() fails with
> EFI_BUFFER_TOO_SMALL, efi_stub_entry() would try to print "exit_boot()
> failed\n".
> 
> I wouldner if it is feasible to hook up earlyprintk console into
> efi_printk() machinery for after ExitBootService() case? Silent boot
> failure is not the best UX.
> 

So looking at the code the only thing which would prevent refactoring to 
exit logic to directly call exit_boot_func etc and setup_e820 before 
calling efi_exit_boot_services is if the memory map changes. The current 
code ensures that we really have the latest memory map version and so 
setup_e820 is called with the latest version.

Ard, how likely it is that the memory map can indeed change between the 
calls to getmemorymap and exitbootservice?