Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp276285rdg; Thu, 12 Oct 2023 05:36:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFgGyO5Gty3KUDYnQmoE9+R/o3z6oLb1f7xuZ/hrxoY0KftngAmX4hMrYJGujnrsQ2GAqv0 X-Received: by 2002:a05:6a00:138e:b0:68f:c2f7:cef0 with SMTP id t14-20020a056a00138e00b0068fc2f7cef0mr36152036pfg.4.1697114180529; Thu, 12 Oct 2023 05:36:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697114180; cv=none; d=google.com; s=arc-20160816; b=Zh09/qofO+mwrLupkch6ZcOwt0hsZxYjIDB61zpRpIYGl20Z9wLBP2+SJ7VjgHHGrx gVCPFpIAyPPciKInrwQURHZuL4+Ew/H1bxu9hqUdSncgbSXjJ0yuBcLldHpb1sEE8s7n 1Am+cacuocUyOkb3r0cMaez+3eqaruv9e4DgRDTnHp2UsHj7yeA6foox6ccilaCSx4LG FjOxiFUfJra0bFFd9drlc4PktDpXalmqNmnWuT3MOJfAKPWpZ/LYUEqXWUBxLy9y3+RZ QoIybzYP/t8ZnvoG6ujR0qvumyoCdmOctHbJAOII+V07TyFSQuz9Nm5+Q2GQKzfrtmNz 6aUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:message-id:date:cc:to :from:subject:references:in-reply-to:importance:sensitivity :mime-version; bh=O/qBrcw0NvrIGBB+DYTplc14ge3JgCo1n/j1qP4NbY4=; fh=iTU6yCgiii6lcLD/ZWNOto8ykn6wuVxhgopFFmFaH88=; b=fy9VbJm+0sQW9N/c4vyKHbAsqDm/Ym5V66lWSlQh5VkKfQl+3/dje3oVmFTIpwasUM o0sPpI6eCJdazqXo12eEtrM9Es5ezt6yzKUf/C2NevLpCd7hCraqinwEJXLPlULToG87 PimcTVtRV4k/XDqzgezZNl2lc9TkFw4MdS9IeaOF59/UNpbBo33E/ZDUWoFvqBhKHn66 TC9qKDXVgQv1P1R9JkQg6DFbxGD54I2u8yLCqZC1Rrz0y/JYTYPX5El35+yIxj47GlhD lUQYFzkNW+zXBHNY1Lfn+mBXJ9wqVR+7WazivZec++/Q50cuELHvbPGk+b1CwqxmClxT Brew== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=imaqliq.ru Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id e33-20020a631e21000000b005783367f97fsi2156737pge.342.2023.10.12.05.36.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Oct 2023 05:36:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=imaqliq.ru Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 598B4802A9D3; Thu, 12 Oct 2023 05:36:12 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378640AbjJLMgD convert rfc822-to-8bit (ORCPT + 99 others); Thu, 12 Oct 2023 08:36:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39544 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378561AbjJLMf4 (ORCPT ); Thu, 12 Oct 2023 08:35:56 -0400 Received: from postfix2.imaqliq.com (postfix2.imaqliq.com [93.189.151.48]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D9A1BE; Thu, 12 Oct 2023 05:35:53 -0700 (PDT) Received: from verse.imaqliq.com (verse.imaqliq.com [93.189.151.95]) by postfix2.imaqliq.com (Postfix) with ESMTP id E78D01C2943; Thu, 12 Oct 2023 15:35:50 +0300 (MSK) MIME-Version: 1.0 Sensitivity: Importance: Normal X-Priority: 3 (Normal) In-Reply-To: <20231012103957.p2faputywfgh776x@CAB-WSD-L081021> References: <20231012103957.p2faputywfgh776x@CAB-WSD-L081021>, Subject: Re: [PATCH] tty: serial: meson: hard LOCKUP on crtscts mode From: pkrasavin@imaqliq.ru To: "Dmitry Rokosov" Cc: "Greg Kroah-Hartman" , "Jiri Slaby" , "Neil Armstrong" , "Kevin Hilman" , "Jerome Brunet" , "Martin Blumenstingl" , , , , , Date: Thu, 12 Oct 2023 12:35:45 +0000 Message-ID: X-Mailer: Lotus Domino Web Server Release 12.0.2 November 03, 2022 X-MIMETrack: Serialize by http on verse/com(Release 12.0.2|November 03, 2022) at 10/12/2023 12:35:45, Serialize complete at 10/12/2023 12:35:45, Serialize by Router on verse/com(Release 12.0.2|November 03, 2022) at 10/12/2023 12:35:50 X-KeepSent: 69FF15CB:37BD077D-00258A46:0044809B; type=4; name=$KeepSent Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-KLMS-Rule-ID: 1 X-KLMS-Message-Action: clean X-KLMS-AntiSpam-Lua-Profiles: 180564 [Oct 12 2023] X-KLMS-AntiSpam-Version: 6.0.0.2 X-KLMS-AntiSpam-Envelope-From: pkrasavin@imaqliq.ru X-KLMS-AntiSpam-Rate: 10 X-KLMS-AntiSpam-Status: not_detected X-KLMS-AntiSpam-Method: none X-KLMS-AntiSpam-Auth: dmarc=fail header.from=imaqliq.ru policy=none;spf=softfail smtp.mailfrom=imaqliq.ru;dkim=none X-KLMS-AntiSpam-Info: LuaCore: 539 539 807534d9021bfe9ca369c363d15ac993cd93d4d9, {rep_avail}, {Tracking_from_domain_doesnt_match_to}, 127.0.0.199:7.1.2;gdc.ru:7.1.1;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;verse.imaqliq.com:7.1.1;imaqliq.ru:7.1.1;93.189.151.95:7.1.2, FromAlignment: s, {Tracking_dmark_f}, ApMailHostAddress: 93.189.151.95 X-MS-Exchange-Organization-SCL: -1 X-KLMS-AntiSpam-Interceptor-Info: scan successful X-KLMS-AntiPhishing: Clean, bases: 2023/10/12 11:06:00 X-KLMS-AntiVirus: Kaspersky Security for Linux Mail Server, version 8.0.3.30, bases: 2023/10/12 09:47:00 #22170412 X-KLMS-AntiVirus-Status: Clean, skipped X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 12 Oct 2023 05:36:13 -0700 (PDT) Hello Dmitry, ----- "Dmitry Rokosov" писал(а): ----- > Please do not use braces where is single statement. In other words: > > if (cflags & CRTSCTS) { > if (port->flags & UPF_HARD_FLOW) > val &= ~AML_UART_TWO_WIRE_EN; > else > termios->c_cflag &= ~CRTSCTS; > } else { > val |= AML_UART_TWO_WIRE_EN; > } thank you for your note, I will provide v2 without braces. -- Regards, Pavel.