Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Date:   Thu, 12 Oct 2023 09:37:55 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Robin Murphy <robin.murphy@arm.com>
Cc:     Baolu Lu <baolu.lu@linux.intel.com>, joro@8bytes.org,
        will@kernel.org, iommu@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/7] iommu: Decouple iommu_present() from bus ops
Message-ID: <20231012123755.GH3952@nvidia.com>
References: <cover.1697047261.git.robin.murphy@arm.com>
 <6711338e24dd1edfd02187f25cf40d8622cefdb2.1697047261.git.robin.murphy@arm.com>
 <43ca2a88-942e-4d65-87f1-30a7cf537edd@linux.intel.com>
 <42bbeab4-84f3-470e-bd42-2dae31b5775c@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <42bbeab4-84f3-470e-bd42-2dae31b5775c@arm.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MUk5Q29ObVE5SWJnNDR3UTFaSXZicGN6S3ZTTGMybmpZQkFsb1NyV2xwbTJn?=
 =?utf-8?B?NWhDZ3FKSXBxU1BKOEhuYzExTWdmdDJyUlJzT29Cc25hcWdKWHYycGZJRTdU?=
 =?utf-8?B?L3NBMW53Q1ZPalFEbEN0REplS1hZUWQ0S0VSLy9iMTVCUVJ5d0JzNzhlelBG?=
 =?utf-8?B?SFMydXNwRitWV29nUllRMFdyTjNDMVNEaXhNZnhVcWFaUVQ5RUhCT0xoQUgr?=
 =?utf-8?B?NC85QlFwbnVZR0RzKzRwYmhybnZpQXFDY0pUL2xlZ0VmNDA0RmNzL0dZTW9D?=
 =?utf-8?B?OWVGWlIwaGFiUUIrbU85OVc1TmNWa0Rxelkxc0FzbElYQmd4S3J0Sk13cGNS?=
 =?utf-8?B?NGV4Vitxa0FQZjdMTlVZZU1tRjc0b1M1aU5xTkYrWU0wdHk3SVoybXNTNWQ1?=
 =?utf-8?B?Zk5xWURibHVqWnhaRmVpOEdONXJHRmRvYzd6YTFLbWs2dm8wR3htQjMxMzF4?=
 =?utf-8?B?MUdySWVIMlZoTzl2Z1VMZzdXcHpnaDEzN1hDTnZMczA1T3U4d2thcldteE1R?=
 =?utf-8?B?RXNxQjZxMTdPS2RSeE50SWRMd2hScjVrMnIreEF4aEpPQXlURFNORXgraFAz?=
 =?utf-8?B?aHNnQTJBem5TRSsyaGxEb24xN1NrTnU4cGJpc0RGajEyTUk3bkc0dzdMM2c5?=
 =?utf-8?B?U3V0NEUvTU5NaUlCRUpWSWVxa0FQVDd1cS9hdjh2MlI4c3Y2RzBweFNNanJn?=
 =?utf-8?B?YmdYMnJkZUhTNWZDYmV2V1lEWVhBd2R1R1JEMnl6TXVXaGdmaVhRbFVuYStY?=
 =?utf-8?B?dytzR3NheGg1R09hdzFjY3g0WUdGT3k0cnB2amtIcTRqSzZBcldmRnU1V0Qr?=
 =?utf-8?B?c2tubEhmekg0alpxaHgwaFUwbmJSL0tGWFgvNlpEbFh1UEgyYzFnT2pRS1hQ?=
 =?utf-8?B?ZVZRQ3RqVW5icmk1TkFKWC9BYlVucm5OTFNwK3I3VGZvTngxWEhpYmMxalBL?=
 =?utf-8?B?aEtjZEE3MkRIYi9odE9lS3Riemx5b2htZGxwdUsxUkZRZGNwZzI1Y08rNy9y?=
 =?utf-8?B?YmppRDBZYUFZbW94dHZKTmxMcHJ0czhwTXhUdithWmxxLy9VeW5JVk5XV1VU?=
 =?utf-8?B?S1d2RWpYazM2OEJmUmRjQWVBN2lxUitiTGZEcTJtZW8rK0UzU2RZVDJ6OWFH?=
 =?utf-8?B?YStlb2RPN3JZb2NoYzRJQXU4a0JydlU5Vm5lUUI3MnE1T3krWjRiR3JOOFhC?=
 =?utf-8?B?UGtsMWN3TlMxVE1Rd01XL1ZsRVdRWlo0TW1OUThvdXRjcEZBOGZvMm4xMW10?=
 =?utf-8?B?dElYYm1ER0oyZStDNkViUm5sUTR3Mzk2dTNPc2t2blUxbkNKQW9XOFY0L1VV?=
 =?utf-8?B?ZVZ6THRsTFZjdEhOWGNrNzVkbVhNZWVsd2hOTFc1S3NrcnNFT0U5Y1hQSW9E?=
 =?utf-8?B?VkR0Y0tRSXZkbFg1TGRBbjJ4cVMxbmpGTnozY0dKZTFaL0JsejRaMm00NHFX?=
 =?utf-8?B?WjdsN29uYVd4Q3k5R0VNalNsdDFkcWdpeENCTFV0N0dXRzVJTUVhcWJmckxJ?=
 =?utf-8?B?ZmlKY0N1MnJkMHZUcTJjY1dQaC95VHZyUDdESWVzK0JEOHRJMllTeHZzNFJ5?=
 =?utf-8?B?QTFidjJOQmlCYlQ1Ty9PSEgveVZacEkvVGZPUXpqVGZxQjdNNFpYTlQ1a29O?=
 =?utf-8?B?Tk5DN2RKc05SRDFMcFNyT3V3UlVXV3A5YXdKa2ZhQThQWmpJOW84OTNVVXhx?=
 =?utf-8?B?UGtwRkVLRko1WVUvQzRnR2hoRVNGaVYyNjFIeDdXVnpaUU41S2w0Ym1IYzNF?=
 =?utf-8?B?L1FSS0FCUURTYW5mVVFxYTJhNGt6cW9vS3lpek1JY1RZekVnb1pZV0RGOE5l?=
 =?utf-8?B?OWEyZWVnMGd3eDZSREtWSFJkV1RWU2hzR0pPWVBhcTlGVVpUbDJxZFZiWWNM?=
 =?utf-8?B?Q3JZNnlwOHppV20yVnVydHczUzF2WXYrSnBiUkZKbDYxekY5azREelRHSUU3?=
 =?utf-8?B?bTVidFJlV2R0RnRLMENTMnA2MlNTUGp6c2Z3aVFVbnRIL1JCR0lzWFgrYTJm?=
 =?utf-8?B?dkdJNXNCaFplMC9sNmZvcEZkeFRkUS9UUGFFYnVXRnJjcWNRRnR2cGRHNUl3?=
 =?utf-8?B?NHhERlVSY05WLzV3WHl3YmxFQXJCeDZtbk92Vlh6MjV4Vkl5ZDVTakdVdVNy?=
 =?utf-8?Q?OJKlZyLvmDYBiW/1cnMvUC7Ch?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0af437ce-44d3-4ce4-e144-08dbcb200ff3
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2023 12:37:57.0940
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Yqob9pNeo2q69q0Mfgw1GPyRX+65SaN2OyCQqOeOUoDmJtlDdrrn+HTfxSTtl0zv
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4183
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Thu, 12 Oct 2023 05:38:19 -0700 (PDT)

On Thu, Oct 12, 2023 at 12:40:01PM +0100, Robin Murphy wrote:
> On 2023-10-12 07:05, Baolu Lu wrote:
> > On 10/12/23 2:14 AM, Robin Murphy wrote:
> > > Much as I'd like to remove iommu_present(), the final remaining users
> > > are proving stubbornly difficult to clean up, so kick that can down the
> > > road and just rework it to preserve the current behaviour without
> > > depending on bus ops. Since commit 57365a04c921 ("iommu: Move bus setup
> > 
> > The iommu_present() is only used in below two drivers.
> > 
> > $ git grep iommu_present
> > drivers/gpu/drm/mediatek/mtk_drm_drv.c: if
> > (!iommu_present(&platform_bus_type))
> > drivers/gpu/drm/tegra/drm.c:    if (host1x_drm_wants_iommu(dev) &&
> > iommu_present(&platform_bus_type)) {
> > 
> > Both are platform drivers and have the device pointer passed in. Just
> > out of curiosity, why not replacing them with device_iommu_mapped()
> > instead? Sorry if I overlooked previous discussion.
> 
> Yes, we've already gone round in circles on this several times, that's why
> it's explicitly called out as "stubbornly difficult" in the commit message.
> The Mediatek one is entirely redundant, but it seems I have yet to figure
> out the right CC list to get anyone to care about that patch[1].

Please just have Joerg take such a trivial patch, there is no reason
we need to torture outselves because DRM side is not behaving well. :(

Jason