Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Date:   Thu, 12 Oct 2023 14:40:56 +0200
From:   Maxime Ripard <mripard@kernel.org>
To:     Devarsh Thakkar <devarsht@ti.com>
Cc:     jyri.sarha@iki.fi, tomi.valkeinen@ideasonboard.com,
        airlied@gmail.com, daniel@ffwll.ch,
        maarten.lankhorst@linux.intel.com, tzimmermann@suse.de,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        praneeth@ti.com, nm@ti.com, vigneshr@ti.com, a-bhatia1@ti.com,
        j-luthra@ti.com, r-ravikumar@ti.com, j-choudhary@ti.com
Subject: Re: [PATCH] drm/tidss: Power up attached PM domains on probe
Message-ID: <libnfyaftywmfr2gmkdjsv6cptzjyrrx2tkxczusifnwthyh36@olzd2e5hagtr>
References: <20231009075018.2836020-1-devarsht@ti.com>
 <c9f17f9e-b9b5-9685-30ca-6a7d041dd8aa@ti.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="dml2l2bctoq47jl4"
Content-Disposition: inline
In-Reply-To: <c9f17f9e-b9b5-9685-30ca-6a7d041dd8aa@ti.com>
Precedence: bulk


--dml2l2bctoq47jl4
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Thu, Oct 12, 2023 at 05:10:06PM +0530, Devarsh Thakkar wrote:
> On 09/10/23 13:20, Devarsh Thakkar wrote:
> > Some SoC's such as AM62P have dedicated power domains
> > for OLDI which need to be powered on separetely along
> > with display controller.
> >=20
> > So during driver probe, power up all attached PM domains
> > enumerated in devicetree node for DSS.
> >=20
> > This also prepares base to add display support for AM62P.
> >=20
>=20
> NAK, for this patch, as discussed with team there are already plans
> to have separate OLDI bridge driver which should eventually handle
> the additional power domains.

Just for the record in case your current plan doesn't work out and we
need to revisit this patch: my point was that it's something that
deviates by a margin from what drivers are usually expected to do, so we
should document why that deviation is there.

The patch itself looks reasonable to me otherwise.

Maxime

--dml2l2bctoq47jl4
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCZSfpWAAKCRDj7w1vZxhR
xRRwAP91VGXS8cZOVzri71ykEss+wKMy4btdAbjPDACQgrhVYwD9EfdK3i474qdL
ZCVDRPfwLGIXZo5THQXx4sYZM9RT7ww=
=lW56
-----END PGP SIGNATURE-----

--dml2l2bctoq47jl4--