Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Message-ID: <MA0P287MB033258A24899AB56D2A13590FED3A@MA0P287MB0332.INDP287.PROD.OUTLOOK.COM>
Date:   Thu, 12 Oct 2023 20:53:40 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 7/7] riscv: dts: sophgo: add Huashan Pi board device
 tree
To:     Inochi Amaoto <inochiama@outlook.com>,
        Chao Wei <chao.wei@sophgo.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>
Cc:     Jisheng Zhang <jszhang@kernel.org>, devicetree@vger.kernel.org,
        linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
References: <IA1PR20MB49531C1C34C3E972DBBA4151BBCEA@IA1PR20MB4953.namprd20.prod.outlook.com>
 <20231009112642.477337-1-inochiama@outlook.com>
 <IA1PR20MB4953857AA6B541C1C3218F66BBCEA@IA1PR20MB4953.namprd20.prod.outlook.com>
From:   Chen Wang <unicorn_wang@outlook.com>
In-Reply-To: <IA1PR20MB4953857AA6B541C1C3218F66BBCEA@IA1PR20MB4953.namprd20.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: MA0P287MB0332:EE_|MA0P287MB2452:EE_
X-MS-Office365-Filtering-Correlation-Id: 0ef49d67-07b0-406f-3628-08dbcb2242f5
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: LJs007FoccCSB6n6osfZ1SOJXHFEQIGbvoygbUQSI3ZLModHrmpxtqTbVSqtiBmBb01gZQk3je9Gs9oN+3RTGk/DxJ9ZcR0YhcNq2yOxYSleyE1MBk6GB+j/wi5Odj0zxDkDujhk9f1QhM6GIWcuFu9B6FFpaKSGgJ5AE1awuM9xD01kHW7FZjTBIgLVep4z6LqCNaDZ4WQcqCY/+6i5t+lLatXjXV4s67b76o1+jtH7RbShCUSOQ07x7g3fVUI7DxJ/9Y9el+8+AiZn3yehECCBQeYZUR0Qc5h4s1W3LvUGUyHiYJgXAJVe1z1Ubq3w4yL3h8sn73qgeuGXcyBH/FD0AYYU8EQXWqLjA+eDyo0mtYlYNu3PXZaXcy1Kh0imqbzfP7Erz8FUsDpjIuYSr+8sqhwts3JBmAiWicAVe7eLdgr7P6OVzvzsL7FB0DdYngHL9GH0gxbalFE8JyrQSeT0s6w7pm0/8zroYraCd613CE7uj4uRfVdb/nQgWEUXb9pNMvb7VENPSQuaMNiRgwhiTdBK2DlbFVyulQiDlC0xlkLplAeBEh4Bg17YL21GpkqRgN5D0DhcLynq7WgWXaB1T9zrBUHSl2oLYSS9zaQ8HygoPwwZS1rJM56m3l2BO0VoOGlnb9oJI3uSrvmmWA==
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V3BMNFJkTlp0NXhLcHhjR2NzekRKcVl0ZHVBaDJLNk9xb2VLd0crRU8yWUYv?=
 =?utf-8?B?WUlEUDJneHRWeU5CandraCs3NzZ2Q0xIUDNTQ1VBMmlHVEZIelNzS1YyYzRP?=
 =?utf-8?B?WjQ1bkNsT1BDSytPY3IyRlZZSzNQa1NSNEFvS28vTlRwVmNTSHJaelB1QnRa?=
 =?utf-8?B?bE0zejk3dXdudk01WTI5dVpDRmlacm1KMFUzYXpkaUJoMlVJSVdnV0RHb29j?=
 =?utf-8?B?OGFXMVpMb09nR0htTkhCOXZ2bXMxRzd6T3BTQ1plTFJBNmkrQXhLaVFBbU1V?=
 =?utf-8?B?cFRiYzZvaGJZbU1Xd3FpQ2R5cVRIYnBLUkQ4RWZTL1M4bUxGWm1YYSs0TFNw?=
 =?utf-8?B?a1JUYXFkbmtKTkQ5ZnQvOFE4a2hYdm1ZZzhNQXJDdEZaRGJzRGoyUGtTN2ZZ?=
 =?utf-8?B?SklpUGhSZm81SFdKUDJMeE5SSVRjVjhNblFub2s3MnNDUmtVcnlpMXM2UlJa?=
 =?utf-8?B?WmljUE5qTit4T0JhNVBtQyszd0hWdlhRR094bVV3aEhud0JFYWlFUmRnNG5T?=
 =?utf-8?B?aXdLK2d5ZzZyMTEwVFk1R2R0SUsrUWswa1RKVFd0VFczM3VzTEZIN0tTY1Fk?=
 =?utf-8?B?c0huOGJZMzVTMjBpckh2ZFRHT09sWjMvYnNINGJhMjdJQWpoUHZZVFlUUW02?=
 =?utf-8?B?Uk8rVzZMWThHdU1HSTBhMnZLQldVcWpaeGsrU0ovSE5HeXVQbkU5NFRQMU1K?=
 =?utf-8?B?MUxURk40eEFOMElZeUt3Sll1b3pwUVVOQTlNZzlSSXNWSE5mTmRlc2pva2dn?=
 =?utf-8?B?elVLNENzMjBjZnhaTVNkNGliV0pIQUVHU3AxTTN0bFlEbGNKOFFUQWE2ejdK?=
 =?utf-8?B?SlJmSHpvbFhFUElCd09HUCtRRlg5RllETWNVWlhsVGNWZVhwNDZiZU16dmRp?=
 =?utf-8?B?UUhhSktlRGhabGlvMmZ2SlQxeEJZcG1PZmNSeWQ0MHJNQUJnVnB4ZHhsMWJU?=
 =?utf-8?B?NUxFdGwzeEl1SEFLck55MDAyNTlBdG81Sm4zQmZpZGZQUUhLeFNJMVNqbXZr?=
 =?utf-8?B?bnlqQmRHRlB0c3RhamgvZjByc05HRmtHTVViVGdmVW1iTHFrSDFDVjBIV1NZ?=
 =?utf-8?B?Zy9FVWoxM0JHdW5sWG1jUjFjNlhxb1B0V1ZDU1VYck1TMEdUdjkwb0ZhNG9n?=
 =?utf-8?B?QjB0dG9YbHYyS3JmU0hoajdLbUkrMVo3cUlTd1phOTY1dEJvZmFVU1VDaVZw?=
 =?utf-8?B?VlI4U1dXWHVoWFVjSHNsUEE1UU8wZHdWMGk3ZWNWN3A0azdUZXJYdEtBcGpu?=
 =?utf-8?B?TkY5TEdvUUpTajlxVFJjdEhzS2g0d3cwelFrRzBDQ2xtZDN1ZEE0OU1uaFVN?=
 =?utf-8?B?bHBqUXZ1Z1F5UkFnY21qZGRCTUd1R3hlUks5RXhZSlNMaDIzd0tOZWRzc0s5?=
 =?utf-8?B?eGV2c05la29DWFFEQTI2ak9HMzNoYURGWTQ2OVNUS2V0MnI0SEVnMjN0bXRw?=
 =?utf-8?B?TVdwcHFTRjB2QUNVbnZCeXdRSkVRVlB5UkdQR0NabElzMEQ2dG1Cd0RhT3BJ?=
 =?utf-8?B?TExBVk1maWFKRGJsbWFHTlpRR2pnV1RLME9ST0hnU0lmSTlpcTk4UVcxS1JJ?=
 =?utf-8?B?Mnc2UDU5ajFZbXBsSFJ5dkdSME1EeW41TlI1elluUlVBQmtnbWkrekRDNWdE?=
 =?utf-8?Q?JJloKULydOMFUxlTfWWLCJZa7er29VrRO1qQ+KE2aRkc=3D?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0ef49d67-07b0-406f-3628-08dbcb2242f5
X-MS-Exchange-CrossTenant-AuthSource: MA0P287MB0332.INDP287.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2023 12:53:42.6646
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MA0P287MB2452
X-Spam-Status: No, score=1.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,FORGED_MUA_MOZILLA,FREEMAIL_FORGED_FROMDOMAIN,
	FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Thu, 12 Oct 2023 05:54:28 -0700 (PDT)


On 2023/10/9 19:26, Inochi Amaoto wrote:
> Add initial device tree files for the Huashan Pi board.
>
> Note: The boot of CV1812H chip needs a rtos firmware for coprocessor to
> function properly. To make the soc happy, reserved the last 2M memory
> for the rtos firmware.
>
> Signed-off-by: Inochi Amaoto <inochiama@outlook.com>
> Link: https://en.sophgo.com/product/introduce/huashan.html
> Link: https://en.sophgo.com/product/introduce/cv181xH.html
> Link: https://github.com/milkv-duo/duo-buildroot-sdk/blob/develop/build/boards/cv181x/cv1812h_wevb_0007a_emmc_huashan/memmap.py#L15
> ---
>   arch/riscv/boot/dts/sophgo/Makefile           |  1 +
>   .../boot/dts/sophgo/cv1812h-huashan-pi.dts    | 48 +++++++++++++++++++
>   2 files changed, 49 insertions(+)
>   create mode 100644 arch/riscv/boot/dts/sophgo/cv1812h-huashan-pi.dts
>
> diff --git a/arch/riscv/boot/dts/sophgo/Makefile b/arch/riscv/boot/dts/sophgo/Makefile
> index 3fb65512c631..57ad82a61ea6 100644
> --- a/arch/riscv/boot/dts/sophgo/Makefile
> +++ b/arch/riscv/boot/dts/sophgo/Makefile
> @@ -1,3 +1,4 @@
>   # SPDX-License-Identifier: GPL-2.0
>   dtb-$(CONFIG_ARCH_SOPHGO) += cv1800b-milkv-duo.dtb
> +dtb-$(CONFIG_ARCH_SOPHGO) += cv1812h-huashan-pi.dtb
>   dtb-$(CONFIG_ARCH_SOPHGO) += sg2042-milkv-pioneer.dtb
> diff --git a/arch/riscv/boot/dts/sophgo/cv1812h-huashan-pi.dts b/arch/riscv/boot/dts/sophgo/cv1812h-huashan-pi.dts
> new file mode 100644
> index 000000000000..aa361f3a86bb
> --- /dev/null
> +++ b/arch/riscv/boot/dts/sophgo/cv1812h-huashan-pi.dts
> @@ -0,0 +1,48 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +/*
> + * Copyright (C) 2023 Inochi Amaoto <inochiama@outlook.com>
> + */
> +
> +/dts-v1/;
> +
> +#include "cv1812h.dtsi"
> +
> +/ {
> +	model = "Huashan Pi";
> +	compatible = "sophgo,huashan-pi", "sophgo,cv1812h";
> +
> +	aliases {
> +		gpio0 = &gpio0;
> +		gpio1 = &gpio1;
> +		gpio2 = &gpio2;
> +		gpio3 = &gpio3;
> +		serial0 = &uart0;
> +		serial1 = &uart1;
> +		serial2 = &uart2;
> +		serial3 = &uart3;
> +		serial4 = &uart4;
> +	};
> +
> +	chosen {
> +		stdout-path = "serial0:115200n8";
> +	};
> +
> +	reserved-memory {
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		ranges;
> +
> +		coprocessor_rtos: region@8fe00000 {
> +			reg = <0x8fe00000 0x200000>;
> +			no-map;
> +		};
> +	};
> +};
> +
> +&osc {
> +	clock-frequency = <25000000>;
> +};
> +
> +&uart0 {
> +	status = "okay";
> +};
> --
LGTM

Acked-by: Chen Wang <unicorn_wang@outlook.com>
> 2.42.0
>