Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Date:   Thu, 12 Oct 2023 10:20:45 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Will Deacon <will@kernel.org>
Cc:     Lorenzo Pieralisi <lpieralisi@kernel.org>,
        Catalin Marinas <catalin.marinas@arm.com>, ankita@nvidia.com,
        maz@kernel.org, oliver.upton@linux.dev, aniketa@nvidia.com,
        cjia@nvidia.com, kwankhede@nvidia.com, targupta@nvidia.com,
        vsethi@nvidia.com, acurrid@nvidia.com, apopple@nvidia.com,
        jhubbard@nvidia.com, danw@nvidia.com,
        linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/2] KVM: arm64: allow the VM to select DEVICE_* and
 NORMAL_NC for IO memory
Message-ID: <20231012132045.GI3952@nvidia.com>
References: <20230907181459.18145-1-ankita@nvidia.com>
 <20230907181459.18145-3-ankita@nvidia.com>
 <ZP8q71+YXoU6O9uh@lpieralisi>
 <ZP9MQdRYmlawNsbC@nvidia.com>
 <ZQHUifAfJ+lZikAn@lpieralisi>
 <ZQIFfqgR5zcidRR3@nvidia.com>
 <ZRKW6uDR/+eXYMzl@lpieralisi>
 <ZRLiDf204zCpO6Mv@arm.com>
 <ZR6IZwcFNw55asW0@lpieralisi>
 <20231012123541.GB11824@willie-the-truck>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231012123541.GB11824@willie-the-truck>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QEmzUlXwxliFfPfi+RTaaI6R6FEWrTZhryi0cIQdoNjxeBb/rXVgXiyjX849?=
 =?us-ascii?Q?15HgrTJOPJxjeVTYqE+A9r20v5hCJf3Y/cHL9fjfycQ2NeBqJsjI+l6dLmGX?=
 =?us-ascii?Q?slJOx3jwjAceoDUAk4C/4u1aMkLSX+WSjifdf12rURGC0+8JA1g9A4YwJSQM?=
 =?us-ascii?Q?Ilr/RS/WqvaV02AqYM5MqlgG79XkMS9Ft5phgb3ioe/eht9TzJxjmyy0kdKy?=
 =?us-ascii?Q?o4NXgb1/qgrVgOR/Jq95cnnsezsXRdlW21CZ0BA4Qnk3BWOk8mYlrtjiBUmZ?=
 =?us-ascii?Q?Pd6wk0GhLaMdLMg7xqSRwnvKLl9Evd2MFtCfesdlkum/2m/l0OvTK3RRRZff?=
 =?us-ascii?Q?aM2cj8VOi+6uKBoZVPO1xT58oSKM3vv7jRORkoDNVXydChvyYycYEzb/9Ps5?=
 =?us-ascii?Q?PdfrfFBDIn2LakygQLWucSGk83iZ/YT5qJpsFnSoAaqy5LE4LoeuONf3445q?=
 =?us-ascii?Q?wFujABN9bAPxFwwZEkBNKMSUo8HH2LGvsylD1014wvXHrW7USXLZbYyk6eUW?=
 =?us-ascii?Q?3FpD6teHkE7ddp+B7jUtEeUSnLNUMVmfzr2w6jTnBHfUlpJuJ9DYZdGL3yFT?=
 =?us-ascii?Q?Ct35HHb23IheGPJI/ZQ88E36VND2e7HTsRJ8lHlBSbK29YX4QQdQKLLMg8BD?=
 =?us-ascii?Q?pSNPKhaYQsCa0BriezcNDSvJJhqb15AftzjKRsYzWHccxTocjbxAdjPDEU7d?=
 =?us-ascii?Q?cPfb3bzTM4sbx0h/6LQrVio9ZMs8X0DHA9mcC2e4kDsQc8f6Fr6vgjfaJVyx?=
 =?us-ascii?Q?k5GE3xWDNY1YBjd1RCQcXLw5n45LDTPApg0Nycy29i/PvQPxL57wDh88XJ3v?=
 =?us-ascii?Q?oPLvvkmQ9l8HoEV+N9djlfRv6t/2PH3AHoJl9FhQtc/ueFi1mYyJ1+ToHqcH?=
 =?us-ascii?Q?xdBhmaYC54kf6FOZJqzOUhFr4TShw7K63oQsqrAjtMRc0CnC/jG1C/osb7JM?=
 =?us-ascii?Q?1y426nvoS92XJDzCgBS/xIjzpzRk6ucr+c/baE2FMa1zZ8wOgz0rhMCa8kIE?=
 =?us-ascii?Q?eQ1OOIxMQIoMUvXnihI+rD+Opv8dVsGC+YNnmBAS2wV3u5o5vhnsHmxZUQay?=
 =?us-ascii?Q?LUI7ZO1YbqT5cTyoXDUuaANqWK2YB9njgFqsGMB3LeoWK+aIiwZACuQGbIUz?=
 =?us-ascii?Q?1MoPn9lo2A5d0RaWcQupiBNW51GWmGbEZZ4UwGzqRJ51+vRWTUsmT5b9cn3X?=
 =?us-ascii?Q?adfq1YpQroh22jTRBohB2bl4/9yBIo8Rd2pI3pHu4V8pn1XRgqjp+SdRBnAQ?=
 =?us-ascii?Q?TMWPo1BmH90usgRgpq2vpohDZYLUnrpUOgS6sWAlm1qNNAtMdBjuBuTesg8I?=
 =?us-ascii?Q?mL/6NZKXlyElEVB1V3KCFHY5lQiDaFjfoM8kp70Wa6wPIQfYC8TBQ4BRK97x?=
 =?us-ascii?Q?VUqcOPiyHZ6ZIIyJMKN7XUlyhewD31450R55RMBN1Nb2Y181NNOpw5n3PEXI?=
 =?us-ascii?Q?uFPiP2uO6v9t0kBaxCVmIiBoyut9Ma+U5mHO0tERq2mz1+uMY72Y1/SOOR8b?=
 =?us-ascii?Q?h6MZJAsBuftkDS5VHj9ahRwCzTP/Vg9NSkOsuYVpw+y1qAGiVtvOBuhPo7UK?=
 =?us-ascii?Q?nM+VOE5GifE+qcjyk0AUBdj+0lkmwuexX1ZC0ks8?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6cfd1de2-4754-406f-0437-08dbcb260b5c
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2023 13:20:46.4146
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gxHZva/Xtq4yRA3ltfafgX1EUWNHtGlGOlvL2K0jNhkbn4+tW7SumhkJDwGpgdvl
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6395
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 12 Oct 2023 06:21:10 -0700 (PDT)

On Thu, Oct 12, 2023 at 01:35:41PM +0100, Will Deacon wrote:

> > Failures containability is a property of the platform
> > and is independent from the memory type used for MMIO
> > device memory mappings (ie DEVICE_nGnRE memory type is
> > even more problematic than NormalNC in terms of containability
> > since eg aborts triggered on loads cannot be made synchronous,
> > which make them harder to contain); this means that,
> > regardless of the combined stage1+stage2 mappings a
> > platform is safe if and only if device transactions cannot trigger
> > uncontained failures; reworded, the default KVM device
> > stage 2 memory attributes play no role in making device
> > assignment safer for a given platform and therefore can
> > be relaxed.
> > 
> > For all these reasons, relax the KVM stage 2 device
> > memory attributes from DEVICE_nGnRE to NormalNC.
> 
> The reasoning above suggests to me that this should probably just be
> Normal cacheable, as that is what actually allows the guest to control
> the attributes. So what is the rationale behind stopping at Normal-NC?

I agree it would be very nice if the all the memory in the guest could
just be cachable and the guest could select everything.

However, I think Lorenzo over stated the argument. The off-list
discussion was focused on NormalNC for MMIO only. Nobody raised the
idea that cachable was safe from uncontained errors for MMIO.

I'm looking through the conversations and I wouldn't jump to
concluding that "cachable MMIO" is safe from uncontained failures.

Catalin has already raised a number of conerns in the other patch
about making actual "designed to be cachable memory" into KVM
cachable.

Regards,
Jason