Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Date:   Thu, 12 Oct 2023 10:39:17 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Yi Liu <yi.l.liu@intel.com>
Cc:     joro@8bytes.org, alex.williamson@redhat.com, kevin.tian@intel.com,
        robin.murphy@arm.com, baolu.lu@linux.intel.com, cohuck@redhat.com,
        eric.auger@redhat.com, nicolinc@nvidia.com, kvm@vger.kernel.org,
        mjrosato@linux.ibm.com, chao.p.peng@linux.intel.com,
        yi.y.sun@linux.intel.com, peterx@redhat.com, jasowang@redhat.com,
        shameerali.kolothum.thodi@huawei.com, lulu@redhat.com,
        suravee.suthikulpanit@amd.com, iommu@lists.linux.dev,
        linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
        zhenzhong.duan@intel.com, joao.m.martins@oracle.com
Subject: Re: [PATCH v4 01/17] iommu: Add hwpt_type with user_data for
 domain_alloc_user op
Message-ID: <20231012133917.GL3952@nvidia.com>
References: <20230921075138.124099-1-yi.l.liu@intel.com>
 <20230921075138.124099-2-yi.l.liu@intel.com>
 <20231010165844.GQ3952@nvidia.com>
 <03ba68e9-33ef-35c1-5720-8f559f94f8a1@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <03ba68e9-33ef-35c1-5720-8f559f94f8a1@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3vyv/h9sNHIQyS2S3NK/ISgKwW3m1QdOfnyMZCknf2pccvUAQxz2nzNbzF30?=
 =?us-ascii?Q?ke/pSacoEIMkp3FcCCQcUSEnWEtRLW4jNhqUPdj/VhmhQo51gECBhGwo1EvC?=
 =?us-ascii?Q?GXSpT3FkSq5+64RNnMrNQefkULcrFgU9TtJEvUgr9vbXwEy/MZ/MaVWOy+4i?=
 =?us-ascii?Q?YFBNdpvX/7A+bVLA1hr7ne4Snx0GWuDUM5pDupzTdR+MzEOhCAJ43iYjDIQn?=
 =?us-ascii?Q?MBMry5NyEmTReD0RzNBR18fsVwnlDzDwQsOAy7jUYQKesVWPjm8mdvGVeNvB?=
 =?us-ascii?Q?o7Vns95sm7ePr+oX7ApxBk2T/Oq/Dal52lmadU8J7n/vuxAJhQVX4j8bzZ17?=
 =?us-ascii?Q?aULi41KvCSW7fNaehajpdnkZoyIC6yY4wLr3f7X1LQ+qNcAkmC0W8/thxF0W?=
 =?us-ascii?Q?aPf38v9amyi2kaPqZ69EfbplZLSkyAJrTz1gKX9D2fgzPQQDJ6tGsTBAVPUl?=
 =?us-ascii?Q?QbeOWwdAx/ri8E2i3k7BEY54xu4ZSvypRCDWCi4sMsEYWSsk5JRoKwQxM0xS?=
 =?us-ascii?Q?9m8484PVECHPKyeK7uRQxR8aRIoM+PWOYl4w6YfQHKXFR6idxlIxqyIOnJt0?=
 =?us-ascii?Q?h6s/qKezj4pruDWuTGcEXkXQdWAvO865/zpNCX/dNDoe3h/R2o1JMr7a4h0z?=
 =?us-ascii?Q?X4jSxQAPnX3bpCjjfufFXPqSQXtE3LTrgufmew3lIgMCDUYd+SLc6OaDdy89?=
 =?us-ascii?Q?qMscu3XRwudE8VAszsiyZaLRQTZlj/zKgg3JTuvPnxyvkyE6AweuaaZ0+7Ly?=
 =?us-ascii?Q?PWlHLQAX/8t2WLAPc1xjYWxvNTi+D2tgiFAIgwtEmqpz1u9Bzk0Zdm152w1l?=
 =?us-ascii?Q?c94byaKlnjUhP+fTMwF3i7AwDYfBaowg4cQxa7dIjXqS3LwS88B/YUeVlARs?=
 =?us-ascii?Q?RxrxXL5cY7RYOKGyjcHbqXcwQUgvL+jMcb//AE/LpkBWFCrok0qFcnEoZUUr?=
 =?us-ascii?Q?pqURYtx6ZlJz+5vwIpQCbmauUIbZt4Za3PA7A4tlMcbMiAejLOeqbYad3Qdl?=
 =?us-ascii?Q?nGtwrpAl7LjJYM38jez9c+Rm/hXNfg0c67ZAyWEjb18z/jFiCQIjwaMErqF2?=
 =?us-ascii?Q?9r63MLhxdqcbvYOJM3lZvmYJGFyT6noz9pxRCqrN+bMB27i2d5NdVZipLKjR?=
 =?us-ascii?Q?+niFeGQ1MRy+XMi6f50uXWKPOX2OAKG1remAAPCPkN5zXCaqC1tP4KHcS7HL?=
 =?us-ascii?Q?sEkVYrUc9zpRLCZPilKQPFy8rFuSjRyUdIsbGfKEwyxc0DJDUh2RYXoAgE0E?=
 =?us-ascii?Q?RypBjDTC/4mWoBjYKVTHQokaeXXQIZ/x/fEhCgLT7kSBOqFXngS7XN6lsvNZ?=
 =?us-ascii?Q?+dnY9I7ZhgeN1dqY2oWcN3FSKHuM+48kF67Q90zOMBebAGnZd4zscoQo90g4?=
 =?us-ascii?Q?c3DLWk6/PpiRgIEGkg5zGET4Bc+f2pWDx8t3OmUXs+ZT52+vbmaume1o18mz?=
 =?us-ascii?Q?OK/RlZh0sj2kpVWMdwe9jc4zzPcX1q7cCaFWfGOlI42BkSkaGSq5nvc5ilPe?=
 =?us-ascii?Q?0gEG+DAfJ4J5A6lGNInBFiU68bsTF79g46aT3LBOyHsCZ4T1xQZPIKP/6Xct?=
 =?us-ascii?Q?mjraTzXNDo6D7+YoZP94lkK2nhm13noBTI5T3Js5?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 043936a1-5a07-49e0-7bc0-08dbcb28a272
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2023 13:39:18.8672
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 76gHhmHY0MSqu+pGj8uk02Nx+PFrGBXzAiWUNFyFFdQCin+79IOBmCjF0HkG7/SR
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB8266
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 12 Oct 2023 06:39:40 -0700 (PDT)

On Thu, Oct 12, 2023 at 05:11:09PM +0800, Yi Liu wrote:
> On 2023/10/11 00:58, Jason Gunthorpe wrote:
> > On Thu, Sep 21, 2023 at 12:51:22AM -0700, Yi Liu wrote:
> > > diff --git a/include/linux/iommu.h b/include/linux/iommu.h
> > > index 660dc1931dc9..12e12e5563e6 100644
> > > --- a/include/linux/iommu.h
> > > +++ b/include/linux/iommu.h
> > > @@ -14,6 +14,7 @@
> > >   #include <linux/err.h>
> > >   #include <linux/of.h>
> > >   #include <uapi/linux/iommu.h>
> > > +#include <uapi/linux/iommufd.h>
> > 
> > Oh we should definately avoid doing that!
> > Maybe this is a good moment to start a new header file exclusively for
> > iommu drivers and core subsystem to include?
> > 
> >   include/linux/iommu-driver.h
> > 
> > ?
> > 
> > Put iommu_copy_user_data() and  struct iommu_user_data in there
> > 
> > Avoid this include in this file.
> 
> sure. btw. seems all the user of this API and structure are in the
> drivers/iommu directory. can we just putting them in
> drivers/iommu/iommu-priv.h?

iommu-priv.h should be private to the core iommu code, and we sort of
extended it to iommufd as well.

iommu-driver.h would be "private" to the core and all the drivers
only.

As include ../.. is often frown on at large scale it is probably
better to be in include/linux

> Just one concern. There are other paths (like cache_invalidate of
> this series and Nic's set_dev_data) uses this struct as well. I'm
> a bit worrying if it is good to put type here as type is meaningful
> for the domain_alloc_user path.

There is always a type though? I haven't got that far in the series
yet to see..

Jason