DomainKey-Signature: s=smtpout; d=dell.com; c=nofws; q=dns; b=wlDWO66VV5CZTDe9oUxOS5AabwYD7dL7/ryi1O91jASrHoPIWTXVUe2TNBNUKL20d7zayT1DcU1pORZ0glXxL4CU9cBOm7gH5uxJWxObdEtJiZb4BY6Hdy0TtST83BoH;
Date: Fri, 16 Nov 2007 09:01:16 -0600
From: Matt Domsch <Matt_Domsch@dell.com>
To: Greg Kroah-Hartman <gregkh@suse.de>
Cc: linux-kernel@vger.kernel.org, Kay Sievers <kay.sievers@vrfy.org>,
       Matt Tolentino <matthew.e.tolentino@intel.com>
Subject: Re: [PATCH 38/54] efivars: remove new_var and del_var files from sysfs
Message-ID: <20071116150116.GA8901@auslistsprd01.us.dell.com>
References: <20071102235758.GA9803@kroah.com> <1194047972-9850-38-git-send-email-gregkh@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1194047972-9850-38-git-send-email-gregkh@suse.de>
User-Agent: Mutt/1.5.11
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1144
Lines: 30

On Fri, Nov 02, 2007 at 04:59:16PM -0700, Greg Kroah-Hartman wrote:
> WTF?  Passing binary structures into a sysfs file, expecting it to be in
> the correct format/endianness?  That's just wrong on so many levels.
> 
> So, these files are deleted.  If you want to add them back, please do so
> in configfs, or in debugfs.  Or use text strings, which is what sysfs is
> only for.


I have tested gregkh's patches tree, which includes this patch, the
patch to put these back as binary blob interfaces, as well as other
cleanups, on an Itanium2 system.  The efibootmgr userspace application
continues to work as it did before this patch series, which I claim is
success.  For the patches that touch drivers/firmware/efivars.c I can
say:

Tested-by: Matt Domsch <Matt_Domsch@dell.com>

Thanks,
Matt

-- 
Matt Domsch
Linux Technology Strategist, Dell Office of the CTO
linux.dell.com & www.dell.com/linux
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/