Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Date:   Thu, 12 Oct 2023 16:30:12 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Daniel Lezcano <daniel.lezcano@linaro.org>
Cc:     Lukasz Luba <lukasz.luba@arm.com>, rafael@kernel.org,
        Amit Kucheria <amitk@kernel.org>,
        Zhang Rui <rui.zhang@intel.com>,
        "open list:THERMAL" <linux-pm@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] thermal/core: Hardening the self-encapsulation
Message-ID: <ZSgC9DxVXC-bHleo@orome.fritz.box>
References: <20231012102700.2858952-1-daniel.lezcano@linaro.org>
 <a6b51de7-4f56-4db9-a7dd-60555ac6c37f@arm.com>
 <d9f3bd7b-a5db-4d37-bb1f-f97e40c8a63a@linaro.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="cSV4NKVWE6plEgmG"
Content-Disposition: inline
In-Reply-To: <d9f3bd7b-a5db-4d37-bb1f-f97e40c8a63a@linaro.org>
User-Agent: Mutt/2.2.12 (2023-09-09)
Precedence: bulk


--cSV4NKVWE6plEgmG
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Oct 12, 2023 at 03:14:23PM +0200, Daniel Lezcano wrote:
>=20
> Hi Lukasz,
>=20
> On 12/10/2023 14:01, Lukasz Luba wrote:
> > Hi Daniel,
> >=20
> > On 10/12/23 11:26, Daniel Lezcano wrote:
> > > The thermal private header has leaked all around the drivers which
> > > interacted with the core internals. The thermal zone structure which
> > > was part of the exported header led also to a leakage of the fields
> > > into the different drivers, making very difficult to improve the core
> > > code without having to change the drivers.
> > >=20
> > > Now we mostly fixed how the thermal drivers were interacting with the
> > > thermal zones (actually fixed how they should not interact). The
> > > thermal zone structure will be moved to the private thermal core
> > > header. This header has been removed from the different drivers and
> > > must belong to the core code only. In order to prevent this private
> > > header to be included again in the drivers, make explicit only the
> > > core code can include this header by defining a THERMAL_CORE_SUBSYS
> > > macro. The private header will contain a check against this macro.
> > >=20
> > > The Tegra SoCtherm driver needs to access thermal_core.h to have the
> > > get_thermal_instance() function definition. It is the only one
> > > remaining driver which need to access the thermal_core.h header, so
> > > the check will emit a warning at compilation time.
> > >=20
> > > Thierry Reding is reworking the driver to get rid of this function [1]
> > > and thus when the changes will be merged, the compilation warning will
> > > be converted to a compilation error, closing definitively the door to
> > > the drivers willing to play with the thermal zone device internals.
> >=20
> > That looks like a good idea. Although, shouldn't we avoid the
> > compilation warnings and just first merge the fixes for drivers?
>=20
> Yes, we should but there is the series for nvidia (pointed in the changel=
og)
> which need a slight refresh for the bindings AFAIR. That series is since
> March 2023 and Thierry seems busy [1]. I'm holding the hardening since th=
en.
>=20
> So I don't know how to make progress on this? I was assuming we can merge
> this series and let the compiler recall what has to be fixed.
>=20
> [1] https://lore.kernel.org/all/ZK14edZUih1kH_sZ@orome/
>=20
> and as soon as it is fixed, we convert the WARNING to ERROR :P

Yeah, sorry about that. This has been plagued by bad luck. Since then
the device that I need to test this on broke and it then took a while to
get a new one. I still need to find time to set this up and do some more
extensive testing to make sure I haven't regressed anything.

Thierry

--cSV4NKVWE6plEgmG
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmUoAvIACgkQ3SOs138+
s6FWNw/9Fbxna4WnbhzeH/lRKiMZOxQ2Qw7RCAatQfzWLSzU0+A1G1VxwDmlTyj8
toZiJy/NkAfRGrR7Avbc6nmdnx20x4syCu9zjWcbnJcwQh+mmo3Vqg4hEW1OkbSC
GnkXEckyRIPYbOScbEElOyoxFredVScWdyddHGka+9C1H1tXE7BR+P/I2zJZP/M9
zAgo1/bvC3QHTgY3TK9yQRsZ5X10t4N14n4Q3h+RzrAQQl6Zsc5BBUh8OHt3+XTI
hIeubvBJS7dXehCA0llu9iLIqCDMBv6z/tVbjdPQZJNsshPYqpwCYEm6t3k/pnxj
EFGCWN/taqKHJi4Q36jjOFkCwoCXnKzhS1ViRcXkcZaC13n6ljiZM1/RzS3/wW2t
CP6/7IG3dWB6euXSY8LGGxHxYN17epdICpIXmH1i6Ua1vfcjY2ynISDb2Ao+4Bvq
89T7F9lGth9MneWGiDUm4n9OhEH5+q00u9sfus/MDWGLPzTqGiHKxcmjQQP0VDui
nimpP/LnPXvD3Z4CUYHZpYkE0nnIHYF4utUfeuM5lCsRp8cHtHcVpB8KN8VZR+Fl
LzUb1K6585hC28Vm87+EDI4HAZ9PpbxoJGGUsZZdBO2mzE30maU02l9UWEabEWeT
4CfdVdBuWY2mw63GiHB/tOaFvz5D5EV9lhTxib8cO46f90lEd9k=
=k0xl
-----END PGP SIGNATURE-----

--cSV4NKVWE6plEgmG--