Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Date:   Thu, 12 Oct 2023 15:36:53 +0100
From:   Conor Dooley <conor@kernel.org>
To:     Jisheng Zhang <jszhang@kernel.org>
Cc:     Paul Walmsley <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>, Guo Ren <guoren@kernel.org>,
        linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
        Emil Renner Berthing <emil.renner.berthing@canonical.com>
Subject: Re: [PATCH v3 1/2] riscv: errata: thead: use riscv_nonstd_cache_ops
 for CMO
Message-ID: <20231012-pranker-usage-09a85a36356f@spud>
References: <20231012141456.4078-1-jszhang@kernel.org>
 <20231012141456.4078-2-jszhang@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="tLH7qnMb79tGa+m2"
Content-Disposition: inline
In-Reply-To: <20231012141456.4078-2-jszhang@kernel.org>
Precedence: bulk


--tLH7qnMb79tGa+m2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Oct 12, 2023 at 10:14:55PM +0800, Jisheng Zhang wrote:
> Previously, we use alternative mechanism to dynamically patch
> the CMO operations for THEAD C906/C910 during boot for performance
> reason. But as pointed out by Arnd, "there is already a significant
> cost in accessing the invalidated cache lines afterwards, which is
> likely going to be much higher than the cost of an indirect branch".
> And indeed, there's no performance difference with GMAC and EMMC per
> my test on Sipeed Lichee Pi 4A board.
>=20
> Use riscv_nonstd_cache_ops for THEAD C906/C910 CMO to simplify
> the alternative code, and to acchieve Arnd's goal -- "I think
> moving the THEAD ops at the same level as all nonstandard operations
> makes sense, but I'd still leave CMO as an explicit fast path that
> avoids the indirect branch. This seems like the right thing to do both
> for readability and for platforms on which the indirect branch has a
> noticeable overhead."
>=20
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> Tested-by: Emil Renner Berthing <emil.renner.berthing@canonical.com>

=46rom v2:
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

--tLH7qnMb79tGa+m2
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZSgEhQAKCRB4tDGHoIJi
0oQqAP9E3GPMvuDoXMFDfJdL0fEkQ1D91Q115ThR1vWUqlcKCwEAmZexxPc2Ytz3
XSpUhcOVF4jxrEhP3FjNPNvYpXJp6wg=
=NXCq
-----END PGP SIGNATURE-----

--tLH7qnMb79tGa+m2--