Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
MIME-Version: 1.0
References: <20231006205415.3501535-1-kuba@kernel.org> <ZSQ7z8gqIemJQXI6@google.com>
 <20231009110613.2405ff47@kernel.org> <ZSRVoYbCuDXc7aR7@google.com>
 <20231009144944.17c8eba3@kernel.org> <87sf6i6gzh.fsf@intel.com>
 <20231010072359.0df918e9@kernel.org> <ZSXiapPMIPj3ko41@google.com>
In-Reply-To: <ZSXiapPMIPj3ko41@google.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
Date:   Thu, 12 Oct 2023 17:17:59 +0200
Message-ID: <CABgObfa=k+xHztWPhWU31UqTgnoO=Yn7uT+9W-G9S7VW_HciQA@mail.gmail.com>
Subject: Re: [PATCH] KVM: deprecate KVM_WERROR in favor of general WERROR
To:     Sean Christopherson <seanjc@google.com>
Cc:     Jakub Kicinski <kuba@kernel.org>,
        Jani Nikula <jani.nikula@intel.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        workflows@vger.kernel.org, linux-kernel@vger.kernel.org,
        kvm@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Oct 11, 2023 at 1:46=E2=80=AFAM Sean Christopherson <seanjc@google.=
com> wrote:
> > > The DRM_I915_WERROR config depends on EXPERT and !COMPILE_TEST, and t=
o
> > > my knowledge this has never caused issues outside of i915 developers =
and
> > > CI.
> >
> > Ack, I think you do it right. I was trying to establish a precedent
> > so that we can delete these as soon as they cause an issue, not sooner.
>
> So isn't the underlying problem simply that KVM_WERROR is enabled by defa=
ult for
> some configurations?  If that's the case, then my proposal to make KVM_WE=
RROR
> always off by default, and "depends on KVM && EXPERT && !KASAN", would ma=
ke this
> go away, no?

No objection to adding EXPERT. Adding W=3D1 when build-testing KVM
patches is a good
idea, you will still get the occasional patch from someone who didn't
have it but that's fine.

I added KVM_WERROR a relatively long time ago after a warning scrolled
away too quickly (a
harmless one, but also a kind that honestly shouldn't have made it to
Linus). At the time there
were still too many warnings to enable WERROR globally, and I feel
that now we're on the
same boat with W=3D1. I think we should keep KVM_WERROR (which was based on
DRM_I915_WERROR indeed) and maintainers should just add W=3D1 when build-te=
sting
KVM patches.

Paolo