Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Date:   Thu, 12 Oct 2023 10:27:05 -0500
From:   Bjorn Helgaas <helgaas@kernel.org>
To:     Shuai Xue <xueshuai@linux.alibaba.com>
Cc:     chengyou@linux.alibaba.com, kaishen@linux.alibaba.com,
        yangyicong@huawei.com, will@kernel.org,
        Jonathan.Cameron@huawei.com, baolin.wang@linux.alibaba.com,
        robin.murphy@arm.com, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org,
        rdunlap@infradead.org, mark.rutland@arm.com,
        zhuo.song@linux.alibaba.com, renyu.zj@linux.alibaba.com
Subject: Re: [PATCH v7 2/4] PCI: Add Alibaba Vendor ID to linux/pci_ids.h
Message-ID: <20231012152705.GA1070955@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231012145940.GA1069329@bhelgaas>
Precedence: bulk

On Thu, Oct 12, 2023 at 09:59:40AM -0500, Bjorn Helgaas wrote:
> On Thu, Oct 12, 2023 at 11:28:54AM +0800, Shuai Xue wrote:
> > The Alibaba Vendor ID (0x1ded) is now used by Alibaba elasticRDMA ("erdma")
> > and will be shared with the upcoming PCIe PMU ("dwc_pcie_pmu"). Move the
> > Vendor ID to linux/pci_ids.h so that it can shared by several drivers
> > later.
> > 
> > Signed-off-by: Shuai Xue <xueshuai@linux.alibaba.com>
> 
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>	# pci_ids.h

Hehe, just noticed that I acked this previously:
https://lore.kernel.org/r/20230606153143.GA1124867@bhelgaas

You can pick up acks like that and include them when you post future
versions so people don't have to ack them again.  (Drop the acks if
you make significant changes to the patch, of course.)

> > ---
> >  drivers/infiniband/hw/erdma/erdma_hw.h | 2 --
> >  include/linux/pci_ids.h                | 2 ++
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/infiniband/hw/erdma/erdma_hw.h b/drivers/infiniband/hw/erdma/erdma_hw.h
> > index 9d316fdc6f9a..a155519a862f 100644
> > --- a/drivers/infiniband/hw/erdma/erdma_hw.h
> > +++ b/drivers/infiniband/hw/erdma/erdma_hw.h
> > @@ -11,8 +11,6 @@
> >  #include <linux/types.h>
> >  
> >  /* PCIe device related definition. */
> > -#define PCI_VENDOR_ID_ALIBABA 0x1ded
> > -
> >  #define ERDMA_PCI_WIDTH 64
> >  #define ERDMA_FUNC_BAR 0
> >  #define ERDMA_MISX_BAR 2
> > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> > index 5fb3d4c393a9..d8760daf9e5a 100644
> > --- a/include/linux/pci_ids.h
> > +++ b/include/linux/pci_ids.h
> > @@ -2601,6 +2601,8 @@
> >  #define PCI_VENDOR_ID_TEKRAM		0x1de1
> >  #define PCI_DEVICE_ID_TEKRAM_DC290	0xdc29
> >  
> > +#define PCI_VENDOR_ID_ALIBABA		0x1ded
> > +
> >  #define PCI_VENDOR_ID_TEHUTI		0x1fc9
> >  #define PCI_DEVICE_ID_TEHUTI_3009	0x3009
> >  #define PCI_DEVICE_ID_TEHUTI_3010	0x3010
> > -- 
> > 2.39.3
> > 
> > 
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel