Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <a02c0f3b-2258-425f-94e4-a76739a24f00@intel.com>
Date:   Thu, 12 Oct 2023 09:01:53 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v12 04/10] x86/resctrl: Add comments on RFTYPE flags
 hierarchy
Content-Language: en-US
To:     <babu.moger@amd.com>, <corbet@lwn.net>, <tglx@linutronix.de>,
        <mingo@redhat.com>, <bp@alien8.de>
CC:     <fenghua.yu@intel.com>, <dave.hansen@linux.intel.com>,
        <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
        <akpm@linux-foundation.org>, <quic_neeraju@quicinc.com>,
        <rdunlap@infradead.org>, <damien.lemoal@opensource.wdc.com>,
        <songmuchun@bytedance.com>, <peterz@infradead.org>,
        <jpoimboe@kernel.org>, <pbonzini@redhat.com>,
        <chang.seok.bae@intel.com>, <pawan.kumar.gupta@linux.intel.com>,
        <jmattson@google.com>, <daniel.sneddon@linux.intel.com>,
        <sandipan.das@amd.com>, <tony.luck@intel.com>,
        <james.morse@arm.com>, <linux-doc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <bagasdotme@gmail.com>,
        <eranian@google.com>, <christophe.leroy@csgroup.eu>,
        <jarkko@kernel.org>, <adrian.hunter@intel.com>,
        <quic_jiles@quicinc.com>, <peternewman@google.com>
References: <20231010233335.998475-1-babu.moger@amd.com>
 <20231010233335.998475-5-babu.moger@amd.com>
 <71539687-13cf-405d-bf7c-27480e49e872@intel.com>
 <fa03a5ca-fb16-47bb-a2c8-5cc4d96e54a9@amd.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <fa03a5ca-fb16-47bb-a2c8-5cc4d96e54a9@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QVYyNTJ1YnlSS3ovMWRRVmppZHBzTjIydmhlU3VTTGc2eUY0YW1JTlM0L1dh?=
 =?utf-8?B?Mjl3Q1R5SjN4QWZJeW5NRnU2b2Z4ck1XcHhxRWRXSWY2dDJqamdIcTFaSmlv?=
 =?utf-8?B?Y3BienVNMGh3cXBOU1N5ek5PWTBRUU9FVE90aEhYVWdUNW5rSjRITlNFV0Fo?=
 =?utf-8?B?eGdYRnJzbzVOZ001SDRMdTd2ME85UURHVGJlY1QvNDNoN1BzTnpVWk51cXFs?=
 =?utf-8?B?WXc5OEltcVhsZldBdXVjdWFVcnpyRkFNellRMWozQmVIU0ltdmJiYTdRbzRB?=
 =?utf-8?B?dENveWdUMkdLcE4wMFBUOThnUEY1d0ZYZTl6ZUEyWjNhQ3ZDbUhmdXRaemg4?=
 =?utf-8?B?a0xHN3ZYMUxVYmt0RWR6SlVIMTAramhRckNoK3JBWFVUR0N3TFF3dFI1WWtM?=
 =?utf-8?B?RFNYSXlPeTZGOWFGNmd0T0t4bSs2aGkxaVZXalB3T2NMU01MeFR6eEFVUHhx?=
 =?utf-8?B?S3dxVEllWnMvQW1udWNtZnN3SFZ1bXF2WklWR0xoUmFicStCNFhmM3dFcWhp?=
 =?utf-8?B?LzBROW5YUEJDWTJOR3kwZ0JsSzFCb0lua3cyT25BTG9Gd0VmWTExVlFXdVBQ?=
 =?utf-8?B?SitYem4vanJGaWZFV0hTc1MrNHF1SG5SQmJJTjlaZG5oRmM3aWJ2WTZZTkth?=
 =?utf-8?B?aW9OZVNKODNzN256b1NRTFFEdUg4V0JOQnRLVHZlajI0dys1Y0pFOHRPMkcr?=
 =?utf-8?B?SDU0Rkx1OG51eEFVYnF1bEZBZWh3WWUrYUJXZlNUVnRDdlR6dVQxYXF6Qm43?=
 =?utf-8?B?RDVjbm9yRWhleXVuZ3hnUjFhQWllREZMQlVLMmc2Z0Z0RFpnVGJ6WElJZTFI?=
 =?utf-8?B?enVqQ3ZlSGhBS0RqKzVITzZFL1VHOXpWZ2dBQ3B6eC9zUStTSkJVdy9kUTN3?=
 =?utf-8?B?MXpuSzIrUzRkOEdPNmFINmdHaW5tTXZFNTZkMURTbitoNnhDSTM4QlZ6NVVv?=
 =?utf-8?B?OFNabitiWFEvMS9BWEU1WS8rQVJkMFl5V0hjZ24vZWdLam9QbDNmTnJ4a0dn?=
 =?utf-8?B?Q05KWTlXNXozemttQzBwTTNOWkpuUklodlFLdmYwMVVEVlBIeHVoeDNoSTJB?=
 =?utf-8?B?bVFXUUJEckNLVTduR1l0a0VLNUVoUExHbTExbUhVTm41NlBvdEJMV2JleWxQ?=
 =?utf-8?B?MjVrNXlIajJubmp4bEM1cWk5dGZ4bGxhZEpVekJwcnlFUnVuUXlVaVpBelEr?=
 =?utf-8?B?M2svQzZWK3dBaE9pZFBaTE9UWVI5Z3RrUGROS2JFM01WSnd6SkRKQ3RBZUdt?=
 =?utf-8?B?SWdIdnlMakRpTDBsSk9zRHNtNHhncGh1cWJVOUM3ZlcrNDJRcjl4c3hPK0dn?=
 =?utf-8?B?RWI4MzN4ZFN3aCtDVk44OVREeURrTG9TMHZpbXFjdENEOWI2NVRvMDlEbW8v?=
 =?utf-8?B?SGxRRm9IZkJkcFlzWGlmN2JJczFDVlFKaFVlQTc0YUo2V0JtbkVVRXF4SU10?=
 =?utf-8?B?NGhBWkIxUkQwNlNxT1NJSTRvMkJDUVBmNFFHaVlmMU94Q0l3bzNBOTN2WUVM?=
 =?utf-8?B?T3FnWWJzWVQ5c3JkN0F4VjhpOHZlbUF2dDJsNHNQVTNTWTF2SlM1RExBdnpT?=
 =?utf-8?B?UUFCQVNwald1RjRNQzdSTzRwWHBRdld0K0Z2NS93b2lvZEFRaDZYV09SVjJX?=
 =?utf-8?B?WEJ4WTFPd2sybGNxTSsydWk4dHpyaExUY01VRjVNbXJ2VVltQzNnN2JYYzBC?=
 =?utf-8?B?a0lqQTlyZmJSY1l3RVBtU2FXWTBNM2ZxeXlIQ0Y3ODgzT3Z3ZWlmSFpUM21t?=
 =?utf-8?B?NzU5L3lZcWdJdVYrN0tQNFBvYkFDOStpcy9ZTTJrOTVoYzRCc2NCMDBHY0pX?=
 =?utf-8?B?d2xLMmxZbEJ2UkVPdHhsdW1uenN6RUlJZ0NjeTdTbVZLaWdwQ0dOZUtFNU02?=
 =?utf-8?B?SktDbytFTkl0Q2o2d0FRV1hCenIwT3NxUUxQMUlEaFFvMU1jOFNERldhRzRU?=
 =?utf-8?B?aWw4Y3UreFVlbFdsY0c0VnlFbkJUR28yNGhpRUh2OS93SXNpSjIwb1NScUNC?=
 =?utf-8?B?TWJleXF1OTgrN1ZpWWEvdTRWMWZWaWsrWENTN2RLMUkxSzZzaDZvS0tMeWJW?=
 =?utf-8?B?dFRqblJ5QThneXQrMkJ6OFFDNkxIcENNQmlPbEY2V2E4RUQ0THJBZ3Z6Tm8z?=
 =?utf-8?B?K0Jjc1Q0UDZjcCtja01VUWVwSlFUcjdkWkx4QjdMeXdJeFNDamNoUWtMRkVq?=
 =?utf-8?B?clE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6d8d0a83-7040-40c8-0b03-08dbcb3c8f3d
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2023 16:01:56.6309
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sqHUyZ5U550ny+aBTSzYFJUTDmEFeemCG8dl1oRAzNCTZLVWhPqMkBQbqxrRykKACSUkIiFu+RlSeurSfcvbk8ZgbrJRQ/u772jBkNVMFsg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6120
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 12 Oct 2023 09:04:00 -0700 (PDT)

Hi Babu,

On 10/11/2023 9:57 AM, Moger, Babu wrote:
> Sure. Will remove Reviewed-by on this patch. Please let me know about
> other patches when you get a chance.

From what I can tell, apart from moving the flags text to Documentation,
there is only one other code related change and that is just moving the
RFTYPE_MON_BASE definition to a later patch. That looks good to me.

The other changes are all in the commit messages and that mostly looks
good to me ... some issues seemed to have slipped in during this version
and I will point them out in responses to the individual patches.

Reinette