Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <28f089f4-992b-4331-81cb-100a1814fc56@intel.com>
Date:   Thu, 12 Oct 2023 09:02:13 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v12 09/10] x86/resctrl: Add support for the files for MON
 groups only
Content-Language: en-US
To:     Babu Moger <babu.moger@amd.com>, <corbet@lwn.net>,
        <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>
CC:     <fenghua.yu@intel.com>, <dave.hansen@linux.intel.com>,
        <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
        <akpm@linux-foundation.org>, <quic_neeraju@quicinc.com>,
        <rdunlap@infradead.org>, <damien.lemoal@opensource.wdc.com>,
        <songmuchun@bytedance.com>, <peterz@infradead.org>,
        <jpoimboe@kernel.org>, <pbonzini@redhat.com>,
        <chang.seok.bae@intel.com>, <pawan.kumar.gupta@linux.intel.com>,
        <jmattson@google.com>, <daniel.sneddon@linux.intel.com>,
        <sandipan.das@amd.com>, <tony.luck@intel.com>,
        <james.morse@arm.com>, <linux-doc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <bagasdotme@gmail.com>,
        <eranian@google.com>, <christophe.leroy@csgroup.eu>,
        <jarkko@kernel.org>, <adrian.hunter@intel.com>,
        <quic_jiles@quicinc.com>, <peternewman@google.com>
References: <20231010233335.998475-1-babu.moger@amd.com>
 <20231010233335.998475-10-babu.moger@amd.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20231010233335.998475-10-babu.moger@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eTJuWEhqbW1WWnZKTUJLcEtCZ09wUzlibzltcG1yVS9JQmx1Q0FnTDlYWEJI?=
 =?utf-8?B?WVRCWThDT2NJek9VZC9sSWZLVXdXV2ZOVHVNYjE5b0dyOWlsS1p3Mm4zMUk5?=
 =?utf-8?B?VDNNZjdaYlpSQ1dOVnpOczgvVHViQjREa3BWcjIyYW5CL0ZQT0V6RDFOMWZ2?=
 =?utf-8?B?bEFtSkl3SzRVZFBENVBkcmtyOW5pZ1JWRTRRbm9uejAzck4xb09tNldlNlZD?=
 =?utf-8?B?MkpYZlJ5YjNPZE8wRCtRb01kVHVsNGx6N1k3ZTlTa0VVbjgrUkxuQ2ovQU5m?=
 =?utf-8?B?dCs3NjJqV2RCTGI4a0tveSsxWFV0RVYwU1pIdGNFZ25TM0pOaVhINFloUGgy?=
 =?utf-8?B?a3hyM3FNVnVGTkc3SDYyRnNLYmlKeGpQQlNXQmZPYXFGeTlveTUrZURXYWxD?=
 =?utf-8?B?Tno3Rm1aK0gyUXdhWkcyZ0xqaXE2a1BhZEN4bjRTT2FpaUJuZWx4ZU9FWE5K?=
 =?utf-8?B?MGkyTHBDd3RHKzNYQzh2dkIzTFV5YzBsSzduRy80cGI4SWNYbkIrMEtmWGlH?=
 =?utf-8?B?SEFkUUYvRkJhbVZadUNVK3g1M2MzR3JmZzdhMGFacGI4a1RoRk9uYUJSQWdq?=
 =?utf-8?B?OWRwUmpPeHZaWXRVbDN6bEpnWjNoYkpvWU9ydzJQRUNaUUVrVHdOUitsQU9C?=
 =?utf-8?B?eUhwajE0Q1UzVE9lSU1FWm4yaTFmV3JhYnFUVHJ6Z2dWa0VXOW1hU1VUSW9N?=
 =?utf-8?B?NWd0YXg5dTFhY0x2eHJHYUEyZUZyYU55dFFBWWprUm5NbElJZFpCMWMzM3J4?=
 =?utf-8?B?ZERsYjNtRC9VdFhSTDRLaUJIWHRMMEM2dk9OcTBWWmpQa3l0U3A1R0ZRZlB6?=
 =?utf-8?B?anA2WGdPZ0FQWU5IRER6N1V3Q1I5VkNDWmhBMDJOUk1FVEpCUkorYnI5NllF?=
 =?utf-8?B?clQ3R2ZqSmgvSy9OUmtPZU9YOVVPY2MwRXhXOU5WU0NhY1hQSTR3Z3k5SG5t?=
 =?utf-8?B?VGY1T2FIK0tRdVJRZDR0dm9MYkh3blFUbDNQUElBazZjMGJlMDF3dUtQcHdF?=
 =?utf-8?B?UDdJd0NYQVZQOVpCd0M3R1JKV1RNNkdPdHM5SGVNOWI2WmZuem0zZ21QUmFk?=
 =?utf-8?B?MlZLZXdBVDVJcWhETHh5RFlHSVUrRkdSL1NvazYybDNobnhrZUhwRTNVczZQ?=
 =?utf-8?B?Z2VhazVuUG5YQXFTa2kreUZFdHlqaytIbjJHcHNtcWVGQXZ5RmFwa1hqOWZl?=
 =?utf-8?B?NllHTWo4RXFEN1k2TEgxM25xT01XRmFpTkhac2pPVkVmRGRucVZtbGdoVUNs?=
 =?utf-8?B?LzhnK1ZUZ283MjU4ZnE5aGszSDJSQjJ0Uk8ySUFkSlY5SUxoL1Ird1JBQTQ3?=
 =?utf-8?B?TmR2T0N5NEJTclZYZWRTTmR6ekZvK2JnclJQUCtXNDYyWWlXVXkzNTBseC9Z?=
 =?utf-8?B?UUpTbzlOdGFObTROQ0JuMVlzMkFaV0QzVnRoUGtBYlR6M2JXN1Y1Z1dlUzVp?=
 =?utf-8?B?Y051UEoxMlBqNUE1TC9xMFlwRU9wQlRmNDkwS2pKVFRtMlJVVjIxb2hUQVV2?=
 =?utf-8?B?Mk1PdzIvNDA4YzFpNjNENnM0M2U1MXk0WElxeDJ3aEJrMVROVmc2THcrdlBE?=
 =?utf-8?B?d01US2xNa0IvQlFEL3FEcTBnTnB2RURIalQvOXpEYWVSYmU4R3hkcnc4bXdP?=
 =?utf-8?B?SGtUT1FmMU5xamxLZXlPRUFkSlVydTZWZGxGcGNSQkp2U1NRNXd2TS9iaWwr?=
 =?utf-8?B?eW5wUTY4dk04WjRJaFdpd1crZWk1SW9PdXpyRVY5TW1ZaXNLdm9GUVBnM3JK?=
 =?utf-8?B?ZXA0K1Zrak9hajZUdGh0SDdzTG5uUnJPeEdPWitCb254d1RrTExVL0ZCNjlN?=
 =?utf-8?B?MVFzdjRuRWYwUUQyRWRua2wwQzZaOW9taW04TzVlaWpQdFgzVTZ3UjVJbVF1?=
 =?utf-8?B?UjlGL01mdWE5bG9hdHJFaEpkZDFZbDk4Z3FDSEhUL1QxdG0xUkVRQXE2Y1I2?=
 =?utf-8?B?L202OVR2aDk2bHFwcTUxY0d1QU1ZOWpqRWNMTU5kYVdLem9GVDZqZDAzMURL?=
 =?utf-8?B?bndpNm1qQm1Fbyszbk1CcCtjNGQySm9WUW9xcjVEOWd0Z05HWW5vZzhjdlo3?=
 =?utf-8?B?dUs4MWVVZVNlQkpOTHEzSnJjOFRTKzRDaXZXVCtmQmIyd2lnU2NTeWZ5TnJO?=
 =?utf-8?B?bVRMdWxaSzdtVi9XTHJmK1FlOEdRUDd6ZTJGdFoxTGVyRUFKQmRGYXJOZzBw?=
 =?utf-8?B?WFE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: cf6b5ea8-e579-41a8-5ae5-08dbcb3c9aa0
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2023 16:02:15.7267
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AGa62EsJVsh5bgScDYSFR4m2BToAM406rivcJTmANESyQyTdtQJEmezT1gfqpjMv/VuU1O0dG1P/GxCxFXkq7OlyY8put1MwlVhKUwDrj1Y=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6120
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 12 Oct 2023 09:05:04 -0700 (PDT)

Hi Babu,

On 10/10/2023 4:33 PM, Babu Moger wrote:
> Files unique to monitoring groups have the RFTYPE_MON flag. When a new
> monitoring group is created the resctrl files with flags RFTYPE_BASE
> (files common to all resource groups) and RFTYPE_MON (files unique to
> monitoring groups) are created to support interacting with the new
> monitoring group.
> 
> A resource group can support both monitoring and control, also termed
> a CTRL_MON resource group. CTRL_MON groups should get both monitoring
> and control resctrl files but that is not the case. Only the
> RFTYPE_BASE and RFTYPE_CTRL files are created for CTRL_MON groups.

There can be an empty line here to make this easier to read since that would
separate the problem from the solution.

> Ensure that files with the RFTYPE_MON flag are created for CTRL_MON groups.
> 
> Signed-off-by: Babu Moger <babu.moger@amd.com>
> Tested-by: Peter Newman <peternewman@google.com>
> Reviewed-by: Peter Newman <peternewman@google.com>
> Tested-by: Tan Shaopeng <tan.shaopeng@jp.fujitsu.com>
> Reviewed-by: Tan Shaopeng <tan.shaopeng@jp.fujitsu.com>
> Reviewed-by: Fenghua Yu <fenghua.yu@intel.com>
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
> --

Missing a "-" that will make the patch description not be as intended.

Reinette